cputlb: document iotlb.addr, fix txfail physaddr

[Qemu-devel] [PATCH 0/2] cputlb: document iotlb.addr, fix txfail physaddr

Posted by Peter Maydell 5 years, 10 months ago

This patchset is two vaguely related patches that I wrote
while I was trying to understand the cputlb code enough to
add support for small-MPU-regions for v7M/v8M.

Patch 1 is just a docs comment patch, describing what the
CPUIOTLBEntry 'addr' field actually contains.

Patch 2 fixes a bug that doesn't yet have any visible effects
(we were passing cpu_transaction_failed() the wrong value for
the physaddr) roughly as suggested by Paolo back in
https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg02419.html

thanks
-- PMM

Peter Maydell (2):
  cpu-defs.h: Document CPUIOTLBEntry 'addr' field
  cputlb: Pass cpu_transaction_failed() the correct physaddr

 include/exec/cpu-defs.h |  9 +++++++
 include/exec/exec-all.h | 13 ++++++++--
 accel/tcg/cputlb.c      | 56 +++++++++++++++++++++++++++++++----------
 exec.c                  |  5 ++--
 4 files changed, 66 insertions(+), 17 deletions(-)

-- 
2.17.1

Re: [Qemu-devel] [PATCH 0/2] cputlb: document iotlb.addr, fix txfail physaddr

Posted by Paolo Bonzini 5 years, 10 months ago

On 11/06/2018 14:56, Peter Maydell wrote:
> This patchset is two vaguely related patches that I wrote
> while I was trying to understand the cputlb code enough to
> add support for small-MPU-regions for v7M/v8M.
> 
> Patch 1 is just a docs comment patch, describing what the
> CPUIOTLBEntry 'addr' field actually contains.
> 
> Patch 2 fixes a bug that doesn't yet have any visible effects
> (we were passing cpu_transaction_failed() the wrong value for
> the physaddr) roughly as suggested by Paolo back in
> https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg02419.html
> 
> thanks
> -- PMM

Both patches

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Re: [Qemu-devel] [PATCH 0/2] cputlb: document iotlb.addr, fix txfail physaddr

Posted by Peter Maydell 5 years, 10 months ago

On 11 June 2018 at 13:56, Peter Maydell <peter.maydell@linaro.org> wrote:
> This patchset is two vaguely related patches that I wrote
> while I was trying to understand the cputlb code enough to
> add support for small-MPU-regions for v7M/v8M.
>
> Patch 1 is just a docs comment patch, describing what the
> CPUIOTLBEntry 'addr' field actually contains.
>
> Patch 2 fixes a bug that doesn't yet have any visible effects
> (we were passing cpu_transaction_failed() the wrong value for
> the physaddr) roughly as suggested by Paolo back in
> https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg02419.html
>
> thanks
> -- PMM
>
> Peter Maydell (2):
>   cpu-defs.h: Document CPUIOTLBEntry 'addr' field
>   cputlb: Pass cpu_transaction_failed() the correct physaddr

I'll put these in via target-arm.next (with the ramaddr_t/ram_addr_t
typo fixed), unless anybody would prefer them to go via another route.

thanks
-- PMM

Re: [Qemu-devel] [PATCH 0/2] cputlb: document iotlb.addr, fix txfail physaddr

Posted by Richard Henderson 5 years, 10 months ago

On 06/15/2018 12:13 AM, Peter Maydell wrote:
>> Peter Maydell (2):
>>   cpu-defs.h: Document CPUIOTLBEntry 'addr' field
>>   cputlb: Pass cpu_transaction_failed() the correct physaddr
> 
> I'll put these in via target-arm.next (with the ramaddr_t/ram_addr_t
> typo fixed), unless anybody would prefer them to go via another route.

Perfect, thanks.


r~