From nobody Tue Apr 30 05:23:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1528427050885776.8192818403007; Thu, 7 Jun 2018 20:04:10 -0700 (PDT) Received: from localhost ([::1]:32804 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fR7h4-0001ZB-Ki for importer@patchew.org; Thu, 07 Jun 2018 23:04:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fR7g6-00018P-2p for qemu-devel@nongnu.org; Thu, 07 Jun 2018 23:03:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fR7g2-0005Q1-VN for qemu-devel@nongnu.org; Thu, 07 Jun 2018 23:03:02 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2544 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fR7g2-0005Kq-AD for qemu-devel@nongnu.org; Thu, 07 Jun 2018 23:02:58 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 09D0813D6857; Fri, 8 Jun 2018 11:02:42 +0800 (CST) Received: from localhost (10.177.68.90) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.382.0; Fri, 8 Jun 2018 11:02:37 +0800 From: liujunjie To: , , Date: Fri, 8 Jun 2018 11:02:15 +0800 Message-ID: <20180608030215.23040-1-liujunjie23@huawei.com> X-Mailer: git-send-email 2.13.3.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.177.68.90] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 45.249.212.191 Subject: [Qemu-devel] [PATCH] cpu hot-del: leak fix by free the relevant members X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linzhecheng@huawei.com, weidong.huang@huawei.com, liujunjie , wangxinxin.wang@huawei.com, qemu-devel@nongnu.org, arei.gonglei@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" THese leaks are found by ASAN with CPU hot-add and hot-del actions, such as: =3D=3D14127=3D=3DERROR: LeakSanitizer: detected memory leaks Direct leak of 4096 byte(s) in 1 object(s) allocated from: #0 0x7fc321cb6ec0 in posix_memalign (/usr/local/gcc-6-4/lib64/libasan.s= o.3+0xc7ec0) #1 0xf756b9 in qemu_try_memalign util/oslib-posix.c:110 #2 0xf7575b in qemu_memalign util/oslib-posix.c:126 #3 0x7769cb in kvm_arch_init_vcpu /root/qemu/target/i386/kvm.c:1103 #4 0x4cc4e6 in qemu_kvm_cpu_thread_fn /root/qemu/cpus.c:1201 #5 0x7fc31cb28dc4 in start_thread (/usr/lib64/libpthread.so.0+0x7dc4) Direct leak of 4096 byte(s) in 1 object(s) allocated from: #0 0x7fc321cb6560 in calloc (/usr/local/gcc-6-4/lib64/libasan.so.3+0xc7= 560) #1 0x7fc31cf944d6 in g_malloc0 (/usr/lib64/libglib-2.0.so.0+0x4f4d6) #2 0x4cc4e6 in qemu_kvm_cpu_thread_fn /root/qemu/cpus.c:1201 #3 0x7fc31cb28dc4 in start_thread (/usr/lib64/libpthread.so.0+0x7dc4) Direct leak of 184 byte(s) in 1 object(s) allocated from: #0 0x7fc321cb6560 in calloc (/usr/local/gcc-6-4/lib64/libasan.so.3+0xc7= 560) #1 0x7fc31cf944d6 in g_malloc0 (/usr/lib64/libglib-2.0.so.0+0x4f4d6) #2 0x4cda83 in qemu_init_vcpu /root/qemu/cpus.c:1993 #3 0x6aedbd in x86_cpu_realizefn /root/qemu/target/i386/cpu.c:4739 #4 0x8edfc8 in device_set_realized hw/core/qdev.c:826 #5 0xcff60c in property_set_bool qom/object.c:1928 #6 0xd09bd2 in object_property_set_qobject qom/qom-qobject.c:27 #7 0xd048e3 in object_property_set_bool qom/object.c:1188 #8 0x79ad83 in qdev_device_add /root/qemu/qdev-monitor.c:627 #9 0x79b50c in qmp_device_add /root/qemu/qdev-monitor.c:807 #10 0xf4ca5d in do_qmp_dispatch qapi/qmp-dispatch.c:119 #11 0xf4ce3c in qmp_dispatch qapi/qmp-dispatch.c:168 #12 0x4e2a5a in monitor_qmp_dispatch_one /root/qemu/monitor.c:4088 #13 0x4e2baf in monitor_qmp_bh_dispatcher /root/qemu/monitor.c:4146 #14 0xf67ad1 in aio_bh_poll util/async.c:118 #15 0xf724a3 in aio_dispatch util/aio-posix.c:436 #16 0xf67270 in aio_ctx_dispatch util/async.c:261 #17 0x7fc31cf8e999 in g_main_context_dispatch (/usr/lib64/libglib-2.0.s= o.0+0x49999) Direct leak of 64 byte(s) in 2 object(s) allocated from: #0 0x7fc321cb6560 in calloc (/usr/local/gcc-6-4/lib64/libasan.so.3+0xc7= 560) #1 0x7fc31cf944d6 in g_malloc0 (/usr/lib64/libglib-2.0.so.0+0x4f4d6) #2 0x4cda1f in qemu_init_vcpu /root/qemu/cpus.c:1997 #3 0x6aedbd in x86_cpu_realizefn /root/qemu/target/i386/cpu.c:4739 #4 0x8edfc8 in device_set_realized hw/core/qdev.c:826 #5 0xcff60c in property_set_bool qom/object.c:1928 #6 0xd09bd2 in object_property_set_qobject qom/qom-qobject.c:27 #7 0xd048e3 in object_property_set_bool qom/object.c:1188 #8 0x79ad83 in qdev_device_add /root/qemu/qdev-monitor.c:627 #9 0x79b50c in qmp_device_add /root/qemu/qdev-monitor.c:807 #10 0xf4ca5d in do_qmp_dispatch qapi/qmp-dispatch.c:119 #11 0xf4ce3c in qmp_dispatch qapi/qmp-dispatch.c:168 #12 0x4e2a5a in monitor_qmp_dispatch_one /root/qemu/monitor.c:4088 #13 0x4e2baf in monitor_qmp_bh_dispatcher /root/qemu/monitor.c:4146 #14 0xf67ad1 in aio_bh_poll util/async.c:118 #15 0xf724a3 in aio_dispatch util/aio-posix.c:436 #16 0xf67270 in aio_ctx_dispatch util/async.c:261 #17 0x7fc31cf8e999 in g_main_context_dispatch (/usr/lib64/libglib-2.0.s= o.0+0x49999) SUMMARY: AddressSanitizer: 8440 byte(s) leaked in 5 allocation(s). The relevant members in CPU Structure are freed to fix leak. Meanwhile, alt= hough the VMChangeStateEntry added in kvm_arch_init_vcpu does not be reportd by ASAN = since it still in vm_change_state_head, it's not longer used after hot-del, so free it, to= o. Signed-off-by: liujunjie Signed-off-by: linzhecheng --- accel/kvm/kvm-all.c | 1 + cpus.c | 6 ++++++ include/sysemu/kvm.h | 2 ++ target/arm/kvm.c | 4 ++++ target/i386/cpu.h | 2 ++ target/i386/kvm.c | 19 ++++++++++++++++++- 6 files changed, 33 insertions(+), 1 deletion(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index ffee68e..ff5e738 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -305,6 +305,7 @@ int kvm_destroy_vcpu(CPUState *cpu) vcpu->vcpu_id =3D kvm_arch_vcpu_id(cpu); vcpu->kvm_fd =3D cpu->kvm_fd; QLIST_INSERT_HEAD(&kvm_state->kvm_parked_vcpus, vcpu, node); + kvm_arch_destroy_vcpu(cpu); err: return ret; } diff --git a/cpus.c b/cpus.c index d1f1629..cbe28d6 100644 --- a/cpus.c +++ b/cpus.c @@ -1842,6 +1842,12 @@ void cpu_remove_sync(CPUState *cpu) qemu_mutex_unlock_iothread(); qemu_thread_join(cpu->thread); qemu_mutex_lock_iothread(); + g_free(cpu->thread); + cpu->thread =3D NULL; + g_free(cpu->halt_cond); + cpu->halt_cond =3D NULL; + g_free(cpu->cpu_ases); + cpu->cpu_ases =3D NULL; } =20 /* For temporary buffers for forming a name */ diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index 0b64b8e..f7db7db 100644 --- a/include/sysemu/kvm.h +++ b/include/sysemu/kvm.h @@ -372,6 +372,8 @@ int kvm_arch_init(MachineState *ms, KVMState *s); =20 int kvm_arch_init_vcpu(CPUState *cpu); =20 +void kvm_arch_destroy_vcpu(CPUState *cs); + bool kvm_vcpu_id_is_valid(int vcpu_id); =20 /* Returns VCPU ID to be used on KVM_CREATE_VCPU ioctl() */ diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 98f5006..603089a 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -172,6 +172,10 @@ int kvm_arch_init(MachineState *ms, KVMState *s) return 0; } =20 +void kvm_arch_destroy_vcpu(CPUState *cs) +{ +} + unsigned long kvm_arch_vcpu_id(CPUState *cpu) { return cpu->cpu_index; diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 6645046..d6b8137 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -32,6 +32,7 @@ #endif =20 #include "exec/cpu-defs.h" +typedef struct vm_change_state_entry VMChangeStateEntry; =20 /* The x86 has a strong memory model with some store-after-load re-orderin= g */ #define TCG_GUEST_DEFAULT_MO (TCG_MO_ALL & ~TCG_MO_ST_LD) @@ -1330,6 +1331,7 @@ typedef struct CPUX86State { uint64_t xss; =20 TPRAccess tpr_access_type; + VMChangeStateEntry *vmstate; } CPUX86State; =20 struct kvm_msrs; diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 44f7073..1ae5330 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -1041,7 +1041,7 @@ int kvm_arch_init_vcpu(CPUState *cs) } } =20 - qemu_add_vm_change_state_handler(cpu_update_state, env); + env->vmstate =3D qemu_add_vm_change_state_handler(cpu_update_state, en= v); =20 c =3D cpuid_find_entry(&cpuid_data.cpuid, 1, 0); if (c) { @@ -1115,6 +1115,23 @@ int kvm_arch_init_vcpu(CPUState *cs) return r; } =20 +void kvm_arch_destroy_vcpu(CPUState *cs) +{ + X86CPU *cpu =3D X86_CPU(cs); + CPUX86State *env =3D &cpu->env; + + if (has_xsave && env->kvm_xsave_buf) { + qemu_vfree(env->kvm_xsave_buf); + env->kvm_xsave_buf =3D NULL; + } + g_free(cpu->kvm_msr_buf); + cpu->kvm_msr_buf =3D NULL; + if (env->vmstate) { + qemu_del_vm_change_state_handler(env->vmstate); + env->vmstate =3D NULL; + } +} + void kvm_arch_reset_vcpu(X86CPU *cpu) { CPUX86State *env =3D &cpu->env; --=20 1.8.3.1