1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH v2 0/7] sdcard: cleanup the SD_SPEC version

Philippe Mathieu-Daudé posted 7 patches 5 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180607180641.874-1-f4bug@amsat.org
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
include/hw/sd/sd.h |  6 ++++++
hw/sd/sd.c         | 50 +++++++++++++++++++++++++++++-----------------
hw/sd/ssi-sd.c     |  2 ++
3 files changed, 40 insertions(+), 18 deletions(-)
[Qemu-devel] [PATCH v2 0/7] sdcard: cleanup the SD_SPEC version
Posted by Philippe Mathieu-Daudé 5 years, 10 months ago 
Since v2:
- heavy documentation improvements
- squashed previous 3+4 "add spec_version property default to v2" for atomicity
- SSI/SD patch downgraded to RFC
- added Alistair R-b tags

v1: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg00388.html

Hi,

This series adds a 'spec_version' property to the SD Card device,
to allow to limit some commands to specific spec version range
(some firmwares use this feature to detect which spec version the
card implements).

This [v2: does NOT] restore the SSI/SD support of the Stellaris LM3S6965EVB
board, which allow to stress the SD Card code with a nice integration test
(waiting for another series to get merged to add the Avocado test):

    $ qemu-system-arm -M lm3s6965evb -serial stdio \
      -kernel sd_card.bin -sd sdcard.img

    SD Card Example Program
    Type 'help' for help.

    /> ls
    Open
    listing

    ----A 2012/04/25 17:44        12  README.TXT

       1 File(s),        12 bytes total
       0 Dir(s),      61182K bytes free

    /> cat README.TXT
    Hello World

See:
http://lists.nongnu.org/archive/html/qemu-devel/2012-04/msg03790.html
http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg00353.html

Regards,

Phil.

[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/8:[----] [--] 'sdcard: Update the Configuration Register (SCR) to Spec Version 1.10'
002/8:[----] [--] 'sdcard: Allow commands valid in SPI mode'
003/8:[0017] [FC] 'sdcard: Add a 'spec_version' property'
004/8:[down] 'sdcard: Set Spec v2.00 as default'
005/8:[----] [--] 'hw/sd/ssi-sd: Force cards connected in SPI mode to use Spec v1.10'
006/8:[----] [--] 'sdcard: Disable SEND_IF_COND (CMD8) for Spec v1'
007/8:[----] [--] 'sdcard: Reflect when the Spec v3 is supported in the Config Register (SCR)'
008/8:[----] [--] 'sdcard: Disable CMD19/CMD23 for Spec v2'

Philippe Mathieu-Daudé (7):
  sdcard: Update the Configuration Register (SCR) to Spec Version 1.10
  sdcard: Allow commands valid in SPI mode
  sdcard: Add a 'spec_version' property, default to Spec v2.00
  sdcard: Disable SEND_IF_COND (CMD8) for Spec v1
  sdcard: Reflect when the Spec v3 is supported in the Config Register (SCR)
  sdcard: Disable CMD19/CMD23 for Spec v2
  hw/sd/ssi-sd: Force cards connected in SPI mode to use Spec v1.10

 include/hw/sd/sd.h |  6 ++++++
 hw/sd/sd.c         | 50 +++++++++++++++++++++++++++++-----------------
 hw/sd/ssi-sd.c     |  2 ++
 3 files changed, 40 insertions(+), 18 deletions(-)

-- 
2.17.1
Re: [Qemu-devel] [PATCH v2 0/7] sdcard: cleanup the SD_SPEC version
Posted by Philippe Mathieu-Daudé 5 years, 10 months ago 
On 06/07/2018 03:06 PM, Philippe Mathieu-Daudé wrote:
> Since v2:
> - heavy documentation improvements
> - squashed previous 3+4 "add spec_version property default to v2" for atomicity
> - SSI/SD patch downgraded to RFC
> - added Alistair R-b tags

Patches missing review: #1 and #4 (#6 being RFC waits for comments).
Re: [Qemu-devel] [PATCH v2 0/7] sdcard: cleanup the SD_SPEC version
Posted by Peter Maydell 5 years, 10 months ago 
On 7 June 2018 at 19:06, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Since v2:
> - heavy documentation improvements
> - squashed previous 3+4 "add spec_version property default to v2" for atomicity
> - SSI/SD patch downgraded to RFC
> - added Alistair R-b tags

> Philippe Mathieu-Daudé (7):
>   sdcard: Update the Configuration Register (SCR) to Spec Version 1.10
>   sdcard: Allow commands valid in SPI mode
>   sdcard: Add a 'spec_version' property, default to Spec v2.00
>   sdcard: Disable SEND_IF_COND (CMD8) for Spec v1
>   sdcard: Reflect when the Spec v3 is supported in the Config Register (SCR)
>   sdcard: Disable CMD19/CMD23 for Spec v2
>   hw/sd/ssi-sd: Force cards connected in SPI mode to use Spec v1.10

Hi; I've applied patches 1-6 to target-arm.next. 7 I had a
question about.

thanks
-- PMM
Re: [Qemu-devel] [Qemu-arm] [PATCH v2 0/7] sdcard: cleanup the SD_SPEC version
Posted by Philippe Mathieu-Daudé 5 years, 10 months ago 
On 06/08/2018 09:14 AM, Peter Maydell wrote:
> On 7 June 2018 at 19:06, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>> Since v2:
>> - heavy documentation improvements
>> - squashed previous 3+4 "add spec_version property default to v2" for atomicity
>> - SSI/SD patch downgraded to RFC
>> - added Alistair R-b tags
> 
>> Philippe Mathieu-Daudé (7):
>>   sdcard: Update the Configuration Register (SCR) to Spec Version 1.10
>>   sdcard: Allow commands valid in SPI mode
>>   sdcard: Add a 'spec_version' property, default to Spec v2.00
>>   sdcard: Disable SEND_IF_COND (CMD8) for Spec v1
>>   sdcard: Reflect when the Spec v3 is supported in the Config Register (SCR)
>>   sdcard: Disable CMD19/CMD23 for Spec v2
>>   hw/sd/ssi-sd: Force cards connected in SPI mode to use Spec v1.10
> 
> Hi; I've applied patches 1-6 to target-arm.next. 7 I had a
> question about.

Thanks!

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.