[Qemu-devel] [PATCH] MAINTAINERS: Adopt the Gumstix computers-on-module machines

Philippe Mathieu-Daudé posted 1 patch 5 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180606144706.29732-1-f4bug@amsat.org
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[Qemu-devel] [PATCH] MAINTAINERS: Adopt the Gumstix computers-on-module machines
Posted by Philippe Mathieu-Daudé 5 years, 10 months ago
These COMs are hard to find, and the companie dropped the support
few years ago.

Per the "Gumstix Product Changes, Known Issues, and EOL" pdf:

- Phasing out: PXA270-based Verdex product line
  September 2012

- Phasing out: PXA255-based Basix & Connex
  September 2009

However there are still booting SD card image availables, very
convenient to stress test the QEMU SD card implementation.
Therefore I volunteer to keep an eye on this file, while it
is useful for testing.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 41cd3736a9..1825deb762 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -491,9 +491,10 @@ F: include/hw/arm/digic.h
 F: hw/*/digic*
 
 Gumstix
+M: Philippe Mathieu-Daudé <f4bug@amsat.org>
 L: qemu-devel@nongnu.org
 L: qemu-arm@nongnu.org
-S: Orphan
+S: Odd Fixes
 F: hw/arm/gumstix.c
 
 i.MX31
-- 
2.17.1


Re: [Qemu-devel] [PATCH] MAINTAINERS: Adopt the Gumstix computers-on-module machines
Posted by Thomas Huth 5 years, 10 months ago
On 06.06.2018 16:47, Philippe Mathieu-Daudé wrote:
> These COMs are hard to find, and the companie dropped the support
> few years ago.
> 
> Per the "Gumstix Product Changes, Known Issues, and EOL" pdf:
> 
> - Phasing out: PXA270-based Verdex product line
>   September 2012
> 
> - Phasing out: PXA255-based Basix & Connex
>   September 2009
> 
> However there are still booting SD card image availables, very
> convenient to stress test the QEMU SD card implementation.
> Therefore I volunteer to keep an eye on this file, while it
> is useful for testing.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 41cd3736a9..1825deb762 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -491,9 +491,10 @@ F: include/hw/arm/digic.h
>  F: hw/*/digic*
>  
>  Gumstix
> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>  L: qemu-devel@nongnu.org
>  L: qemu-arm@nongnu.org
> -S: Orphan
> +S: Odd Fixes
>  F: hw/arm/gumstix.c

Great! So we can also remove the Gumstix entries from
https://wiki.qemu.org/Features/LegacyRemoval ?

 Thomas

Re: [Qemu-devel] [PATCH] MAINTAINERS: Adopt the Gumstix computers-on-module machines
Posted by Philippe Mathieu-Daudé 5 years, 10 months ago
On 06/06/2018 11:53 AM, Thomas Huth wrote:
> On 06.06.2018 16:47, Philippe Mathieu-Daudé wrote:
>> These COMs are hard to find, and the companie dropped the support

"company" :/

>> few years ago.
>>
>> Per the "Gumstix Product Changes, Known Issues, and EOL" pdf:
>>
>> - Phasing out: PXA270-based Verdex product line
>>   September 2012
>>
>> - Phasing out: PXA255-based Basix & Connex
>>   September 2009
>>
>> However there are still booting SD card image availables, very
>> convenient to stress test the QEMU SD card implementation.
>> Therefore I volunteer to keep an eye on this file, while it
>> is useful for testing.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  MAINTAINERS | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 41cd3736a9..1825deb762 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -491,9 +491,10 @@ F: include/hw/arm/digic.h
>>  F: hw/*/digic*
>>  
>>  Gumstix
>> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>  L: qemu-devel@nongnu.org
>>  L: qemu-arm@nongnu.org
>> -S: Orphan
>> +S: Odd Fixes
>>  F: hw/arm/gumstix.c
> 
> Great! So we can also remove the Gumstix entries from
> https://wiki.qemu.org/Features/LegacyRemoval ?

I'll remove these now, eventually adding a new Gumstix COMs
wiki entry when Avocados tests are merged, although reading
the tests should be enough.

Re: [Qemu-devel] [PATCH] MAINTAINERS: Adopt the Gumstix computers-on-module machines
Posted by Philippe Mathieu-Daudé 5 years, 10 months ago
Hi Peter,

On 06/06/2018 12:02 PM, Philippe Mathieu-Daudé wrote:
> On 06/06/2018 11:53 AM, Thomas Huth wrote:
>> On 06.06.2018 16:47, Philippe Mathieu-Daudé wrote:
>>> These COMs are hard to find, and the companie dropped the support
> 
> "company" :/
> 
>>> few years ago.
>>>
>>> Per the "Gumstix Product Changes, Known Issues, and EOL" pdf:
>>>
>>> - Phasing out: PXA270-based Verdex product line
>>>   September 2012
>>>
>>> - Phasing out: PXA255-based Basix & Connex
>>>   September 2009
>>>
>>> However there are still booting SD card image availables, very
>>> convenient to stress test the QEMU SD card implementation.
>>> Therefore I volunteer to keep an eye on this file, while it
>>> is useful for testing.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>>  MAINTAINERS | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 41cd3736a9..1825deb762 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -491,9 +491,10 @@ F: include/hw/arm/digic.h
>>>  F: hw/*/digic*
>>>  
>>>  Gumstix
>>> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>  L: qemu-devel@nongnu.org
>>>  L: qemu-arm@nongnu.org
>>> -S: Orphan
>>> +S: Odd Fixes
>>>  F: hw/arm/gumstix.c
>>
>> Great! So we can also remove the Gumstix entries from
>> https://wiki.qemu.org/Features/LegacyRemoval ?
> 
> I'll remove these now, eventually adding a new Gumstix COMs
> wiki entry when Avocados tests are merged, although reading
> the tests should be enough.

Do you agree with this patch? This is mostly to avoid removing these 2
boards in 2 releases from now. The datasheets are public so I can keep
an eye on them.
I already removed them from the "Future deprecated candidates" entry in
the Wiki.

Regards,

Phil.

Re: [Qemu-devel] [PATCH] MAINTAINERS: Adopt the Gumstix computers-on-module machines
Posted by Thomas Huth 5 years, 10 months ago
On 22.06.2018 15:30, Philippe Mathieu-Daudé wrote:
> Hi Peter,
> 
> On 06/06/2018 12:02 PM, Philippe Mathieu-Daudé wrote:
>> On 06/06/2018 11:53 AM, Thomas Huth wrote:
>>> On 06.06.2018 16:47, Philippe Mathieu-Daudé wrote:
>>>> These COMs are hard to find, and the companie dropped the support
>>
>> "company" :/
>>
>>>> few years ago.
>>>>
>>>> Per the "Gumstix Product Changes, Known Issues, and EOL" pdf:
>>>>
>>>> - Phasing out: PXA270-based Verdex product line
>>>>   September 2012
>>>>
>>>> - Phasing out: PXA255-based Basix & Connex
>>>>   September 2009
>>>>
>>>> However there are still booting SD card image availables, very
>>>> convenient to stress test the QEMU SD card implementation.
>>>> Therefore I volunteer to keep an eye on this file, while it
>>>> is useful for testing.
>>>>
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>>  MAINTAINERS | 3 ++-
>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 41cd3736a9..1825deb762 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -491,9 +491,10 @@ F: include/hw/arm/digic.h
>>>>  F: hw/*/digic*
>>>>  
>>>>  Gumstix
>>>> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>>  L: qemu-devel@nongnu.org
>>>>  L: qemu-arm@nongnu.org
>>>> -S: Orphan
>>>> +S: Odd Fixes
>>>>  F: hw/arm/gumstix.c
>>>
>>> Great! So we can also remove the Gumstix entries from
>>> https://wiki.qemu.org/Features/LegacyRemoval ?
>>
>> I'll remove these now, eventually adding a new Gumstix COMs
>> wiki entry when Avocados tests are merged, although reading
>> the tests should be enough.
> 
> Do you agree with this patch?

FWIW:

Reviewed-by: Thomas Huth <thuth@redhat.com>

> This is mostly to avoid removing these 2 boards in 2 releases from now.

As long as they are not listed in the "deprecation" chapter of
qemu-doc.texi, they are *not* officially marked as deprecated and thus
won't get removed in two releases.

> I already removed them from the "Future deprecated candidates" entry in
> the Wiki.

Ok, thanks!

 Thomas

Re: [Qemu-devel] [PATCH] MAINTAINERS: Adopt the Gumstix computers-on-module machines
Posted by Peter Maydell 5 years, 10 months ago
On 22 June 2018 at 14:30, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Hi Peter,
>
> On 06/06/2018 12:02 PM, Philippe Mathieu-Daudé wrote:
>> On 06/06/2018 11:53 AM, Thomas Huth wrote:
>>> On 06.06.2018 16:47, Philippe Mathieu-Daudé wrote:
>>>> These COMs are hard to find, and the companie dropped the support
>>
>> "company" :/
>>
>>>> few years ago.
>>>>
>>>> Per the "Gumstix Product Changes, Known Issues, and EOL" pdf:
>>>>
>>>> - Phasing out: PXA270-based Verdex product line
>>>>   September 2012
>>>>
>>>> - Phasing out: PXA255-based Basix & Connex
>>>>   September 2009
>>>>
>>>> However there are still booting SD card image availables, very
>>>> convenient to stress test the QEMU SD card implementation.
>>>> Therefore I volunteer to keep an eye on this file, while it
>>>> is useful for testing.
>>>>
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>>  MAINTAINERS | 3 ++-
>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 41cd3736a9..1825deb762 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -491,9 +491,10 @@ F: include/hw/arm/digic.h
>>>>  F: hw/*/digic*
>>>>
>>>>  Gumstix
>>>> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>>  L: qemu-devel@nongnu.org
>>>>  L: qemu-arm@nongnu.org
>>>> -S: Orphan
>>>> +S: Odd Fixes
>>>>  F: hw/arm/gumstix.c

> Do you agree with this patch? This is mostly to avoid removing these 2
> boards in 2 releases from now. The datasheets are public so I can keep
> an eye on them.
> I already removed them from the "Future deprecated candidates" entry in
> the Wiki.

As Thomas says, whether anybody's listed in MAINTAINERS is
orthogonal to whether we choose to deprecate and remove boards.
If you want to look after these, that's cool.

I've applied this patch to target-arm.next.

thanks
-- PMM