[v3] backup: Use copy offloading

[Qemu-devel] [PATCH v3 0/2] backup: Use copy offloading

Posted by Fam Zheng 5 years, 10 months ago

Based-on: <20180529055959.32002-1-famz@redhat.com>
([PATCH v7 00/10] qemu-img convert with copy offloading)

This enhances the backup job to make use of the copy offloading API. It
eliminates the necessity to use the bounce buffer as well as speeding up the
copy operation when the backend supports it.

v3: Don't forget coroutine_fn. [Stefan]
    Don't reset job->use_copy_range redundantly. [Stefan]

v2: Use helper functions. [Stefan]

Fam Zheng (2):
  block: Honour BDRV_REQ_NO_SERIALISING in copy range
  backup: Use copy offloading

 block/backup.c        | 150 ++++++++++++++++++++++++++++++------------
 block/io.c            |   6 +-
 block/trace-events    |   1 +
 include/block/block.h |   5 +-
 4 files changed, 117 insertions(+), 45 deletions(-)

-- 
2.17.0

Re: [Qemu-devel] [PATCH v3 0/2] backup: Use copy offloading

Posted by Stefan Hajnoczi 5 years, 10 months ago

On Tue, Jun 05, 2018 at 10:06:29PM +0800, Fam Zheng wrote:
> Based-on: <20180529055959.32002-1-famz@redhat.com>
> ([PATCH v7 00/10] qemu-img convert with copy offloading)
> 
> This enhances the backup job to make use of the copy offloading API. It
> eliminates the necessity to use the bounce buffer as well as speeding up the
> copy operation when the backend supports it.
> 
> v3: Don't forget coroutine_fn. [Stefan]
>     Don't reset job->use_copy_range redundantly. [Stefan]
> 
> v2: Use helper functions. [Stefan]
> 
> Fam Zheng (2):
>   block: Honour BDRV_REQ_NO_SERIALISING in copy range
>   backup: Use copy offloading
> 
>  block/backup.c        | 150 ++++++++++++++++++++++++++++++------------
>  block/io.c            |   6 +-
>  block/trace-events    |   1 +
>  include/block/block.h |   5 +-
>  4 files changed, 117 insertions(+), 45 deletions(-)
> 
> -- 
> 2.17.0
> 
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [Qemu-devel] [PATCH v3 0/2] backup: Use copy offloading

Posted by Fam Zheng 5 years, 9 months ago

Jeff: ping? Can we have this in 3.0?

On Tue, 06/05 22:06, Fam Zheng wrote:
> Based-on: <20180529055959.32002-1-famz@redhat.com>
> ([PATCH v7 00/10] qemu-img convert with copy offloading)
> 
> This enhances the backup job to make use of the copy offloading API. It
> eliminates the necessity to use the bounce buffer as well as speeding up the
> copy operation when the backend supports it.
> 
> v3: Don't forget coroutine_fn. [Stefan]
>     Don't reset job->use_copy_range redundantly. [Stefan]
> 
> v2: Use helper functions. [Stefan]
> 
> Fam Zheng (2):
>   block: Honour BDRV_REQ_NO_SERIALISING in copy range
>   backup: Use copy offloading
> 
>  block/backup.c        | 150 ++++++++++++++++++++++++++++++------------
>  block/io.c            |   6 +-
>  block/trace-events    |   1 +
>  include/block/block.h |   5 +-
>  4 files changed, 117 insertions(+), 45 deletions(-)
> 
> -- 
> 2.17.0
>

Re: [Qemu-devel] [PATCH v3 0/2] backup: Use copy offloading

Posted by Jeff Cody 5 years, 9 months ago

On Mon, Jul 02, 2018 at 05:04:20PM +0800, Fam Zheng wrote:
> Jeff: ping? Can we have this in 3.0?
>

Yes - can you rebase on current master?  I can resolve the conflicts myself
if not.

> On Tue, 06/05 22:06, Fam Zheng wrote:
> > Based-on: <20180529055959.32002-1-famz@redhat.com>
> > ([PATCH v7 00/10] qemu-img convert with copy offloading)
> > 
> > This enhances the backup job to make use of the copy offloading API. It
> > eliminates the necessity to use the bounce buffer as well as speeding up the
> > copy operation when the backend supports it.
> > 
> > v3: Don't forget coroutine_fn. [Stefan]
> >     Don't reset job->use_copy_range redundantly. [Stefan]
> > 
> > v2: Use helper functions. [Stefan]
> > 
> > Fam Zheng (2):
> >   block: Honour BDRV_REQ_NO_SERIALISING in copy range
> >   backup: Use copy offloading
> > 
> >  block/backup.c        | 150 ++++++++++++++++++++++++++++++------------
> >  block/io.c            |   6 +-
> >  block/trace-events    |   1 +
> >  include/block/block.h |   5 +-
> >  4 files changed, 117 insertions(+), 45 deletions(-)
> > 
> > -- 
> > 2.17.0
> >