From nobody Wed May 8 22:10:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1528125393060464.10754171344627; Mon, 4 Jun 2018 08:16:33 -0700 (PDT) Received: from localhost ([::1]:40292 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPrDg-0006gd-Ll for importer@patchew.org; Mon, 04 Jun 2018 11:16:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPrBr-0005gI-6D for qemu-devel@nongnu.org; Mon, 04 Jun 2018 11:14:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPrBp-0001eg-4d for qemu-devel@nongnu.org; Mon, 04 Jun 2018 11:14:35 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:35201) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPrBo-0001eS-Vo for qemu-devel@nongnu.org; Mon, 04 Jun 2018 11:14:33 -0400 Received: by mail-qk0-x242.google.com with SMTP id d130-v6so19787158qkc.2 for ; Mon, 04 Jun 2018 08:14:32 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id f9-v6sm18192856qtl.96.2018.06.04.08.14.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 08:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lRQ7XRz/IK1ThiJ+LRd5RXsB4JqOMjc+zouvRLcT92I=; b=JYRfeNPzmeJ/G9tIgW8W7H5Ua2ppuRCvgCjCVrzT65XNm6vNK5H56whPveg1kw5eqF 6hj3vFYrtiisc6FX6fGcutaex4kGy8/gOyyhfnmv/9QvL9d4eNBkc7YVFB8sH0BYVoUS FbKqpB4wHEo0fGLBTj+J1wC7Ayb9O0O7UvrohiMeGvdjlKru3AFugF+LXK/nUWXQrPzz 2VMIhAH3Ksp8md1U/gvSs4Alh9AE2Y4VqPgIskBwkiAVHQXFJpLRgfKCDEgM61uRWMpf pNcViz3OGR5X71uN3wNOUfoTzLhl7RdquEMkpYW23/W6Mh4YJQHgMaHtibE7Shz6asAZ qyIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=lRQ7XRz/IK1ThiJ+LRd5RXsB4JqOMjc+zouvRLcT92I=; b=FwENEsjMeCbwnCdY4adA1VCI4zsofowQpQ7mUcXk3exRK4tupBJC/bBPCeijvtXq8o XqeQZBsO98/4xg2xPPRkFqoqKwvF5gg+2870wMOxIAxBXPbFQSwu2iLqeO+jnnQ5N00t HOaRqipayV1Vw2HVGWzFD0aMjmGeprs0BX0M44IOxWyc1nq+IdPzM3WEb55j8fMHosef UMwM09CZAjcIjqt+EnsNpslZnjOBgOLrDxaW4N1mib4ZpQQCwSyEHg9MuJ4LRss0H1Qn ZL1FEUbPzHq1XD9+HM0xvRhmukgc4zutq8FYtT33uMNqTuouDrYxf2++A5pnN6WAIyaJ VKBQ== X-Gm-Message-State: APt69E0F2RvEOASsH+UN2tBErbuf0lb2iBzC1AzJWUToUssaADJuBFWF BpGkSomQkdae4t/5PnuFhoU= X-Google-Smtp-Source: ADUXVKKWJ8WzWKpkVgcz/6VVS11I6j2RmRcuQJ2R+Ih+sdaAPzzvHjfK2XJS8VK6sTfuRy3cYP1IiA== X-Received: by 2002:a37:6f01:: with SMTP id k1-v6mr19294328qkc.140.1528125272527; Mon, 04 Jun 2018 08:14:32 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Gerd Hoffmann Date: Mon, 4 Jun 2018 12:14:19 -0300 Message-Id: <20180604151421.23385-2-f4bug@amsat.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180604151421.23385-1-f4bug@amsat.org> References: <20180604151421.23385-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH v2 1/3] usb: correctly handle Zero Length Packets X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 USB Specification Revision 2.0, =C2=A75.5.3: The Data stage of a control transfer from an endpoint to the host is comp= lete when the endpoint does one of the following: =E2=80=A2 Has transferred exactly the amount of data specified during the= Setup stage =E2=80=A2 Transfers a packet with a payload size less than wMaxPacketSize= or transfers a zero-length packet" hw/usb/redirect.c:802:9: warning: Declared variable-length array (VLA) has = zero size uint8_t buf[size]; ^~~~~~~~~~~ ~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/redirect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 65a9196c1a..58e8f7f5bd 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -795,7 +795,7 @@ static void usbredir_handle_bulk_data(USBRedirDevice *d= ev, USBPacket *p, usbredirparser_peer_has_cap(dev->parser, usb_redir_cap_32bits_bulk_length)); =20 - if (ep & USB_DIR_IN) { + if (ep & USB_DIR_IN || size =3D=3D 0) { usbredirparser_send_bulk_packet(dev->parser, p->id, &bulk_packet, NULL, 0); } else { --=20 2.17.1 From nobody Wed May 8 22:10:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1528125402826178.36425388690327; Mon, 4 Jun 2018 08:16:42 -0700 (PDT) Received: from localhost ([::1]:40293 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPrDi-0006iX-8z for importer@patchew.org; Mon, 04 Jun 2018 11:16:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPrBr-0005gK-RM for qemu-devel@nongnu.org; Mon, 04 Jun 2018 11:14:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPrBq-0001g1-Vw for qemu-devel@nongnu.org; Mon, 04 Jun 2018 11:14:35 -0400 Received: from mail-qk0-x232.google.com ([2607:f8b0:400d:c09::232]:39193) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPrBq-0001fJ-Rk for qemu-devel@nongnu.org; Mon, 04 Jun 2018 11:14:34 -0400 Received: by mail-qk0-x232.google.com with SMTP id g14-v6so12898759qkm.6 for ; Mon, 04 Jun 2018 08:14:34 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id f9-v6sm18192856qtl.96.2018.06.04.08.14.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 08:14:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nDt3cA8K7cKSYmoKiitoGFHjMSdxoz2jn9n4cbinW7s=; b=XMBBgIf9dbSkO+4lOLUP45Bs361FXKqMIEvYBWxAR1WLMvSzA/aMUmW8xsD5UuJxRK k6JI+Wz0ByNI9UMfQdGhakcO/Za/SqX4ftOBExy/174TKtKGnt/BXiuWq9I/iuWQTl+M umeNJ7lw7AqKZ07Qf0mpeTDmUwJF9mS1Tn9hKCXCtLdGMzJjhaB0OG9a9UySZ5GlRWH6 Xe6LrVbLEPhOnS/Iu3OQPpkAvAaxGnhvjRnQtqikUgNWk8hfFvFjzV2pe1G3nBDiJHyQ utnQjvdxX+X7sw9b0Omt8+MEm+j3SgNP2qqbTQIFccJ0IIhhUo2IPMSEDuMnz9Fxz7je 4htA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=nDt3cA8K7cKSYmoKiitoGFHjMSdxoz2jn9n4cbinW7s=; b=FrhETxUpiUlMpRC4ymEja8Dz+pFV5rgI9DNtcv4SMtJEwEpuVO5vQuLTy9yoOWJxyJ UNR8Yi2YG99XMnNIr/eB9SGk1vSzYX6q1pSLwUQTN7SxaHBUZkn3Y37jeL0xsVY9pJaY qYOuv6tL1Ybxcu+KGarSqGW0Eo191cOQBxyEHztYRR0+HB2mFjjrmsJSfvTX3FSmHJmv JgaolY2IosBZgjJ/7RP7DJz+pDA4qYYHQZhpn0madjsvlUyhI47jXfwOgHJGIIi8GIRf TO/PDZVvfuAh2lzYhn+fGaJiD6VSOXSwrNTkmVp8BTkY7DFpyXqyzMC5//hpPMzOKMhS FwcA== X-Gm-Message-State: APt69E3Z/jly4vv+zdAfoe1WLsPijsy7lGiTvAbF9zEGDn421TZ+CTiZ 6ODASl1lsI5NEIhl8tsrLPY= X-Google-Smtp-Source: ADUXVKIkwYosEQkY7x5XLH6E/xj+ZvQD6LUdqlD3ScAD1R1R3Dn5dPgSVXyMDlFQjcJRL0ZzwxQH/g== X-Received: by 2002:a37:4249:: with SMTP id p70-v6mr13179823qka.297.1528125274386; Mon, 04 Jun 2018 08:14:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Gerd Hoffmann Date: Mon, 4 Jun 2018 12:14:20 -0300 Message-Id: <20180604151421.23385-3-f4bug@amsat.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180604151421.23385-1-f4bug@amsat.org> References: <20180604151421.23385-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::232 Subject: [Qemu-devel] [PATCH v2 2/3] usb/dev-mtp: Fix use of uninitialized values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 This fixes: hw/usb/dev-mtp.c:971:5: warning: 4th function call argument is an uniniti= alized value trace_usb_mtp_op_get_partial_object(s->dev.addr, o->handle, o->path, c->argv[1], c->argv[2]); ^~~~~~~~~~ and: hw/usb/dev-mtp.c:981:12: warning: Assigned value is garbage or undefined offset =3D c->argv[1]; ^ ~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/dev-mtp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 560c61c7c1..b0ab6a7912 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1017,12 +1017,16 @@ static MTPData *usb_mtp_get_object(MTPState *s, MTP= Control *c, static MTPData *usb_mtp_get_partial_object(MTPState *s, MTPControl *c, MTPObject *o) { - MTPData *d =3D usb_mtp_data_alloc(c); + MTPData *d; off_t offset; =20 + if (c->argc <=3D 2) { + return NULL; + } trace_usb_mtp_op_get_partial_object(s->dev.addr, o->handle, o->path, c->argv[1], c->argv[2]); =20 + d =3D usb_mtp_data_alloc(c); d->fd =3D open(o->path, O_RDONLY); if (d->fd =3D=3D -1) { usb_mtp_data_free(d); --=20 2.17.1 From nobody Wed May 8 22:10:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1528125573137135.57008037282856; Mon, 4 Jun 2018 08:19:33 -0700 (PDT) Received: from localhost ([::1]:40308 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPrGb-0000dU-GC for importer@patchew.org; Mon, 04 Jun 2018 11:19:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPrBu-0005hG-0h for qemu-devel@nongnu.org; Mon, 04 Jun 2018 11:14:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPrBt-0001i6-3O for qemu-devel@nongnu.org; Mon, 04 Jun 2018 11:14:37 -0400 Received: from mail-qk0-x22d.google.com ([2607:f8b0:400d:c09::22d]:37784) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPrBs-0001hl-Tt for qemu-devel@nongnu.org; Mon, 04 Jun 2018 11:14:37 -0400 Received: by mail-qk0-x22d.google.com with SMTP id j12-v6so21826495qkk.4 for ; Mon, 04 Jun 2018 08:14:36 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id f9-v6sm18192856qtl.96.2018.06.04.08.14.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 08:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8eUI5ebWyS3H7r3vNI7fVNgr9t4DnFcGkf4LvrH31JY=; b=DifGChPDFzUWRi08LT4HZqTJxVDDjeiq77XsB2jgZ6i+0HjwS4WwUDX2DDCIHMxt1G 19qwicUekx9yB2YuJbNzGKQ0ChijqQ6I6fQKEbD+gp90caKlTN1JbqM3xmJnIRDaAjzG blP3Nvi5PWNd6ixdUPPvjNpHB0m1g+9xeYi6pREUi96jGpHKXeEIQNPLzBCnK/rk+9f4 SwBNtJrU80SE34rxm9VeGfRyKZBNvTd3EOUBX6omQO+ezCmSnBwfx48/BIfSeBuH9egJ 3eYA+57NWIArFv49frr0Bl9brbYaR1zAquf3jmuQ0W0fAsDKUFCvSFW2h/c2yAIUU0pT 51WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=8eUI5ebWyS3H7r3vNI7fVNgr9t4DnFcGkf4LvrH31JY=; b=dulJw+skJSQD/ybA/0qUlBqiRYPHOA2lBdgjaGEXBGwXlEIZGX7ifS+ZmKzmBHNRGa G0+Jwl+PQAtSXZVlfeGUWUVnIe8tp3g4IVfTWIW3eDpFdqjWxGfo/SEI0HNdhsx1qDAE jy0Ro1Rawl4LHLpZzLR7c2NwjI2U4eZXDiurqiKgqJ2Uu23llOMh1mkwQTB9VSbds9KP Sca5JFAJYUmXXvgCG+3pREnuuV/Oq5fjU3p/jeD3fpgdVQB3iLTf60jiGiMksiJnDHg2 HefvpvJuBf/JIf3JO8dEuQ1a9Medh4bbDAIdHuVOSvgZxXfSuNPsEwzaIpLOVzs+SCMy gA0Q== X-Gm-Message-State: APt69E2ovGTt6sKzUfEoz00sJ4QqQIilqdb3QD/yi9F/oRa5Wk+2cIOw tiJddKZQ3Sbu5lA79ahWcGDcNLic X-Google-Smtp-Source: ADUXVKLMrlcnfwJkHZZmDWdDZUsdU/lA25wIXWyyWk0Mx/nvfgqXV5Y2Pi1T5PMoxE/B/aS8DGNXiA== X-Received: by 2002:ae9:ef52:: with SMTP id d79-v6mr19849435qkg.336.1528125276483; Mon, 04 Jun 2018 08:14:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Gerd Hoffmann Date: Mon, 4 Jun 2018 12:14:21 -0300 Message-Id: <20180604151421.23385-4-f4bug@amsat.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180604151421.23385-1-f4bug@amsat.org> References: <20180604151421.23385-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22d Subject: [Qemu-devel] [PATCH v2 3/3] usb/dev-mtp: Fix use of uninitialized values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 This fixes: hw/usb/dev-mtp.c:1212:13: warning: 2nd function call argument is an unini= tialized value o =3D usb_mtp_object_lookup(s, c->argv[0]); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Suggested-by: Gerd Hoffmann Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/dev-mtp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index b0ab6a7912..dd96c91cf9 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1281,6 +1281,7 @@ static void usb_mtp_command(MTPState *s, MTPControl *= c) MTPData *data_in =3D NULL; MTPObject *o =3D NULL; uint32_t nres =3D 0, res0 =3D 0; + int i; =20 /* sanity checks */ if (c->code >=3D CMD_CLOSE_SESSION && s->session =3D=3D 0) { @@ -1289,6 +1290,10 @@ static void usb_mtp_command(MTPState *s, MTPControl = *c) return; } =20 + for (i =3D c->argc; i < ARRAY_SIZE(c->argv); i++) { + c->argv[i] =3D 0; + } + /* process commands */ switch (c->code) { case CMD_GET_DEVICE_INFO: --=20 2.17.1