ccid-card-passthru: fix regression in realize()

[Qemu-devel] [PATCH] ccid-card-passthru: fix regression in realize()

Posted by Marc-André Lureau 5 years, 11 months ago

Since cc847bfd16d894fd8c1a2ce25f31772f6cdbbc74, CCID card-passthru
fails to intialize, because it changed a debug line to an error,
probably by mistake. Change it back to a DPRINTF debug.

(solves Boxes creating VM with smartcard passthru failing to start)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/usb/ccid-card-passthru.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c
index 7684db0cb3..25fb19b0d7 100644
--- a/hw/usb/ccid-card-passthru.c
+++ b/hw/usb/ccid-card-passthru.c
@@ -345,7 +345,7 @@ static void passthru_realize(CCIDCardState *base, Error **errp)
     card->vscard_in_pos = 0;
     card->vscard_in_hdr = 0;
     if (qemu_chr_fe_backend_connected(&card->cs)) {
-        error_setg(errp, "ccid-card-passthru: initing chardev");
+        DPRINTF(card, D_INFO, "ccid-card-passthru: initing chardev");
         qemu_chr_fe_set_handlers(&card->cs,
             ccid_card_vscard_can_read,
             ccid_card_vscard_read,
-- 
2.17.0.253.g3dd125b46d

Re: [Qemu-devel] [PATCH] ccid-card-passthru: fix regression in realize()

Posted by Philippe Mathieu-Daudé 5 years, 11 months ago

On 05/15/2018 12:30 PM, Marc-André Lureau wrote:
> Since cc847bfd16d894fd8c1a2ce25f31772f6cdbbc74, CCID card-passthru
> fails to intialize, because it changed a debug line to an error,
> probably by mistake. Change it back to a DPRINTF debug.

Oops.

> (solves Boxes creating VM with smartcard passthru failing to start)
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  hw/usb/ccid-card-passthru.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c
> index 7684db0cb3..25fb19b0d7 100644
> --- a/hw/usb/ccid-card-passthru.c
> +++ b/hw/usb/ccid-card-passthru.c
> @@ -345,7 +345,7 @@ static void passthru_realize(CCIDCardState *base, Error **errp)
>      card->vscard_in_pos = 0;
>      card->vscard_in_hdr = 0;
>      if (qemu_chr_fe_backend_connected(&card->cs)) {
> -        error_setg(errp, "ccid-card-passthru: initing chardev");
> +        DPRINTF(card, D_INFO, "ccid-card-passthru: initing chardev");
>          qemu_chr_fe_set_handlers(&card->cs,
>              ccid_card_vscard_can_read,
>              ccid_card_vscard_read,
>

Re: [Qemu-devel] [PATCH] ccid-card-passthru: fix regression in realize()

Posted by Gerd Hoffmann 5 years, 11 months ago

On Tue, May 15, 2018 at 05:30:39PM +0200, Marc-André Lureau wrote:
> Since cc847bfd16d894fd8c1a2ce25f31772f6cdbbc74, CCID card-passthru
> fails to intialize, because it changed a debug line to an error,
> probably by mistake. Change it back to a DPRINTF debug.
> 
> (solves Boxes creating VM with smartcard passthru failing to start)

Added to usb queue.

thanks,
  Gerd