From nobody Sat May 4 16:40:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524487141787957.8574794632565; Mon, 23 Apr 2018 05:39:01 -0700 (PDT) Received: from localhost ([::1]:43528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAak9-0005jE-Ue for importer@patchew.org; Mon, 23 Apr 2018 08:38:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAae2-0001U5-N1 for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAadz-00087a-1F for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:34 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:43148) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fAady-000876-OW for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:30 -0400 Received: by mail-lf0-x242.google.com with SMTP id v207-v6so14640280lfa.10 for ; Mon, 23 Apr 2018 05:32:30 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id m20-v6sm2773477lfc.23.2018.04.23.05.32.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 05:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=l21MLGkVtLyMAxMPpuhsntqTc+SRKmPSKGjlw5P0HBA=; b=kzQdIhDRUdmH/l9veyOgst2160L8dVNXu/icWZnWhsqwXSGyX6L31HPnuRoXVqhPyj J9kv5vV+rWNzyvYdRB+qKJUfIWtbL6C138Xf32RHwsWzfgWTSCCZaCvuR+aIRM8Q6g3b eDR1738SRBBT8Tfky8WIvx4+CkOpGEVcORRub7uaLNS23GyAuuqiwC7kdYSVRcwnVZYT bBSRECQ8SgBDDHktFdek1ZicpMqq4a7/sk5x/xL1V2wPKaOAJCtSFPdUvWTLPfab5ACv 387//izj6d55rRPuwlxCn97IPnSHAqVAskwM7MtkeFHEdu62XC5cEq91AWQG30M583Cr TjiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=l21MLGkVtLyMAxMPpuhsntqTc+SRKmPSKGjlw5P0HBA=; b=QHD9dTPKnhOInFDu1vbTX3RE+3oTavRclF22tMEA3rLMeQ0sY3DDYCoNyAyYs2kYWO ZQOqzj4/mEJdjXpvgPso901ee9yccWCIQVVKddYUMvdi1b+yq9BoFj7ZGi4DTqefIidZ SaNbsKqQ7hDZhsTE8ikZW4fRiGya7veRSH4TfZmcIMYxX/LDcdVlXe3y0MpHAOkVc3Zn eJhmUyfuO2tg8u/tGBUNuKqvW+IiwV1gGLqR/PDifzlPYEZI/MyJ/47ksKnfYmvhFg+r nMvjWQlI6qhzbFTQHNjD14jvutb6FneorAov+RcZW9hShbMScYLDoaUzOpzjmXuB8wMq UH5Q== X-Gm-Message-State: ALQs6tCHtGA7MUZsio7okurCAp55jY3ICvgxn8pLO54PSML4RSRWMuh8 znf3gUXzuKCjEaVBuqWgOYkLTw== X-Google-Smtp-Source: AB8JxZp5fN2HTnab5RbSRPOdcitUdLs0Zr/dePG987R2ZHWoT6FYZS75BNpX1wmIOsj/b9S426XZ2g== X-Received: by 10.46.125.26 with SMTP id y26mr4709591ljc.135.1524486749131; Mon, 23 Apr 2018 05:32:29 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Mon, 23 Apr 2018 14:32:21 +0200 Message-Id: <20180423123225.30503-2-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180423123225.30503-1-edgar.iglesias@gmail.com> References: <20180423123225.30503-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::242 Subject: [Qemu-devel] [PATCH v2 1/5] target-microblaze: Respect MSR.PVR as read-only X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com, alistair@alistair23.me, richard.henderson@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Respect MSR.PVR as read-only. We were wrongly overwriting the PVR bit. Signed-off-by: Edgar E. Iglesias Reviewed-by: Richard Henderson --- target/microblaze/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 7628b0e25b..f739751930 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -424,7 +424,7 @@ static inline void msr_write(DisasContext *dc, TCGv v) /* PVR bit is not writable. */ tcg_gen_andi_tl(t, v, ~MSR_PVR); tcg_gen_andi_tl(cpu_SR[SR_MSR], cpu_SR[SR_MSR], MSR_PVR); - tcg_gen_or_tl(cpu_SR[SR_MSR], cpu_SR[SR_MSR], v); + tcg_gen_or_tl(cpu_SR[SR_MSR], cpu_SR[SR_MSR], t); tcg_temp_free(t); } =20 --=20 2.14.1 From nobody Sat May 4 16:40:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524487028056898.2226983865828; Mon, 23 Apr 2018 05:37:08 -0700 (PDT) Received: from localhost ([::1]:43360 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAaiQ-0004Tu-OK for importer@patchew.org; Mon, 23 Apr 2018 08:37:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAae2-0001U4-N0 for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAae0-00088B-EP for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:34 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:34465) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fAae0-00087j-6D for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:32 -0400 Received: by mail-lf0-x241.google.com with SMTP id m13-v6so497170lfc.1 for ; Mon, 23 Apr 2018 05:32:32 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id l22sm2299438lja.62.2018.04.23.05.32.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 05:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GZGHsOwVq9oc9/+CFN5JjltUJJyb2HuvCfia7oGRNgI=; b=NHDu47riwe/uFT4B9/PxJ6KmNTVE0NYjlB1ZjU/Oj5abkmM6O41kzaNLKmybsiBu3x Te3gUuiEtYwFcGrYQ4mY/+9/O6NV1gu6vXBx/CwH15Vt1HOsKEYTuX+e62TPmQW3L/kH UtibX5lLYOsYWT44Ql9iu5aBXfCuoi+yIZ1Vuo3kU2Uk93uMivP/MeMYmr1Xu49f47MX WutXr7lOD/5N9PeFnBm7gow4nLX7Lte1DJbs9cqAP1ladLAKN01YUl8W0OXm9xHBvNIA 16qKijNTfPuuRJGmq/eOaPQODoViQ+zRm0NkNjkbhu6aAttk6Cl1cQ02ESi8ldeuK5e9 +cFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GZGHsOwVq9oc9/+CFN5JjltUJJyb2HuvCfia7oGRNgI=; b=h0UEvOkD6k5SgqlwgJA8VdlINVbedrdwyXDBaJJRq9REk41Oj4KmQU9uBsKTnHnuqb HAd0IbBTEwdg7vUYqZk5CbM3eDbhaXMuI7GFO/THOMzAZ5RFQf3uTdwABJPmZprU9wmm hTFuqKbLjaqx1H1VIlhoWYzNMgzqJDh77pCHv0JdJW3HyTSI2dgScFLGUHvp6yvkPzCS rrCGL2WCsCfRvwVbtaJNVkDBMCoGHJ2n+CM25qRJ31aL75gHSmtgKcd4CeK6uiQWolx8 BdYVlZnFD/FbN4oj0lvZghqwAxrMsWM2uZTen6+WedWrkFNY6o7e5zo0yro6n+NtOhYx Jc0Q== X-Gm-Message-State: ALQs6tDEGyNqP2VKQqF5RuPG6tYqU9kRx+egElUhmhagFrTRWg7Xesz3 HraKGjZletmLBXl14ZodPNhdjA== X-Google-Smtp-Source: AIpwx48WisjJMuyf/J7soph38vbql4TbHGjhJirGA8peMHpqurwBV/HKg+YRndbig0xvuW7i4xBJmA== X-Received: by 10.46.155.202 with SMTP id w10mr13547992ljj.76.1524486750712; Mon, 23 Apr 2018 05:32:30 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Mon, 23 Apr 2018 14:32:22 +0200 Message-Id: <20180423123225.30503-3-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180423123225.30503-1-edgar.iglesias@gmail.com> References: <20180423123225.30503-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::241 Subject: [Qemu-devel] [PATCH v2 2/5] target-microblaze: Fix trap checks for FPU insns X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com, alistair@alistair23.me, richard.henderson@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Fix trap checks for FPU insns when extended FPU insns are enabled. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias Reviewed-by: Richard Henderson --- target/microblaze/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index f739751930..ec12fed49d 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -1412,7 +1412,7 @@ static void dec_fpu(DisasContext *dc) =20 if ((dc->tb_flags & MSR_EE_FLAG) && (dc->cpu->env.pvr.regs[2] & PVR2_ILL_OPCODE_EXC_MASK) - && (dc->cpu->cfg.use_fpu !=3D 1)) { + && !dc->cpu->cfg.use_fpu) { tcg_gen_movi_tl(cpu_SR[SR_ESR], ESR_EC_ILLEGAL_OP); t_gen_raise_exception(dc, EXCP_HW_EXCP); return; --=20 2.14.1 From nobody Sat May 4 16:40:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524487018056756.3909892621801; Mon, 23 Apr 2018 05:36:58 -0700 (PDT) Received: from localhost ([::1]:43355 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAaiD-0004Kz-2l for importer@patchew.org; Mon, 23 Apr 2018 08:36:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAae2-0001U7-N6 for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAae1-00088t-T0 for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:34 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:37437) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fAae1-00088Y-Kp for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:33 -0400 Received: by mail-lf0-x241.google.com with SMTP id b23-v6so14717956lfg.4 for ; Mon, 23 Apr 2018 05:32:33 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id x22sm2267558lji.27.2018.04.23.05.32.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 05:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZCuY4k3h7/iu4nZ8hSohnET1CvU6wF41pAlhlO11ors=; b=gHvjDUt8aT7EcbFIjuYVn6vTJyPWZ9C+frbsjvcTNwWGsGvjAbeJ1UpD/fX9usu/5q iEKMkfeC/GAVJnnYvSErlj9r0JRql+Oz2qoInwaO+Cj3pIlToiBkBj0lK6tn8nlqxD0s SBz1iB59YOnBvEEJmUFUzshy78TCl+My4oVXDSzqE9c+dyT7BUGe7EEcp6aGBxJTUaab ubNsvY4vV85F/jeRlppE6xnNuJ6gQMf+tvZOLtr7mQabWtHle7V1LvvQ2+1TOjX2k2pJ 7kpQT0b9aXRm/4/nsduHjo4sKxQp6GkwFK48elLq0zq63QKLbRqFboLwZ7WhM0v5Qe2v TjJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZCuY4k3h7/iu4nZ8hSohnET1CvU6wF41pAlhlO11ors=; b=h82ycuUhObT9xtMOClFs1C4X31GBeCVO4oqWSJ+LvGVmQZtxeBIFX207QlIqVuwamg IGPpr/yXh2GK1oUNb89gN3Waufemi+viH/KbhFovuaNMLJbTlsPWpZbKQcsu/KUj70Wa tQRAbzwYCFoQPBn/mK63s55sNc7mGDaVhGWD/8to4cYaawbSiUhRmo1ASLHzvETNOybt QfXHCX6H3RX0tqm6ZTjUXIfuRsfrvgRs6id3/UGF3I/KDdgyL0uOV9RTe+AzO1ZtLd2e FHazOupEO5cl/Wz54tQhP/eG+AK9BrfcTibSOF24ENI8PpYWXcsYtZb5NtWx/JycgrAI EXnw== X-Gm-Message-State: ALQs6tDsFEUfmhmLiG6D9TstZKh7ELMrZOUVKHlHtRJaK7ExtrMRi1FQ C9jl3/KlLbU/PhjL2dfKXAn2Rw== X-Google-Smtp-Source: AB8JxZqvfGT9bfBi7yOu4Gi3387j4aIA66dqBIndmO64N1/aRAc8Ws1ttw07UyAPIQKbhhlQ6nKjmw== X-Received: by 2002:a19:8f06:: with SMTP id r6-v6mr9321477lfd.56.1524486752124; Mon, 23 Apr 2018 05:32:32 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Mon, 23 Apr 2018 14:32:23 +0200 Message-Id: <20180423123225.30503-4-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180423123225.30503-1-edgar.iglesias@gmail.com> References: <20180423123225.30503-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::241 Subject: [Qemu-devel] [PATCH v2 3/5] target-microblaze: Don't clobber the IMM reg for ld/st reversed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com, alistair@alistair23.me, richard.henderson@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Do not clobber the IMM register on reversed load/stores. Signed-off-by: Edgar E. Iglesias Reviewed-by: Richard Henderson --- target/microblaze/translate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index ec12fed49d..100883e2cc 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -952,7 +952,6 @@ static void dec_load(DisasContext *dc) tcg_gen_sub_tl(low, tcg_const_tl(3), low); tcg_gen_andi_tl(t, t, ~3); tcg_gen_or_tl(t, t, low); - tcg_gen_mov_tl(env_imm, t); tcg_temp_free(low); break; } @@ -1104,7 +1103,6 @@ static void dec_store(DisasContext *dc) tcg_gen_sub_tl(low, tcg_const_tl(3), low); tcg_gen_andi_tl(t, t, ~3); tcg_gen_or_tl(t, t, low); - tcg_gen_mov_tl(env_imm, t); tcg_temp_free(low); break; } --=20 2.14.1 From nobody Sat May 4 16:40:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524487322206310.0441261584057; Mon, 23 Apr 2018 05:42:02 -0700 (PDT) Received: from localhost ([::1]:43706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAan8-0007c9-60 for importer@patchew.org; Mon, 23 Apr 2018 08:41:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAae4-0001Uf-Rc for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAae3-0008A8-Mm for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:36 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:35716) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fAae3-00089M-Ey for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:35 -0400 Received: by mail-lf0-x244.google.com with SMTP id r125-v6so14700697lfe.2 for ; Mon, 23 Apr 2018 05:32:35 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id d127-v6sm2801889lfe.64.2018.04.23.05.32.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 05:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=g5+hLSB7T6Qdh89m4XIC2iBR45C3ZEBkN0qwtxkgXbo=; b=SnV7L8qv9amvPyvH0q40ux89UnZTnsczUjX3ZIecD0vHelV7tUFu7twzTWCaXrSg98 PkKQJAZDsL5XLimjIO4299YMg58OefuScoXvwtMRlqXQlgcZU/FpFnB29Gcg0cktcBct tyT+RIMfAHduWe/dFmwtxwB+jF8HrtzA2llquyyQHHMqPxOu6XK4zRdYGXPzIuSQguPN kpiLlo0h7lTTG2OEmA/xgso8EU5ErdeFtEz3QEp9CWmSuCTjNsme3qzmhMexAOp8TtFc NWeqWh6v23WAEljBkokurTAaY/4t+qCMnvmtoqiV5kxhIhP72vBXIbkNTDjixFOT6zrr xBmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=g5+hLSB7T6Qdh89m4XIC2iBR45C3ZEBkN0qwtxkgXbo=; b=QI4gywOr/obdcsd5O+9mSzKyZM1e3pjRe+zIjGLIAbp7M86D9VXhr5JiAesISCgifl JU8eutTtz+tBwhuldZNx/4dheMXABJrRil9YqKJOVrmyrvMQqNnmJloyT351wCADLZ/r fc36ndlqRIlP0dUZqKcKEHncJQnJBfFI9VXq5Foeegk0H6s8xVedx+mjHUL6zOQ2k7Jq wtZObfZ0VxXuAeTsk1DMP+nAfuwQTudECT5dzaBTKkhSRbUpgcredJVh4IX0Pa9pmpNR 0idsmlsREmIDclg+oCCQ3me8RNrqchaZsttMkQI65HubJC4PMvlSaoUfwA2OEZ2c9bUm +Dnw== X-Gm-Message-State: ALQs6tAJ22C6MvVFKLgo0DtYuHVFMPXR/VweeXFP9nwEivzqT49Z0m57 G7XmoVjcS/YoeQixEqqedTvr+w== X-Google-Smtp-Source: AB8JxZpeQdP0xx0V8RJbvpluZBgl6NxJRqWze+4n3ZzNwtCOpUURWoS81OtTHjUU/7Z/oM4146r4Kg== X-Received: by 2002:a19:740a:: with SMTP id v10-v6mr322924lfe.59.1524486753886; Mon, 23 Apr 2018 05:32:33 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Mon, 23 Apr 2018 14:32:24 +0200 Message-Id: <20180423123225.30503-5-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180423123225.30503-1-edgar.iglesias@gmail.com> References: <20180423123225.30503-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::244 Subject: [Qemu-devel] [PATCH v2 4/5] target-microblaze: mmu: Make TLBSX write-only X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com, alistair@alistair23.me, richard.henderson@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Make TLBSX write-only and guest-error log reads from it. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias Reviewed-by: Richard Henderson --- target/microblaze/mmu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu.c index a0f06758f8..8391811900 100644 --- a/target/microblaze/mmu.c +++ b/target/microblaze/mmu.c @@ -182,7 +182,7 @@ done: uint32_t mmu_read(CPUMBState *env, uint32_t rn) { unsigned int i; - uint32_t r; + uint32_t r =3D 0; =20 if (env->mmu.c_mmu < 2 || !env->mmu.c_mmu_tlb_access) { qemu_log_mask(LOG_GUEST_ERROR, "MMU access on MMU-less system\n"); @@ -211,6 +211,9 @@ uint32_t mmu_read(CPUMBState *env, uint32_t rn) } r =3D env->mmu.regs[rn]; break; + case MMU_R_TLBSX: + qemu_log_mask(LOG_GUEST_ERROR, "TLBSX is write-only.\n"); + break; default: r =3D env->mmu.regs[rn]; break; --=20 2.14.1 From nobody Sat May 4 16:40:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524487229252782.3952463883775; Mon, 23 Apr 2018 05:40:29 -0700 (PDT) Received: from localhost ([::1]:43640 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAalg-0006kk-Dc for importer@patchew.org; Mon, 23 Apr 2018 08:40:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAae5-0001VP-V1 for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAae5-0008BL-7Z for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:37 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:37439) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fAae5-0008AV-0K for qemu-devel@nongnu.org; Mon, 23 Apr 2018 08:32:37 -0400 Received: by mail-lf0-x243.google.com with SMTP id b23-v6so14718270lfg.4 for ; Mon, 23 Apr 2018 05:32:36 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id x76-v6sm2830394lfb.63.2018.04.23.05.32.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 05:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Vn6ZfwtHj9411VBLOAKZhRjPvNlQb6Zy3b5H3anMTPM=; b=ZbRgx3hlpybCoRI4PFVs1YWXtglvfdGfLYipCBTeiifULtHNLtAUDqWx+sYuk1Eexg 2fA+1hPP+zJop+tkX6zYOAW4kHl0TbV2YyR4ijuGuT7WonnCfotc5etRE6WLxYxrEdWt 1Sj39K2hI0xDc6YSONGRAeMK5OkrG+4UoMxvMMft+IJrUFftj1/4J5lopKrwF15MLJ46 +geIbPIvJQnrWDWZToHQRuEWbO7zXHSpW2ye9ZgirjTaKKry3uH9XWsBo0SnI6f3ORCr NL6aO1zINth58Ig68Vr042vUw31SDd7z2K3gdnu6IuZhJpQLtWCMjgRho6FmMsDrJaf2 klOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Vn6ZfwtHj9411VBLOAKZhRjPvNlQb6Zy3b5H3anMTPM=; b=Kt77aVWmF742+9bcK5nEVOJGqjEUoMGwlQpdEeeN/e1nwLnrPzS6dbIlyLnJHq6fTt Cu0IBRtLNjaMfLvyDPuRlX1QjBarPERjAx3h4VXJ8ouxW98kR6AWEls+ReuO54dXESpE rxB3N93y5fYirWoWTFn0TJZFKHJTcRSyTkpaz5jH7dyACjs4ixgiwCcN0iJu88vF5Qz0 CgQERnouQkYrPPaIp/Nji0tTGThV06ajpmJe54op7Hj3PD+N2JzsYKc1G31lBKmNbT0W pwCtnBKhYZOqXrtJJ/R8MaNzCS2WYzuAJPGO9Kll9XiysN1FSLttmEg1VWjdwADkkcKz 8UsA== X-Gm-Message-State: ALQs6tDkQktageY69ho4IlkR7bxNMY0cbtNXXynO0u98i/sr8DWxg1v2 Ye/dbeJqbxYvLi1gTe5ci4DOKg== X-Google-Smtp-Source: AIpwx48om31Kec42Rh6HVX53+EDLqCxwVriyO5dNMc1P5VrSizrAXG5CsCBrMq4FKzgPoemm9h+05w== X-Received: by 10.46.146.13 with SMTP id k13mr13319704ljg.70.1524486755272; Mon, 23 Apr 2018 05:32:35 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Mon, 23 Apr 2018 14:32:25 +0200 Message-Id: <20180423123225.30503-6-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180423123225.30503-1-edgar.iglesias@gmail.com> References: <20180423123225.30503-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::243 Subject: [Qemu-devel] [PATCH v2 5/5] target-microblaze: mmu: Make the TLBX MISS bit read-only X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com, alistair@alistair23.me, richard.henderson@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Make the TLBX MISS bit read-only. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias Reviewed-by: Richard Henderson --- target/microblaze/mmu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu.c index 8391811900..9d5e6aa8a5 100644 --- a/target/microblaze/mmu.c +++ b/target/microblaze/mmu.c @@ -273,6 +273,10 @@ void mmu_write(CPUMBState *env, uint32_t rn, uint32_t = v) env->mmu.regs[rn] =3D v; } break; + case MMU_R_TLBX: + /* Bit 31 is read-only. */ + env->mmu.regs[rn] =3D deposit32(env->mmu.regs[rn], 0, 31, v); + break; case MMU_R_TLBSX: { struct microblaze_mmu_lookup lu; --=20 2.14.1