From nobody Thu May 2 08:28:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524258593778933.4423398420585; Fri, 20 Apr 2018 14:09:53 -0700 (PDT) Received: from localhost ([::1]:33936 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9dI0-0007rE-JC for importer@patchew.org; Fri, 20 Apr 2018 17:09:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9apu-0006lo-BC for qemu-devel@nongnu.org; Fri, 20 Apr 2018 14:32:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9apt-0005zI-FA for qemu-devel@nongnu.org; Fri, 20 Apr 2018 14:32:42 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:46150) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f9apr-0005o4-3h; Fri, 20 Apr 2018 14:32:39 -0400 Received: by mail-qk0-x242.google.com with SMTP id s70so9595447qks.13; Fri, 20 Apr 2018 11:32:38 -0700 (PDT) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:cdf7:2ede:7d2d:c27b]) by smtp.gmail.com with ESMTPSA id k73sm1191753qkl.89.2018.04.20.11.32.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Apr 2018 11:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=yNSHCtcj9utMBRpJ1SlzPX9ENvBuHCxJmQyxAYpoT2E=; b=MSXLAZHXm3uK/qbOQEmhtYqCLb4QUCoLdr4DjRDOSPaI1yofxd8Yp4PigBByLr3TFp ROFTCLk8bxCS1A8HAJBtIZKPzmX/bQBi2Z6bfMeNAE26r6Af6EbCoqHmD4ma0zpTB0oa M1DknOLLNSx7+lRsx8UGI9rqaXNu7UHDCw/qtmQbsKD+AjZYmyhv88dpCn6mj8XYfWLp z9gygS4H3EU9TY/zOFggqn78PDP5r9ZvNAZ26hsOuu97uxp2WN8BoZoxYlP1ICvCacUA Eqy///AODuddZYCe3/ErG3pD14BpinvnoZYtKqjr0A9XhGGwAVBbfQQ8Dv6hi0hfVD4t 30Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yNSHCtcj9utMBRpJ1SlzPX9ENvBuHCxJmQyxAYpoT2E=; b=osgt5q1xYxvLdVmbZAoVDgceW3I3GlrVVVy23aLX8fAi2DnwmpO98IGSkzuaXNldOR xCiygSAaAM9hcw4tN8+HWCxav4tBzKlUVx+IJYknrBsGKJaH1jEwMF4KTr98pRYWw14C T+z/bu1HDyfpAx+K/IgMqBbHbhwMzj7mifSMKniPOwSp267RcsGDWwiNNjjcFFLSXrcG JO0bGbQzEnhlG8CQ2Q/vn/Lczb1AHu7FyxnLuxa6zkxd8m88OYeoN7+QS7ci6YnUNbaK iXyXEpFZCaxyzYfFowzn79ztfIrIp4WWhhobci2fGTq0NftWv+y4SZObjBSeNge4fAcv rUgQ== X-Gm-Message-State: ALQs6tDA2ytDa8PMlLb1b2TcsdDPBG9nGW4qdF86KIrFI3EJ6TegKtvU u85oExkxEZRUsmbfyWIR4Yo= X-Google-Smtp-Source: AB8JxZrEuw1K1RncswCPQquOpQcPJUAP3Q6jd6NTddnF7+m/lDH71w/JKFqkAry57GvAiGfdWVsatA== X-Received: by 10.233.222.131 with SMTP id s125mr12401562qkf.131.1524249158092; Fri, 20 Apr 2018 11:32:38 -0700 (PDT) From: Jason Andryuk To: Gerd Hoffmann Date: Fri, 20 Apr 2018 14:32:19 -0400 Message-Id: <20180420183219.20722-1-jandryuk@gmail.com> X-Mailer: git-send-email 2.14.3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 X-Mailman-Approved-At: Fri, 20 Apr 2018 17:08:27 -0400 Subject: [Qemu-devel] [PATCH] ccid: Fix dwProtocols advertisement of T=0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, alevy@redhat.com, qemu-stable@nongnu.org, Jason Andryuk Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Commit d7d218ef02d87c637d20d64da8f575d434ff6f78 attempted to change dwProtocols to only advertise support for T=3D0 and not T=3D1. The change was incorrect as it changed 0x00000003 to 0x00010000. lsusb -v in a linux guest shows: "dwProtocols 65536 (Invalid values detected)", though the smart card could still be accessed. Windows 7 does not detect inserted smart cards and logs the the following Error in the Event Logs: Source: Smart Card Service Event ID: 610 Smart Card Reader 'QEMU QEMU USB CCID 0' rejected IOCTL SET_PROTOCOL: Incorrect function. If this error persists, your smart card or reader may not be functioning correctly Command Header: 03 00 00 00 Setting to 0x00000001 fixes the Windows issue. Signed-off-by: Jason Andryuk Cc: qemu-stable@nongnu.org --- hw/usb/dev-smartcard-reader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index e6468057a0..cabb564788 100644 --- a/hw/usb/dev-smartcard-reader.c +++ b/hw/usb/dev-smartcard-reader.c @@ -329,8 +329,8 @@ static const uint8_t qemu_ccid_descriptor[] =3D { */ 0x07, /* u8 bVoltageSupport; 01h - 5.0v, 02h - 3.0, 03 - 1.= 8 */ =20 - 0x00, 0x00, /* u32 dwProtocols; RRRR PPPP. RRRR =3D 0000h.*/ - 0x01, 0x00, /* PPPP: 0001h =3D Protocol T=3D0, 0002h =3D Protocol = T=3D1 */ + 0x01, 0x00, /* u32 dwProtocols; RRRR PPPP. RRRR =3D 0000h.*/ + 0x00, 0x00, /* PPPP: 0001h =3D Protocol T=3D0, 0002h =3D Protocol = T=3D1 */ /* u32 dwDefaultClock; in kHZ (0x0fa0 is 4 MHz) */ 0xa0, 0x0f, 0x00, 0x00, /* u32 dwMaximumClock; */ --=20 2.14.3