From nobody Sat Apr 27 20:55:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524199458656264.84723569834875; Thu, 19 Apr 2018 21:44:18 -0700 (PDT) Received: from localhost ([::1]:51013 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9Nu5-0005Z7-Ay for importer@patchew.org; Fri, 20 Apr 2018 00:44:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9NsR-0004Yr-1u for qemu-devel@nongnu.org; Fri, 20 Apr 2018 00:42:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9NsP-00077v-K3 for qemu-devel@nongnu.org; Fri, 20 Apr 2018 00:42:27 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:60978 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f9NsP-00077N-Et for qemu-devel@nongnu.org; Fri, 20 Apr 2018 00:42:25 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 07CB07D83F; Fri, 20 Apr 2018 04:42:25 +0000 (UTC) Received: from xz-mi.redhat.com (ovpn-12-54.pek2.redhat.com [10.72.12.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C6B92023238; Fri, 20 Apr 2018 04:42:21 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Fri, 20 Apr 2018 12:42:10 +0800 Message-Id: <20180420044212.28765-2-peterx@redhat.com> In-Reply-To: <20180420044212.28765-1-peterx@redhat.com> References: <20180420044212.28765-1-peterx@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 20 Apr 2018 04:42:25 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 20 Apr 2018 04:42:25 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'peterx@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH v3 1/3] qemu-thread: introduce qemu-thread-common.[ch] X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Emilio G . Cota" , Fam Zheng , peterx@redhat.com, Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Put all the shared qemu-thread implementations into these files. The header should be internal to qemu-thread but not for qemu-thread users. Introduce some hooks correspondingly for the shared part. Note that in qemu_mutex_unlock_impl() we moved the call before unlock operation which should make more sense. And we don't need qemu_mutex_post_unlock() hook. Currently the hooks only calls the tracepoints. Signed-off-by: Peter Xu --- util/qemu-thread-common.h | 23 +++++++++++++++++++++++ util/qemu-thread-common.c | 30 ++++++++++++++++++++++++++++++ util/qemu-thread-posix.c | 17 +++++++---------- util/qemu-thread-win32.c | 15 +++++++-------- util/Makefile.objs | 4 ++-- 5 files changed, 69 insertions(+), 20 deletions(-) create mode 100644 util/qemu-thread-common.h create mode 100644 util/qemu-thread-common.c diff --git a/util/qemu-thread-common.h b/util/qemu-thread-common.h new file mode 100644 index 0000000000..f3f66613e9 --- /dev/null +++ b/util/qemu-thread-common.h @@ -0,0 +1,23 @@ +/* + * Common qemu-thread implementation header file. + * + * Copyright Red Hat, Inc. 2018 + * + * Authors: + * Peter Xu , + * + * This work is licensed under the terms of the GNU GPL, version 2 or late= r. + * See the COPYING file in the top-level directory. + */ + +#ifndef __QEMU_THREAD_COMMON_H__ +#define __QEMU_THREAD_COMMON_H__ + +#include "qemu/typedefs.h" +#include "qemu/thread.h" + +void qemu_mutex_pre_lock(QemuMutex *mutex, const char *file, int line); +void qemu_mutex_post_lock(QemuMutex *mutex, const char *file, int line); +void qemu_mutex_pre_unlock(QemuMutex *mutex, const char *file, int line); + +#endif diff --git a/util/qemu-thread-common.c b/util/qemu-thread-common.c new file mode 100644 index 0000000000..fc1f1aa969 --- /dev/null +++ b/util/qemu-thread-common.c @@ -0,0 +1,30 @@ +/* + * Common qemu-thread implementation shared for all platforms. + * + * Copyright Red Hat, Inc. 2018 + * + * Authors: + * Peter Xu , + * + * This work is licensed under the terms of the GNU GPL, version 2 or late= r. + * See the COPYING file in the top-level directory. + */ + +#include "qemu/osdep.h" +#include "qemu-thread-common.h" +#include "trace.h" + +void qemu_mutex_pre_lock(QemuMutex *mutex, const char *file, int line) +{ + trace_qemu_mutex_lock(mutex, file, line); +} + +void qemu_mutex_post_lock(QemuMutex *mutex, const char *file, int line) +{ + trace_qemu_mutex_locked(mutex, file, line); +} + +void qemu_mutex_pre_unlock(QemuMutex *mutex, const char *file, int line) +{ + trace_qemu_mutex_unlock(mutex, file, line); +} diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c index b789cf32e9..b0e7008db3 100644 --- a/util/qemu-thread-posix.c +++ b/util/qemu-thread-posix.c @@ -14,7 +14,7 @@ #include "qemu/thread.h" #include "qemu/atomic.h" #include "qemu/notify.h" -#include "trace.h" +#include "qemu-thread-common.h" =20 static bool name_threads; =20 @@ -62,13 +62,11 @@ void qemu_mutex_lock_impl(QemuMutex *mutex, const char = *file, const int line) int err; =20 assert(mutex->initialized); - trace_qemu_mutex_lock(mutex, file, line); - + qemu_mutex_pre_lock(mutex, file, line); err =3D pthread_mutex_lock(&mutex->lock); if (err) error_exit(err, __func__); - - trace_qemu_mutex_locked(mutex, file, line); + qemu_mutex_post_lock(mutex, file, line); } =20 int qemu_mutex_trylock_impl(QemuMutex *mutex, const char *file, const int = line) @@ -78,7 +76,7 @@ int qemu_mutex_trylock_impl(QemuMutex *mutex, const char = *file, const int line) assert(mutex->initialized); err =3D pthread_mutex_trylock(&mutex->lock); if (err =3D=3D 0) { - trace_qemu_mutex_locked(mutex, file, line); + qemu_mutex_post_lock(mutex, file, line); return 0; } if (err !=3D EBUSY) { @@ -92,11 +90,10 @@ void qemu_mutex_unlock_impl(QemuMutex *mutex, const cha= r *file, const int line) int err; =20 assert(mutex->initialized); + qemu_mutex_pre_unlock(mutex, file, line); err =3D pthread_mutex_unlock(&mutex->lock); if (err) error_exit(err, __func__); - - trace_qemu_mutex_unlock(mutex, file, line); } =20 void qemu_rec_mutex_init(QemuRecMutex *mutex) @@ -160,9 +157,9 @@ void qemu_cond_wait_impl(QemuCond *cond, QemuMutex *mut= ex, const char *file, con int err; =20 assert(cond->initialized); - trace_qemu_mutex_unlock(mutex, file, line); + qemu_mutex_pre_unlock(mutex, file, line); err =3D pthread_cond_wait(&cond->cond, &mutex->lock); - trace_qemu_mutex_locked(mutex, file, line); + qemu_mutex_post_lock(mutex, file, line); if (err) error_exit(err, __func__); } diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c index ab60c0d557..f9fb0581f2 100644 --- a/util/qemu-thread-win32.c +++ b/util/qemu-thread-win32.c @@ -19,7 +19,7 @@ #include "qemu-common.h" #include "qemu/thread.h" #include "qemu/notify.h" -#include "trace.h" +#include "qemu-thread-common.h" #include =20 static bool name_threads; @@ -59,10 +59,9 @@ void qemu_mutex_destroy(QemuMutex *mutex) void qemu_mutex_lock_impl(QemuMutex *mutex, const char *file, const int li= ne) { assert(mutex->initialized); - trace_qemu_mutex_lock(mutex, file, line); - + qemu_mutex_pre_lock(mutex, file, line); AcquireSRWLockExclusive(&mutex->lock); - trace_qemu_mutex_locked(mutex, file, line); + qemu_mutex_post_lock(mutex, file, line); } =20 int qemu_mutex_trylock_impl(QemuMutex *mutex, const char *file, const int = line) @@ -72,7 +71,7 @@ int qemu_mutex_trylock_impl(QemuMutex *mutex, const char = *file, const int line) assert(mutex->initialized); owned =3D TryAcquireSRWLockExclusive(&mutex->lock); if (owned) { - trace_qemu_mutex_locked(mutex, file, line); + qemu_mutex_post_lock(mutex, file, line); return 0; } return -EBUSY; @@ -81,7 +80,7 @@ int qemu_mutex_trylock_impl(QemuMutex *mutex, const char = *file, const int line) void qemu_mutex_unlock_impl(QemuMutex *mutex, const char *file, const int = line) { assert(mutex->initialized); - trace_qemu_mutex_unlock(mutex, file, line); + qemu_mutex_pre_unlock(mutex, file, line); ReleaseSRWLockExclusive(&mutex->lock); } =20 @@ -145,9 +144,9 @@ void qemu_cond_broadcast(QemuCond *cond) void qemu_cond_wait_impl(QemuCond *cond, QemuMutex *mutex, const char *fil= e, const int line) { assert(cond->initialized); - trace_qemu_mutex_unlock(mutex, file, line); + qemu_mutex_pre_unlock(mutex, file, line); SleepConditionVariableSRW(&cond->var, &mutex->lock, INFINITE, 0); - trace_qemu_mutex_locked(mutex, file, line); + qemu_mutex_post_lock(mutex, file, line); } =20 void qemu_sem_init(QemuSemaphore *sem, int init) diff --git a/util/Makefile.objs b/util/Makefile.objs index 728c3541db..04d6713daf 100644 --- a/util/Makefile.objs +++ b/util/Makefile.objs @@ -9,12 +9,12 @@ util-obj-$(CONFIG_POSIX) +=3D event_notifier-posix.o util-obj-$(CONFIG_POSIX) +=3D mmap-alloc.o util-obj-$(CONFIG_POSIX) +=3D oslib-posix.o util-obj-$(CONFIG_POSIX) +=3D qemu-openpty.o -util-obj-$(CONFIG_POSIX) +=3D qemu-thread-posix.o +util-obj-$(CONFIG_POSIX) +=3D qemu-thread-posix.o qemu-thread-common.o util-obj-$(CONFIG_POSIX) +=3D memfd.o util-obj-$(CONFIG_WIN32) +=3D aio-win32.o util-obj-$(CONFIG_WIN32) +=3D event_notifier-win32.o util-obj-$(CONFIG_WIN32) +=3D oslib-win32.o -util-obj-$(CONFIG_WIN32) +=3D qemu-thread-win32.o +util-obj-$(CONFIG_WIN32) +=3D qemu-thread-win32.o qemu-thread-common.o util-obj-y +=3D envlist.o path.o module.o util-obj-y +=3D host-utils.o util-obj-y +=3D bitmap.o bitops.o hbitmap.o --=20 2.14.3 From nobody Sat Apr 27 20:55:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524199452703483.9515398980732; Thu, 19 Apr 2018 21:44:12 -0700 (PDT) Received: from localhost ([::1]:51014 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9Nu7-0005bH-VF for importer@patchew.org; Fri, 20 Apr 2018 00:44:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9NsT-0004b8-Oo for qemu-devel@nongnu.org; Fri, 20 Apr 2018 00:42:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9NsS-0007DB-QF for qemu-devel@nongnu.org; Fri, 20 Apr 2018 00:42:29 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53676 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f9NsS-0007CV-Lt for qemu-devel@nongnu.org; Fri, 20 Apr 2018 00:42:28 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3C0BA4023335; Fri, 20 Apr 2018 04:42:28 +0000 (UTC) Received: from xz-mi.redhat.com (ovpn-12-54.pek2.redhat.com [10.72.12.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id A079F2024CA1; Fri, 20 Apr 2018 04:42:25 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Fri, 20 Apr 2018 12:42:11 +0800 Message-Id: <20180420044212.28765-3-peterx@redhat.com> In-Reply-To: <20180420044212.28765-1-peterx@redhat.com> References: <20180420044212.28765-1-peterx@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 20 Apr 2018 04:42:28 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 20 Apr 2018 04:42:28 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'peterx@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH v3 2/3] QemuMutex: support --enable-debug-mutex X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Emilio G . Cota" , Fam Zheng , peterx@redhat.com, Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We have had some tracing tools for mutex but it's not easy to use them for e.g. dead locks. Let's provide "--enable-debug-mutex" parameter when configure to allow QemuMutex to store the last owner that took specific lock. It will be easy to use this tool to debug deadlocks since we can directly know who took the lock then as long as we can have a debugger attached to the process. Signed-off-by: Peter Xu --- configure | 10 ++++++++++ include/qemu/thread-posix.h | 4 ++++ include/qemu/thread-win32.h | 4 ++++ util/qemu-thread-common.c | 8 ++++++++ 4 files changed, 26 insertions(+) diff --git a/configure b/configure index 0a19b033bc..a80af735b2 100755 --- a/configure +++ b/configure @@ -451,6 +451,7 @@ jemalloc=3D"no" replication=3D"yes" vxhs=3D"" libxml2=3D"" +debug_mutex=3D"no" =20 supported_cpu=3D"no" supported_os=3D"no" @@ -1374,6 +1375,10 @@ for opt do ;; --disable-git-update) git_update=3Dno ;; + --enable-debug-mutex) debug_mutex=3Dyes + ;; + --disable-debug-mutex) debug_mutex=3Dno + ;; *) echo "ERROR: unknown option $opt" echo "Try '$0 --help' for more information" @@ -1631,6 +1636,7 @@ disabled with --disable-FEATURE, default is enabled i= f available: crypto-afalg Linux AF_ALG crypto backend driver vhost-user vhost-user support capstone capstone disassembler support + debug-mutex mutex debugging support =20 NOTE: The object files are built at the place where configure is launched EOF @@ -5874,6 +5880,7 @@ echo "avx2 optimization $avx2_opt" echo "replication support $replication" echo "VxHS block device $vxhs" echo "capstone $capstone" +echo "mutex debugging $debug_mutex" =20 if test "$sdl_too_old" =3D "yes"; then echo "-> Your SDL version is too old - please upgrade to have SDL support" @@ -6602,6 +6609,9 @@ fi if test "$capstone" !=3D "no" ; then echo "CONFIG_CAPSTONE=3Dy" >> $config_host_mak fi +if test "$debug_mutex" =3D "yes" ; then + echo "CONFIG_DEBUG_MUTEX=3Dy" >> $config_host_mak +fi =20 # Hold two types of flag: # CONFIG_THREAD_SETNAME_BYTHREAD - we've got a way of setting the name = on diff --git a/include/qemu/thread-posix.h b/include/qemu/thread-posix.h index f3f47e426f..fd27b34128 100644 --- a/include/qemu/thread-posix.h +++ b/include/qemu/thread-posix.h @@ -12,6 +12,10 @@ typedef QemuMutex QemuRecMutex; =20 struct QemuMutex { pthread_mutex_t lock; +#ifdef CONFIG_DEBUG_MUTEX + const char *file; + int line; +#endif bool initialized; }; =20 diff --git a/include/qemu/thread-win32.h b/include/qemu/thread-win32.h index 3a05e3b3aa..d668d789b4 100644 --- a/include/qemu/thread-win32.h +++ b/include/qemu/thread-win32.h @@ -5,6 +5,10 @@ =20 struct QemuMutex { SRWLOCK lock; +#ifdef CONFIG_DEBUG_MUTEX + const char *file; + int line; +#endif bool initialized; }; =20 diff --git a/util/qemu-thread-common.c b/util/qemu-thread-common.c index fc1f1aa969..fb88bf111c 100644 --- a/util/qemu-thread-common.c +++ b/util/qemu-thread-common.c @@ -21,10 +21,18 @@ void qemu_mutex_pre_lock(QemuMutex *mutex, const char *= file, int line) =20 void qemu_mutex_post_lock(QemuMutex *mutex, const char *file, int line) { +#ifdef CONFIG_DEBUG_MUTEX + mutex->file =3D file; + mutex->line =3D line; +#endif trace_qemu_mutex_locked(mutex, file, line); } =20 void qemu_mutex_pre_unlock(QemuMutex *mutex, const char *file, int line) { +#ifdef CONFIG_DEBUG_MUTEX + mutex->file =3D NULL; + mutex->line =3D 0; +#endif trace_qemu_mutex_unlock(mutex, file, line); } --=20 2.14.3 From nobody Sat Apr 27 20:55:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524199564014281.5446350256698; Thu, 19 Apr 2018 21:46:04 -0700 (PDT) Received: from localhost ([::1]:51195 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9Nvv-0007Ml-9v for importer@patchew.org; Fri, 20 Apr 2018 00:46:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9NsZ-0004f4-2a for qemu-devel@nongnu.org; Fri, 20 Apr 2018 00:42:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9NsW-0007IS-18 for qemu-devel@nongnu.org; Fri, 20 Apr 2018 00:42:35 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:54446 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f9NsV-0007He-SX for qemu-devel@nongnu.org; Fri, 20 Apr 2018 00:42:31 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 71391EBFEA; Fri, 20 Apr 2018 04:42:31 +0000 (UTC) Received: from xz-mi.redhat.com (ovpn-12-54.pek2.redhat.com [10.72.12.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id D24082026E04; Fri, 20 Apr 2018 04:42:28 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Fri, 20 Apr 2018 12:42:12 +0800 Message-Id: <20180420044212.28765-4-peterx@redhat.com> In-Reply-To: <20180420044212.28765-1-peterx@redhat.com> References: <20180420044212.28765-1-peterx@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 20 Apr 2018 04:42:31 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 20 Apr 2018 04:42:31 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'peterx@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH v3 3/3] configure: enable debug-mutex if debug enabled X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Emilio G . Cota" , Fam Zheng , peterx@redhat.com, Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Xu --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index a80af735b2..87453edd88 100755 --- a/configure +++ b/configure @@ -1005,6 +1005,7 @@ for opt do --enable-debug) # Enable debugging options that aren't excessively noisy debug_tcg=3D"yes" + debug_mutex=3D"yes" debug=3D"yes" strip_opt=3D"no" fortify_source=3D"no" --=20 2.14.3