From nobody Mon Apr 29 16:55:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524137040658442.40908942286023; Thu, 19 Apr 2018 04:24:00 -0700 (PDT) Received: from localhost ([::1]:39914 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f97fO-0007cr-6F for importer@patchew.org; Thu, 19 Apr 2018 07:23:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f97dE-0006Kp-N0 for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f97d9-00082q-TU for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:40 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:35004) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f97d9-00081U-Ln for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:35 -0400 Received: by mail-lf0-x243.google.com with SMTP id r125-v6so273179lfe.2 for ; Thu, 19 Apr 2018 04:21:35 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id u11sm552749ljd.70.2018.04.19.04.21.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Apr 2018 04:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KCQD2uCaIVEnvBk8Wm9AqpRuCKTgFgfRjRVu0nZSHA8=; b=aFCZsdMILGR6sAXp70llrBYkFw6sESM8g+KYPa3hyYWsIEktF5HOUGplIyMspeRMnX BxES74Ji7Rz4D29QNV1HY7q0ne8lXpMeOutiequbCmtVKYyoFPqQ8tS8TMY3yx8xh4hP ooRkVGzXgiVmDTQG9ILXGPyefAqZ+inp+Uv7lZorPITTQSu8l8+AySL3Ls9ALUP4NPJC rZMg2vlwE3NAHl/OqznwF0OkAAsq8m281oxSR69VznV7jT0OfldWMmuFNPyNc3w2QQx6 5x8YB1BVeUlZYk8FAp0hJvKlLS7eIZLNqXppv/XHvqVWTfKutzawd6HWEdGcJYUo6mHt z1+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KCQD2uCaIVEnvBk8Wm9AqpRuCKTgFgfRjRVu0nZSHA8=; b=Y0Cg4J5tlIMdUyFzG/LDOJ2o19BWboSKKPSfUIGOh6x6QDm0C8Tzfv6aH9cwr7U12z CFk1GT9Ofy/sj4w/bgfL9G8GKaQoCs6wHlnm6Q/6ydOh8wSP8upnicvd4NvyKHBzpth1 cAfWd/+9Qz78Deugo6I0VZkmi2e6j6YJyUmutsTlKqDn83ybm9Ej1XMLUKwWCJkJD3p9 EbZqVsHW25EcKiVsRfeNy0FZtXtOS/hvib+3Zhj0GM2d1hltsqFvyII+yddXkvKXhMe7 eOxqGyVIv780pEYXw0W7xYFBzpnn6aRvKkA+MihW3AjfoZEJirLuuL90ydScQasY/E/J 17yg== X-Gm-Message-State: ALQs6tChrlUIoxIZ6wfLmArYKnMW8J1FarOV3iffarly6dchlW+p+YBI owXR4s8+kLecQf/GdL0uS9Iqcg== X-Google-Smtp-Source: AB8JxZqGsCSMtTHzakRvHAs8yzqx/q/TCjHi9mdmq9FRQFhV1VJFFVeWmFX/59eL9io4vT81Ig5Y8A== X-Received: by 2002:a19:a70d:: with SMTP id q13-v6mr99964lfe.78.1524136894199; Thu, 19 Apr 2018 04:21:34 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Thu, 19 Apr 2018 13:21:27 +0200 Message-Id: <20180419112131.16932-2-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180419112131.16932-1-edgar.iglesias@gmail.com> References: <20180419112131.16932-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::243 Subject: [Qemu-devel] [PATCH v1 1/5] target-microblaze: Respect MSR.PVR as read-only X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, peter.maydell@linaro.org, alistair@alistair23.me, edgar.iglesias@xilinx.com, frasse.iglesias@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Respect MSR.PVR as read-only. We were wrongly overwriting the PVR bit. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.h | 4 +++- target/microblaze/translate.c | 8 +------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h index 5be71bc320..0eb9e2b8e2 100644 --- a/target/microblaze/cpu.h +++ b/target/microblaze/cpu.h @@ -59,6 +59,8 @@ typedef struct CPUMBState CPUMBState; #define SR_EDR 0xd =20 /* MSR flags. */ +#define MSR_PVR_SHIFT 10 + #define MSR_BE (1<<0) /* 0x001 */ #define MSR_IE (1<<1) /* 0x002 */ #define MSR_C (1<<2) /* 0x004 */ @@ -69,7 +71,7 @@ typedef struct CPUMBState CPUMBState; #define MSR_DCE (1<<7) /* 0x080 */ #define MSR_EE (1<<8) /* 0x100 */ #define MSR_EIP (1<<9) /* 0x200 */ -#define MSR_PVR (1<<10) /* 0x400 */ +#define MSR_PVR (1 << MSR_PVR_SHIFT) #define MSR_CC (1<<31) =20 /* Machine State Register (MSR) Fields */ diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 7628b0e25b..df62563815 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -417,15 +417,9 @@ static inline void msr_read(DisasContext *dc, TCGv d) =20 static inline void msr_write(DisasContext *dc, TCGv v) { - TCGv t; - - t =3D tcg_temp_new(); dc->cpustate_changed =3D 1; /* PVR bit is not writable. */ - tcg_gen_andi_tl(t, v, ~MSR_PVR); - tcg_gen_andi_tl(cpu_SR[SR_MSR], cpu_SR[SR_MSR], MSR_PVR); - tcg_gen_or_tl(cpu_SR[SR_MSR], cpu_SR[SR_MSR], v); - tcg_temp_free(t); + tcg_gen_deposit_tl(cpu_SR[SR_MSR], v, cpu_SR[SR_MSR], MSR_PVR_SHIFT, 1= ); } =20 static void dec_msr(DisasContext *dc) --=20 2.14.1 From nobody Mon Apr 29 16:55:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524137200959954.9848555469745; Thu, 19 Apr 2018 04:26:40 -0700 (PDT) Received: from localhost ([::1]:40038 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f97i3-0001lR-Nb for importer@patchew.org; Thu, 19 Apr 2018 07:26:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f97dE-0006Kn-Mb for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f97dB-00085F-9y for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:40 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:38110) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f97dB-00083h-1S for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:37 -0400 Received: by mail-lf0-x243.google.com with SMTP id z130-v6so261049lff.5 for ; Thu, 19 Apr 2018 04:21:36 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id m4-v6sm691545lfg.69.2018.04.19.04.21.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Apr 2018 04:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SpJxqyVXAPbaVoaf3nK6reeOnnK/RdgrfWKcyPV8pLk=; b=j+qvJDbG4aRexHeaP5daySCfsaMVPoJENACysGPYyONYiPSExuWPgfHGvBt9P2djxa qqCYJAtWFGBerHYeONcfrSwcyjVRoQrL9GHiuRPtatP1UhWatAh1T+eIphNF0dgCBzPa 1iCTU0N2S59bun1FRorTB7gcUUmUZbaNWoxD6fibZsoWm2vab5G/ee8n/FEDFV7Tm5Ff gaSoSyEJOOGDESfG1q23kVQvu/lV1I7HSMx2ilh0yKrhsqfHuxo1H/2wqnfSS+wz48vk ksVXP0jgD8Jri/NOHgnrrkcOjVcFYSOD6C1V/XWXUmXkv85X43MOKw47jYgQHhSuobtI jx8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SpJxqyVXAPbaVoaf3nK6reeOnnK/RdgrfWKcyPV8pLk=; b=PRKNHeaIZhTE+ocC3zsYgNRBJSEExOrF4IsFndhawtEYC0KS2TT6Gce9fMaEbujZJa Qv4PUTqTa5+Xbm23iRVRWusBwFeaA5QOSjewRAlKO5+f9YNzgsfvwMRGMeCrGORY/s5O WK25Oa3//ZpZYFb/HilKpup6Uos3bUhOz/3KNFoiWEfk2s1K0KOJcFbUnH/zApNXuZWm I4fuxXA0q2EyslD3Q30eemj3PDZYts1kB/9nH2ZV5VMeZd1T321wT1MOOeRC9lx8HNqw TgmOHpG02vy3oqi/tJV8k23BtcEvTB0c+kmmkxq6vODA/QnGkS70F4mmwSd+2VyzMuXn xYww== X-Gm-Message-State: ALQs6tDBoAzju9go3DR8pOTo4zEfykxPmQE14GZEsS6KWNHtqWYWOIaq lDF5mB/xWQwYNMp89ArFRd84qw== X-Google-Smtp-Source: AIpwx4/LbZC6Ooj4Ssstw6uIssRJwC1KZl1a03bDi8zc3cs29Z/p7G9jLCSAhzwt4eVgX2Ti1YR+uA== X-Received: by 10.46.144.72 with SMTP id n8mr4183496ljg.96.1524136895606; Thu, 19 Apr 2018 04:21:35 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Thu, 19 Apr 2018 13:21:28 +0200 Message-Id: <20180419112131.16932-3-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180419112131.16932-1-edgar.iglesias@gmail.com> References: <20180419112131.16932-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::243 Subject: [Qemu-devel] [PATCH v1 2/5] target-microblaze: Fix trap checks for FPU insns X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, peter.maydell@linaro.org, alistair@alistair23.me, edgar.iglesias@xilinx.com, frasse.iglesias@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Fix trap checks for FPU insns when extended FPU insns are enabled. Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis --- target/microblaze/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index df62563815..5f9efcdd11 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -1406,7 +1406,7 @@ static void dec_fpu(DisasContext *dc) =20 if ((dc->tb_flags & MSR_EE_FLAG) && (dc->cpu->env.pvr.regs[2] & PVR2_ILL_OPCODE_EXC_MASK) - && (dc->cpu->cfg.use_fpu !=3D 1)) { + && !dc->cpu->cfg.use_fpu) { tcg_gen_movi_tl(cpu_SR[SR_ESR], ESR_EC_ILLEGAL_OP); t_gen_raise_exception(dc, EXCP_HW_EXCP); return; --=20 2.14.1 From nobody Mon Apr 29 16:55:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524137197513903.8147942251247; Thu, 19 Apr 2018 04:26:37 -0700 (PDT) Received: from localhost ([::1]:40035 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f97i0-0001iT-AS for importer@patchew.org; Thu, 19 Apr 2018 07:26:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f97dE-0006Kq-NR for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f97dC-00087q-VY for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:40 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:38109) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f97dC-000866-Nj for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:38 -0400 Received: by mail-lf0-x241.google.com with SMTP id z130-v6so261154lff.5 for ; Thu, 19 Apr 2018 04:21:38 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id b75-v6sm692141lfe.95.2018.04.19.04.21.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Apr 2018 04:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=E9x7LMluqRMdlDbLWt+Ktfq/D94SZo6hzUcalKdiRhs=; b=uNatSTa2Tw4HqDewomRWTbVys2z4g3rIuAsIKPrvdBKZslg4irho4xLt/qozrWWPTn Xcu4Tp5FKExW1L7tE2kKBvMTYZdcouwOGDy2NaxZTt5wI2F4KGl64nDF6NndpjQK/m7K Zi/lWbP17U+2D+yfgZUbhsJjSi7WQAeRu+iLRLlhUeh3nfkIPx+wM/TYW9P56dkM//lA 90DBOhJgP16UYloywsucVPWaVqS1VxkR67M2b5gP1HZLidXH2k+6Q29Ri0tYqdqV64n1 SzaVP9Q4UTOoObH7iir+ju1u+aRABoAVCmIsSBrd2fdzUmFUhUmoXlkhNoe/lXx6QpaI R35Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=E9x7LMluqRMdlDbLWt+Ktfq/D94SZo6hzUcalKdiRhs=; b=ecZdMca7OgrtiJwwMMui1Cso4m23w80Oi2jATz6uLl8834jm4e/t46jS8EWIt4dqjJ nKGKOLVSgueP7sfMnMVfSkhFGPBELkfeWopyxReMGwE4BXdbaoj5UYChBrLhkocKlvZV 0onDCFZYfLGNRy05n8CFqQgAA68g/+6lyFmDyupcSdRWvxkXf1oIaSel954VB0oOGr7Z qx7okrKcTGWVQ3KHbmAbwwSh21E7s/HZGNy6SRFkuhqxMFh6AYNWtjo0xwMLwu6O5jjd SU4eogNlT8eq8dZl/Ogla7G2/znC20TOq5bfVcDGY/n1Ma4Ya4AWs/NHPYMbmEpBlF5l DFcg== X-Gm-Message-State: ALQs6tAMib6bqFV1Py8cBkbHS9RD8HWPyb9M3ULK1J4C0d0bQP7yrCyn HoqSzwi9J/B6lpUxR4yOpRVwVA== X-Google-Smtp-Source: AIpwx4/zPt6qaM/J2vyCDO0Yeoj6dRZwWlIVeTUIYoqSCDs5MO8Mb0gYeyVnaTuB8i7hcWB5QrDlLw== X-Received: by 10.46.153.206 with SMTP id l14mr3883585ljj.87.1524136897239; Thu, 19 Apr 2018 04:21:37 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Thu, 19 Apr 2018 13:21:29 +0200 Message-Id: <20180419112131.16932-4-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180419112131.16932-1-edgar.iglesias@gmail.com> References: <20180419112131.16932-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::241 Subject: [Qemu-devel] [PATCH v1 3/5] target-microblaze: Don't clobber the IMM reg for ld/st reversed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, peter.maydell@linaro.org, alistair@alistair23.me, edgar.iglesias@xilinx.com, frasse.iglesias@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Do not clobber the IMM register on reversed load/stores. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 5f9efcdd11..9dcbdf5509 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -946,7 +946,6 @@ static void dec_load(DisasContext *dc) tcg_gen_sub_tl(low, tcg_const_tl(3), low); tcg_gen_andi_tl(t, t, ~3); tcg_gen_or_tl(t, t, low); - tcg_gen_mov_tl(env_imm, t); tcg_temp_free(low); break; } @@ -1098,7 +1097,6 @@ static void dec_store(DisasContext *dc) tcg_gen_sub_tl(low, tcg_const_tl(3), low); tcg_gen_andi_tl(t, t, ~3); tcg_gen_or_tl(t, t, low); - tcg_gen_mov_tl(env_imm, t); tcg_temp_free(low); break; } --=20 2.14.1 From nobody Mon Apr 29 16:55:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524137040600741.0895752912062; Thu, 19 Apr 2018 04:24:00 -0700 (PDT) Received: from localhost ([::1]:39913 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f97fO-0007br-4M for importer@patchew.org; Thu, 19 Apr 2018 07:23:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f97dF-0006Kw-5T for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f97dE-0008AW-BB for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:41 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:38928) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f97dE-00088e-3a for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:40 -0400 Received: by mail-lf0-x244.google.com with SMTP id p142-v6so256929lfd.6 for ; Thu, 19 Apr 2018 04:21:40 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id d4-v6sm699133lfg.65.2018.04.19.04.21.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Apr 2018 04:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=926VobcRZCbz7x34pQuYZuBazeF2gF/iCeHh8lVgaHY=; b=oKvmn6QJzHocFdHKS8cxQreZJLugyY905vbX9AmzzKXInTLHwVnX2jLYOeu2p51cLE hjRS0iPXQMjzzMl3RyIBRXSrMxC3bhuqKNE0Xn1tgy0VWfIwdN6PNEcfBBSrxuY76fFH 6sFBRnkvHCdQi2bc7vZhbYhuPFOZqk+S6meFy6VDCM3DqEIhWxhyamcuT86nOgIbpyim sZdXs4JDJemRKoII1cWbu55DHEC0M71ChixZSuABrDpfcu/iTgKB0Iv5Jy+hawoXPSNf kpRRsSgCIoXvnqIIoXDVIyGwUaBJBQCOmRQBUG8M9rpzmTuM2N/ohl4uFj8iUZisSjpz XtyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=926VobcRZCbz7x34pQuYZuBazeF2gF/iCeHh8lVgaHY=; b=PW27I6JnTU7x9eW4hzLqC8Ugy24tgd/1jm/mlV1b4aCuh7WX8kO3zsTMBiBI+HC5l9 IODmYdFBI7yLO6NkQCe6R/I81y5yZ/vJqfpiYxtZHohZay12wcB7QORjwBQ3fHZqfeGQ Jgcta6s13p8hlznjLJ0vWsEwc/LZa4hOdEEgTsB8aM1jaRHpXmcRPguiolF0IsBhQBt6 ClCQ7xF18ypVXXRRlCbd702DGeea4N+zyl+SpwFRYeogl4OX3spPx2HXdImd/yDBU4E4 zD9y7EIDDEEhbSARtnVwFJbrGLU15gmuPeDBXg2k3KobswFazjlmows5rwOEoSnXF7bV F84w== X-Gm-Message-State: ALQs6tD0CDftKA+IglQztN7MaTRHVb1xiCEi/Ldr3gEfQildPuQLjG2A +ePrYTiDZWv03h7iRIEnIjTP7A== X-Google-Smtp-Source: AIpwx4+W6CFHy47LmxHyPFDu43ggq6vb4rzZ99ImyuDZoZafOj8j9O384DIv0DzRj2lVCfvvbO0heg== X-Received: by 10.46.128.76 with SMTP id p12mr3955825ljg.71.1524136898598; Thu, 19 Apr 2018 04:21:38 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Thu, 19 Apr 2018 13:21:30 +0200 Message-Id: <20180419112131.16932-5-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180419112131.16932-1-edgar.iglesias@gmail.com> References: <20180419112131.16932-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::244 Subject: [Qemu-devel] [PATCH v1 4/5] target-microblaze: mmu: Make TLBSX write-only X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, peter.maydell@linaro.org, alistair@alistair23.me, edgar.iglesias@xilinx.com, frasse.iglesias@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Make TLBSX write-only and guest-error log reads from it. Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis --- target/microblaze/mmu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu.c index a0f06758f8..8391811900 100644 --- a/target/microblaze/mmu.c +++ b/target/microblaze/mmu.c @@ -182,7 +182,7 @@ done: uint32_t mmu_read(CPUMBState *env, uint32_t rn) { unsigned int i; - uint32_t r; + uint32_t r =3D 0; =20 if (env->mmu.c_mmu < 2 || !env->mmu.c_mmu_tlb_access) { qemu_log_mask(LOG_GUEST_ERROR, "MMU access on MMU-less system\n"); @@ -211,6 +211,9 @@ uint32_t mmu_read(CPUMBState *env, uint32_t rn) } r =3D env->mmu.regs[rn]; break; + case MMU_R_TLBSX: + qemu_log_mask(LOG_GUEST_ERROR, "TLBSX is write-only.\n"); + break; default: r =3D env->mmu.regs[rn]; break; --=20 2.14.1 From nobody Mon Apr 29 16:55:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524137041615620.3086859470426; Thu, 19 Apr 2018 04:24:01 -0700 (PDT) Received: from localhost ([::1]:39915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f97fU-0007hu-NX for importer@patchew.org; Thu, 19 Apr 2018 07:24:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f97dG-0006La-Ox for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f97dF-0008E8-Rx for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:42 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:44713) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f97dF-0008Bj-IH for qemu-devel@nongnu.org; Thu, 19 Apr 2018 07:21:41 -0400 Received: by mail-lf0-x243.google.com with SMTP id g203-v6so242069lfg.11 for ; Thu, 19 Apr 2018 04:21:41 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id o14sm551544ljg.52.2018.04.19.04.21.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Apr 2018 04:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kTleqyN7EVOlfN4nzHNmcfkK34VwD8kpV4Z7EWYNq18=; b=LCA9PMY79dxqiEv77oh8VjJf+HUigHdiOPeFj3OKqxe/gsl7Ys69+KoIE1lvNC3T4D 5IHSqznscQhl+xUcg5M2fqIjYRcyFRapyoVW0qiu7UEIdCttCcHDan+JEdHTDgTMxggS R2BJk5YmBpYK2466lskJG7alrMnBAJ88lFsWvMGg8+OpaY3Etj8/UGzIbVH1afpFGPln qcj2lkTSyIQJVyJ1Zz/SvqqccljwRZLRpNykfS4fHdF6iFZsUEBsB6McuT9BXF2eDGNt 2m4COOyuMEL0yy9LFBfKxdeEaDjs/Nv4G+mEp2+kj17CoenXEuSARBnuySnjhbdYrLeH tQ/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kTleqyN7EVOlfN4nzHNmcfkK34VwD8kpV4Z7EWYNq18=; b=mN7gLnZEO+UssMsBLhZW+9i4PRwp2Aj7dIuYyPLu4dM9DtAIeTLX0YhigKEWkeXV0M JTM7ozS+EuD/z9CakxSFUYoz1m/QvYcYZxpdUQEUuDVmrY1N2zxnRu6Km9f9iG2/FlVF txJ2YxXZg+qtt7+YGH/uWD4whTCyBjM9SxMpNyTCuIl84AZFw6xq2MIgMNmoX8+4wBkt tLMzIHuSgjW/NSwElPi/XrcpS2Is+nVkS67SwJjMaLZ8FfFsuqvWBxti5+Yft4zajTVk ij7NiU2gT9wkFSJMiii0Eug36zGBXXiqLJ3wqqf6P7Lb5YipgBoKx/hBegYkJZxyGSru CGNA== X-Gm-Message-State: ALQs6tCK4VWkbIK+/oBlP0E8TXkOs8c4FZCbuKg2lEhtT8AJooLon4T0 zabtUvND9U3DZlDRqCsQ2TwakQ== X-Google-Smtp-Source: AIpwx48ym74u9dQp2l+t/aLPnrqskAvmNgrG3yCzCX8X3EMMog/q2KRSW9d0CzJNfNi2euwuQc00NQ== X-Received: by 10.46.128.139 with SMTP id i11mr3961199ljg.97.1524136900053; Thu, 19 Apr 2018 04:21:40 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Thu, 19 Apr 2018 13:21:31 +0200 Message-Id: <20180419112131.16932-6-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180419112131.16932-1-edgar.iglesias@gmail.com> References: <20180419112131.16932-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::243 Subject: [Qemu-devel] [PATCH v1 5/5] target-microblaze: mmu: Make the TLBX MISS bit read-only X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sai.pavan.boddu@xilinx.com, peter.maydell@linaro.org, alistair@alistair23.me, edgar.iglesias@xilinx.com, frasse.iglesias@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Make the TLBX MISS bit read-only. Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis --- target/microblaze/mmu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu.c index 8391811900..9d5e6aa8a5 100644 --- a/target/microblaze/mmu.c +++ b/target/microblaze/mmu.c @@ -273,6 +273,10 @@ void mmu_write(CPUMBState *env, uint32_t rn, uint32_t = v) env->mmu.regs[rn] =3D v; } break; + case MMU_R_TLBX: + /* Bit 31 is read-only. */ + env->mmu.regs[rn] =3D deposit32(env->mmu.regs[rn], 0, 31, v); + break; case MMU_R_TLBSX: { struct microblaze_mmu_lookup lu; --=20 2.14.1