From the datasheet (3368J–SEEPR) description:
The AT25128A/256A provides 131,072/262,144 bits of serial
electrically-erasable programmable read only memory (EEPROM)
organized as 16,384/32,768 words of 8 bits each.
However QEMU models the flash size in bytes.
Correct the at25128a/at25256a entries to reflect the datasheet size.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
This is not a regression, so can now wait for 2.13.
hw/block/m25p80.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index b49c8e9caa..d0b9fbfc50 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -196,8 +196,8 @@ static const FlashPartInfo known_devices[] = {
/* Atmel EEPROMS - it is assumed, that don't care bit in command
* is set to 0. Block protection is not supported.
*/
- { INFO("at25128a-nonjedec", 0x0, 0, 1, 131072, EEPROM) },
- { INFO("at25256a-nonjedec", 0x0, 0, 1, 262144, EEPROM) },
+ { INFO("at25128a-nonjedec", 0x0, 0, 1, 16384, EEPROM) },
+ { INFO("at25256a-nonjedec", 0x0, 0, 1, 32768, EEPROM) },
/* EON -- en25xxx */
{ INFO("en25f32", 0x1c3116, 0, 64 << 10, 64, ER_4K) },
--
2.17.0
W dniu 15.04.2018 o 22:31, Philippe Mathieu-Daudé pisze: > >From the datasheet (3368J–SEEPR) description: > The AT25128A/256A provides 131,072/262,144 bits of serial > electrically-erasable programmable read only memory (EEPROM) > organized as 16,384/32,768 words of 8 bits each. > > However QEMU models the flash size in bytes. > Correct the at25128a/at25256a entries to reflect the datasheet size. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Marcin Krzeminski <mar.krzeminski@gmail.com> > --- > This is not a regression, so can now wait for 2.13. > > hw/block/m25p80.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index b49c8e9caa..d0b9fbfc50 100644 > --- a/hw/block/m25p80.c > +++ b/hw/block/m25p80.c > @@ -196,8 +196,8 @@ static const FlashPartInfo known_devices[] = { > /* Atmel EEPROMS - it is assumed, that don't care bit in command > * is set to 0. Block protection is not supported. > */ > - { INFO("at25128a-nonjedec", 0x0, 0, 1, 131072, EEPROM) }, > - { INFO("at25256a-nonjedec", 0x0, 0, 1, 262144, EEPROM) }, > + { INFO("at25128a-nonjedec", 0x0, 0, 1, 16384, EEPROM) }, > + { INFO("at25256a-nonjedec", 0x0, 0, 1, 32768, EEPROM) }, Thanks! Marcin > > /* EON -- en25xxx */ > { INFO("en25f32", 0x1c3116, 0, 64 << 10, 64, ER_4K) },
On Mon, Apr 16, 2018 at 9:05 AM, mar.krzeminski <mar.krzeminski@gmail.com> wrote: > W dniu 15.04.2018 o 22:31, Philippe Mathieu-Daudé pisze: >> >> >From the datasheet (3368J–SEEPR) description: >> The AT25128A/256A provides 131,072/262,144 bits of serial >> electrically-erasable programmable read only memory (EEPROM) >> organized as 16,384/32,768 words of 8 bits each. >> >> However QEMU models the flash size in bytes. >> Correct the at25128a/at25256a entries to reflect the datasheet size. >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > > Reviewed-by: Marcin Krzeminski <mar.krzeminski@gmail.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair >> >> --- >> This is not a regression, so can now wait for 2.13. >> >> hw/block/m25p80.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c >> index b49c8e9caa..d0b9fbfc50 100644 >> --- a/hw/block/m25p80.c >> +++ b/hw/block/m25p80.c >> @@ -196,8 +196,8 @@ static const FlashPartInfo known_devices[] = { >> /* Atmel EEPROMS - it is assumed, that don't care bit in command >> * is set to 0. Block protection is not supported. >> */ >> - { INFO("at25128a-nonjedec", 0x0, 0, 1, 131072, EEPROM) }, >> - { INFO("at25256a-nonjedec", 0x0, 0, 1, 262144, EEPROM) }, >> + { INFO("at25128a-nonjedec", 0x0, 0, 1, 16384, EEPROM) }, >> + { INFO("at25256a-nonjedec", 0x0, 0, 1, 32768, EEPROM) }, > > Thanks! > Marcin > >> /* EON -- en25xxx */ >> { INFO("en25f32", 0x1c3116, 0, 64 << 10, 64, ER_4K) }, > > >
Hi Peter, Kevin, On 04/16/2018 05:52 PM, Alistair Francis wrote: > On Mon, Apr 16, 2018 at 9:05 AM, mar.krzeminski > <mar.krzeminski@gmail.com> wrote: >> W dniu 15.04.2018 o 22:31, Philippe Mathieu-Daudé pisze: >>> >>> >From the datasheet (3368J–SEEPR) description: >>> The AT25128A/256A provides 131,072/262,144 bits of serial >>> electrically-erasable programmable read only memory (EEPROM) >>> organized as 16,384/32,768 words of 8 bits each. >>> >>> However QEMU models the flash size in bytes. >>> Correct the at25128a/at25256a entries to reflect the datasheet size. >>> >>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> >> Reviewed-by: Marcin Krzeminski <mar.krzeminski@gmail.com> > > Reviewed-by: Alistair Francis <alistair.francis@wdc.com> > > Alistair > >>> >>> --- >>> This is not a regression, so can now wait for 2.13. >>> >>> hw/block/m25p80.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c >>> index b49c8e9caa..d0b9fbfc50 100644 >>> --- a/hw/block/m25p80.c >>> +++ b/hw/block/m25p80.c >>> @@ -196,8 +196,8 @@ static const FlashPartInfo known_devices[] = { >>> /* Atmel EEPROMS - it is assumed, that don't care bit in command >>> * is set to 0. Block protection is not supported. >>> */ >>> - { INFO("at25128a-nonjedec", 0x0, 0, 1, 131072, EEPROM) }, >>> - { INFO("at25256a-nonjedec", 0x0, 0, 1, 262144, EEPROM) }, >>> + { INFO("at25128a-nonjedec", 0x0, 0, 1, 16384, EEPROM) }, >>> + { INFO("at25256a-nonjedec", 0x0, 0, 1, 32768, EEPROM) }, >> >> Thanks! >> Marcin >> >>> /* EON -- en25xxx */ >>> { INFO("en25f32", 0x1c3116, 0, 64 << 10, 64, ER_4K) }, >> >> >> Can this patch goes via the ARM or Block tree? Thanks, Phil.
© 2016 - 2024 Red Hat, Inc.