[Qemu-devel] [PATCH 0/2] iotests: Skip 181 and 201 without userfaultfd

Max Reitz posted 2 patches 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180406151731.4285-1-mreitz@redhat.com
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test s390x passed
tests/qemu-iotests/181         | 13 ++++++++++
tests/qemu-iotests/201         | 13 ++++++++++
tests/qemu-iotests/common.qemu | 58 +++++++++++++++++++++++++++++++++++++-----
3 files changed, 77 insertions(+), 7 deletions(-)
[Qemu-devel] [PATCH 0/2] iotests: Skip 181 and 201 without userfaultfd
Posted by Max Reitz 6 years ago
My non-Fedora testing system does not have a kernel with userfaultfd
support which causes 181 and 201 to fail.  That is annoying.  This
series makes those tests recognize the issue and convert it into a
_notrun.


Max Reitz (2):
  iotests: Add failure matching to common.qemu
  iotests: Skip 181 and 201 without userfaultfd

 tests/qemu-iotests/181         | 13 ++++++++++
 tests/qemu-iotests/201         | 13 ++++++++++
 tests/qemu-iotests/common.qemu | 58 +++++++++++++++++++++++++++++++++++++-----
 3 files changed, 77 insertions(+), 7 deletions(-)

-- 
2.14.3


Re: [Qemu-devel] [PATCH 0/2 for-2.12?] iotests: Skip 181 and 201 without userfaultfd
Posted by Eric Blake 6 years ago
On 04/06/2018 10:17 AM, Max Reitz wrote:
> My non-Fedora testing system does not have a kernel with userfaultfd
> support which causes 181 and 201 to fail.  That is annoying.  This
> series makes those tests recognize the issue and convert it into a
> _notrun.

As this is just testsuite fixes, is this worth including in 2.12?  Then
again, as we are now building for -rc3, missing the release merely means
tests fail, and not a broken binary.

> 
> 
> Max Reitz (2):
>   iotests: Add failure matching to common.qemu
>   iotests: Skip 181 and 201 without userfaultfd
> 
>  tests/qemu-iotests/181         | 13 ++++++++++
>  tests/qemu-iotests/201         | 13 ++++++++++
>  tests/qemu-iotests/common.qemu | 58 +++++++++++++++++++++++++++++++++++++-----
>  3 files changed, 77 insertions(+), 7 deletions(-)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH 0/2 for-2.12?] iotests: Skip 181 and 201 without userfaultfd
Posted by Max Reitz 6 years ago
On 2018-04-06 17:30, Eric Blake wrote:
> On 04/06/2018 10:17 AM, Max Reitz wrote:
>> My non-Fedora testing system does not have a kernel with userfaultfd
>> support which causes 181 and 201 to fail.  That is annoying.  This
>> series makes those tests recognize the issue and convert it into a
>> _notrun.
> 
> As this is just testsuite fixes, is this worth including in 2.12?  Then
> again, as we are now building for -rc3, missing the release merely means
> tests fail, and not a broken binary.

I usually merge test patches independently of freeze, but on the other
hand I prefer to only take the really necessary things for the later
RCs.  Sooo... I haven't decided yet. :-)

Max

>> Max Reitz (2):
>>   iotests: Add failure matching to common.qemu
>>   iotests: Skip 181 and 201 without userfaultfd
>>
>>  tests/qemu-iotests/181         | 13 ++++++++++
>>  tests/qemu-iotests/201         | 13 ++++++++++
>>  tests/qemu-iotests/common.qemu | 58 +++++++++++++++++++++++++++++++++++++-----
>>  3 files changed, 77 insertions(+), 7 deletions(-)
>>
> 


Re: [Qemu-devel] [PATCH 0/2] iotests: Skip 181 and 201 without userfaultfd
Posted by Max Reitz 6 years ago
On 2018-04-06 17:17, Max Reitz wrote:
> My non-Fedora testing system does not have a kernel with userfaultfd
> support which causes 181 and 201 to fail.  That is annoying.  This
> series makes those tests recognize the issue and convert it into a
> _notrun.
> 
> 
> Max Reitz (2):
>   iotests: Add failure matching to common.qemu
>   iotests: Skip 181 and 201 without userfaultfd
> 
>  tests/qemu-iotests/181         | 13 ++++++++++
>  tests/qemu-iotests/201         | 13 ++++++++++
>  tests/qemu-iotests/common.qemu | 58 +++++++++++++++++++++++++++++++++++++-----
>  3 files changed, 77 insertions(+), 7 deletions(-)

Ping (considering these are test suite fixes, I'd merge them without
review, too, though.)

Max

Re: [Qemu-devel] [PATCH 0/2] iotests: Skip 181 and 201 without userfaultfd
Posted by Max Reitz 5 years, 12 months ago
On 2018-04-06 17:17, Max Reitz wrote:
> My non-Fedora testing system does not have a kernel with userfaultfd
> support which causes 181 and 201 to fail.  That is annoying.  This
> series makes those tests recognize the issue and convert it into a
> _notrun.
> 
> 
> Max Reitz (2):
>   iotests: Add failure matching to common.qemu
>   iotests: Skip 181 and 201 without userfaultfd
> 
>  tests/qemu-iotests/181         | 13 ++++++++++
>  tests/qemu-iotests/201         | 13 ++++++++++
>  tests/qemu-iotests/common.qemu | 58 +++++++++++++++++++++++++++++++++++++-----
>  3 files changed, 77 insertions(+), 7 deletions(-)

Applied to my block-next branch.

Max