[Qemu-devel] [PATCH v2 0/6] e1000 migration changes for 2.12

Dr. David Alan Gilbert (git) posted 6 patches 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180328163630.48576-1-dgilbert@redhat.com
Test checkpatch passed
Test docker-build@min-glib failed
Test docker-mingw@fedora passed
Test docker-quick@centos6 failed
Test s390x passed
hw/net/e1000.c      | 103 ++++++++++++++++++++++++++++++++++++++++------------
include/hw/compat.h |   4 ++
2 files changed, 84 insertions(+), 23 deletions(-)
[Qemu-devel] [PATCH v2 0/6] e1000 migration changes for 2.12
Posted by Dr. David Alan Gilbert (git) 6 years ago
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Hi,
  This set of patches change the e1000 migration code to make
it easier to keep with compatibility with older versions in backwards
migration.

I think the first 3 patches are fairly uncontrovercial and I would like
them for 2.12; it would be nice to have the lot since changing them
after we've shipped is much more difficult.

v2
  Ed and Paolo answered my question that I asked in the cover letter;
and I think I've followed the advice - although my testing has been
very light.  The new patches do two things:
   a) When we receive a stream without the subsection we duplicate the
received pops state into both props and tso_props.
   b) When we send without the subsection we decide which set to send
in the main part of the state based on which state was last changed.

Dave

Dr. David Alan Gilbert (6):
  e1000: Convert v3 fields to subsection
  e1000: Dupe offload data on reading old stream
  e1000: wire new subsection to property
  e1000: Migrate props via a temporary structure
  e1000: Choose which set of props to migrate
  e1000: Old machine types, turn new subsection off

 hw/net/e1000.c      | 103 ++++++++++++++++++++++++++++++++++++++++------------
 include/hw/compat.h |   4 ++
 2 files changed, 84 insertions(+), 23 deletions(-)

-- 
2.14.3


Re: [Qemu-devel] [PATCH v2 0/6] e1000 migration changes for 2.12
Posted by Jason Wang 6 years ago

On 2018年03月29日 00:36, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Hi,
>    This set of patches change the e1000 migration code to make
> it easier to keep with compatibility with older versions in backwards
> migration.
>
> I think the first 3 patches are fairly uncontrovercial and I would like
> them for 2.12; it would be nice to have the lot since changing them
> after we've shipped is much more difficult.
>
> v2
>    Ed and Paolo answered my question that I asked in the cover letter;
> and I think I've followed the advice - although my testing has been
> very light.  The new patches do two things:
>     a) When we receive a stream without the subsection we duplicate the
> received pops state into both props and tso_props.
>     b) When we send without the subsection we decide which set to send
> in the main part of the state based on which state was last changed.
>
> Dave
>
> Dr. David Alan Gilbert (6):
>    e1000: Convert v3 fields to subsection
>    e1000: Dupe offload data on reading old stream
>    e1000: wire new subsection to property
>    e1000: Migrate props via a temporary structure
>    e1000: Choose which set of props to migrate
>    e1000: Old machine types, turn new subsection off
>
>   hw/net/e1000.c      | 103 ++++++++++++++++++++++++++++++++++++++++------------
>   include/hw/compat.h |   4 ++
>   2 files changed, 84 insertions(+), 23 deletions(-)
>

Reviewed-by: Jason Wang <jasowang@redhat.com>