From nobody Sun Apr 28 21:04:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1522203917567647.0175893635743; Tue, 27 Mar 2018 19:25:17 -0700 (PDT) Received: from localhost ([::1]:37075 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f10m4-0006AD-Qq for importer@patchew.org; Tue, 27 Mar 2018 22:25:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f10ji-0004RE-BJ for qemu-devel@nongnu.org; Tue, 27 Mar 2018 22:22:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f10jh-0002ko-EP for qemu-devel@nongnu.org; Tue, 27 Mar 2018 22:22:50 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:43801) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f10jh-0002kb-89 for qemu-devel@nongnu.org; Tue, 27 Mar 2018 22:22:49 -0400 Received: by mail-pf0-x243.google.com with SMTP id j2so400430pff.10 for ; Tue, 27 Mar 2018 19:22:49 -0700 (PDT) Received: from cloudburst.twiddle.net ([121.215.28.70]) by smtp.gmail.com with ESMTPSA id 67sm5717731pfp.122.2018.03.27.19.22.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Mar 2018 19:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aYOvnXxHtqwog0x7GNQJk6qyEkCYwa2jmMvekB1xTz8=; b=ZMzc1Cw6TACy6/kxkcmN5M4YmjXJqbempXjsIVVw8st2RdYdT+LnNCRa1OnzwtHI7j DFbI/A/ryBk2IGR3LB3C0ELEr7v7hKnOW1h/aVCpbyg1X4wfpFTRtxgK2QYNymtcSS8J ekUZTczL7gIzkuEw/5lJU1ClMN8nSvC66UblQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aYOvnXxHtqwog0x7GNQJk6qyEkCYwa2jmMvekB1xTz8=; b=BtNQ4VFv93FdfqaD3WXMpn1H0swiDlUjf97ihkRc0AgoysTQWw2Rd0WQfFzZozQoMf rwtHhlELrdD4vPDIZ4HmFUDEp30gBTDMMuDs/JUF+A0wwE5X5NtbIx5Olvdev/eSlJej BWEUaEqJsxIqGJfQGe2ySbnb0T/GXy3Jdw4lx1cghvg64xIpCgXz7dAnIQDxXOrG0d96 92ue65dgVhxrC1hJIHnqb2sHFMErxJ8BS+uYtPBSWcJwpsR81U8RMByKRZDAuyG0Bqy6 sU58c2H9Y31EbNoMFUQWmx4d2+1hl+ouJ8XSzXJfxnPP/4frhbj0frbvCchSg02nXqwD VWuQ== X-Gm-Message-State: AElRT7HlrHYfjRT3ptWRGhEcLcStNeALyAxbF9L2w1Xbh72H/fHy0sqd 3tt/N/HDSKA70oPIzhMISvvLs0WuzOU= X-Google-Smtp-Source: AIpwx4+iWaVrWDXajsrnoiDw3keQLN8I0/GReRw/asnDFN4KQVkk1OV3fvbIb+fY+wIP3LtnhSGIHQ== X-Received: by 10.101.74.69 with SMTP id a5mr1241234pgu.32.1522203767804; Tue, 27 Mar 2018 19:22:47 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 28 Mar 2018 10:22:32 +0800 Message-Id: <20180328022233.13400-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180328022233.13400-1-richard.henderson@linaro.org> References: <20180328022233.13400-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PATCH 1/2] target/riscv: Split out mstatus_fs from tb_flags during translation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@groups.riscv.org, mjc@sifive.com, palmer@sifive.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We will want to track changes to mstatus_fs through the TB. As there is nothing else in tb_flags at the moment, remove the variable from DisasContext. Signed-off-by: Richard Henderson Reviewed-by: Michael Clark --- target/riscv/cpu.h | 6 +++--- target/riscv/translate.c | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 41e06ac0f9..d201dd3e90 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -269,8 +269,8 @@ void QEMU_NORETURN do_raise_exception_err(CPURISCVState= *env, target_ulong cpu_riscv_get_fflags(CPURISCVState *env); void cpu_riscv_set_fflags(CPURISCVState *env, target_ulong); =20 -#define TB_FLAGS_MMU_MASK 3 -#define TB_FLAGS_FP_ENABLE MSTATUS_FS +#define TB_FLAGS_MMU_MASK 3 +#define TB_FLAGS_MSTATUS_FS MSTATUS_FS =20 static inline void cpu_get_tb_cpu_state(CPURISCVState *env, target_ulong *= pc, target_ulong *cs_base, uint32_t *f= lags) @@ -278,7 +278,7 @@ static inline void cpu_get_tb_cpu_state(CPURISCVState *= env, target_ulong *pc, *pc =3D env->pc; *cs_base =3D 0; #ifdef CONFIG_USER_ONLY - *flags =3D TB_FLAGS_FP_ENABLE; + *flags =3D TB_FLAGS_MSTATUS_FS; #else *flags =3D cpu_mmu_index(env, 0) | (env->mstatus & MSTATUS_FS); #endif diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 808eab7f50..a30724aa90 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -43,7 +43,7 @@ typedef struct DisasContext { target_ulong pc; target_ulong next_pc; uint32_t opcode; - uint32_t flags; + uint32_t mstatus_fs; uint32_t mem_idx; int singlestep_enabled; int bstate; @@ -665,7 +665,7 @@ static void gen_fp_load(DisasContext *ctx, uint32_t opc= , int rd, { TCGv t0; =20 - if (!(ctx->flags & TB_FLAGS_FP_ENABLE)) { + if (ctx->mstatus_fs =3D=3D 0) { gen_exception_illegal(ctx); return; } @@ -695,7 +695,7 @@ static void gen_fp_store(DisasContext *ctx, uint32_t op= c, int rs1, { TCGv t0; =20 - if (!(ctx->flags & TB_FLAGS_FP_ENABLE)) { + if (ctx->mstatus_fs =3D=3D 0) { gen_exception_illegal(ctx); return; } @@ -986,7 +986,7 @@ static void gen_fp_arith(DisasContext *ctx, uint32_t op= c, int rd, { TCGv t0 =3D NULL; =20 - if (!(ctx->flags & TB_FLAGS_FP_ENABLE)) { + if (ctx->mstatus_fs =3D=3D 0) { goto do_illegal; } =20 @@ -1862,8 +1862,8 @@ void gen_intermediate_code(CPUState *cs, TranslationB= lock *tb) =20 ctx.tb =3D tb; ctx.bstate =3D BS_NONE; - ctx.flags =3D tb->flags; ctx.mem_idx =3D tb->flags & TB_FLAGS_MMU_MASK; + ctx.mstatus_fs =3D tb->flags & TB_FLAGS_MSTATUS_FS; ctx.frm =3D -1; /* unknown rounding mode */ =20 num_insns =3D 0; --=20 2.14.3 From nobody Sun Apr 28 21:04:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1522203992458316.98738747315383; Tue, 27 Mar 2018 19:26:32 -0700 (PDT) Received: from localhost ([::1]:37083 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f10nE-0006tX-L0 for importer@patchew.org; Tue, 27 Mar 2018 22:26:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f10jm-0004SX-L0 for qemu-devel@nongnu.org; Tue, 27 Mar 2018 22:22:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f10jl-0002m7-AZ for qemu-devel@nongnu.org; Tue, 27 Mar 2018 22:22:54 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:36024) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f10jl-0002lq-2F for qemu-devel@nongnu.org; Tue, 27 Mar 2018 22:22:53 -0400 Received: by mail-pf0-x243.google.com with SMTP id g14so408731pfh.3 for ; Tue, 27 Mar 2018 19:22:52 -0700 (PDT) Received: from cloudburst.twiddle.net ([121.215.28.70]) by smtp.gmail.com with ESMTPSA id 67sm5717731pfp.122.2018.03.27.19.22.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Mar 2018 19:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NVN+MnRFAzC9cwjCwkjcgdhIUMbKFmhULCTOgUBeiF0=; b=MvAof+SO2NKMAgjJP+AA7/YBILsLXmBMJfwFLcXkN0SQ9s0sK/nQza7cLadRFnrxty rLFhNCInm8c2ttPyIyxsVAe8oEeB9MJ3D1H2f6U8XapGukVOKDNBP39qWoJaUFvDKrrD IkuqRk+cyZ7XS1HwkByaNcyk0j2zIoN2B1HjI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NVN+MnRFAzC9cwjCwkjcgdhIUMbKFmhULCTOgUBeiF0=; b=FNntkMpWnTOHsLOLt1xAjh6Tk/xIp7YSbGii4KXguuJlke4L3tXyq/p7c8OCRimBPO QecwZ6V3kuZWkd/wR62xzf/j31VyDf7vzOU8WHUcnjMf3ebPuaZV9CtV0UZ9l5DGEjvU P7O354wxw9d5TcYriJh5yTZFhF8668ZscrwWxXQ+On3iEG7F2qnJXHvvr9dZ6CvTDjFR oHaZoC5aqjXCb+AmoiP6ALNGtqLbRkGCWgUVSI/wJ9FMg5AXG77478n7GY3CGixKlQdq pLTasqvNmUoc4NHLNfT78W4hhqPv2t0UPDJTtR/+GwRxRMRZj3yK3jJvT6bzJmNUt4BI FVqQ== X-Gm-Message-State: AElRT7EU+WyLBRvOCOZoR+iLGhIhDDRKngn0/cRcriD4P8BsUI8uGVa/ s/YPz1O9wl4cNXFpnKlQSRTbzD200YA= X-Google-Smtp-Source: AIpwx496qd2A17BikkcP47HqpSH3DuF65EpB9aMmcbE48m9X7xSrczADUv6s38wKArqM8nCFIWzB5g== X-Received: by 10.99.114.77 with SMTP id c13mr1192909pgn.286.1522203771774; Tue, 27 Mar 2018 19:22:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 28 Mar 2018 10:22:33 +0800 Message-Id: <20180328022233.13400-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180328022233.13400-1-richard.henderson@linaro.org> References: <20180328022233.13400-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PATCH 2/2] target/riscv: Mark MSTATUS_FS dirty X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@groups.riscv.org, mjc@sifive.com, palmer@sifive.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Writes to the FP register file mark the register file as dirty. Signed-off-by: Richard Henderson Reviewed-by: Michael Clark Tested-by: Michael Clark --- target/riscv/op_helper.c | 25 +++++++++++++++++-------- target/riscv/translate.c | 40 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 56 insertions(+), 9 deletions(-) diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c index e34715df4e..74eeef0be8 100644 --- a/target/riscv/op_helper.c +++ b/target/riscv/op_helper.c @@ -72,11 +72,20 @@ void helper_raise_exception(CPURISCVState *env, uint32_= t exception) do_raise_exception_err(env, exception, 0); } =20 -static void validate_mstatus_fs(CPURISCVState *env, uintptr_t ra) +static void validate_mstatus_fs(CPURISCVState *env, uintptr_t ra, bool wri= te) { #ifndef CONFIG_USER_ONLY - if (!(env->mstatus & MSTATUS_FS)) { + switch (get_field(env->mstatus, MSTATUS_FS)) { + case 0: /* disabled */ do_raise_exception_err(env, RISCV_EXCP_ILLEGAL_INST, ra); + g_assert_not_reached(); + case 1: /* initial */ + case 2: /* clean */ + if (write) { + /* Mark fp status as dirty. */ + env->mstatus =3D MSTATUS_FS; + } + break; } #endif } @@ -96,15 +105,15 @@ void csr_write_helper(CPURISCVState *env, target_ulong= val_to_write, =20 switch (csrno) { case CSR_FFLAGS: - validate_mstatus_fs(env, GETPC()); + validate_mstatus_fs(env, GETPC(), true); cpu_riscv_set_fflags(env, val_to_write & (FSR_AEXC >> FSR_AEXC_SHI= FT)); break; case CSR_FRM: - validate_mstatus_fs(env, GETPC()); + validate_mstatus_fs(env, GETPC(), true); env->frm =3D val_to_write & (FSR_RD >> FSR_RD_SHIFT); break; case CSR_FCSR: - validate_mstatus_fs(env, GETPC()); + validate_mstatus_fs(env, GETPC(), true); env->frm =3D (val_to_write & FSR_RD) >> FSR_RD_SHIFT; cpu_riscv_set_fflags(env, (val_to_write & FSR_AEXC) >> FSR_AEXC_SH= IFT); break; @@ -379,13 +388,13 @@ target_ulong csr_read_helper(CPURISCVState *env, targ= et_ulong csrno) =20 switch (csrno) { case CSR_FFLAGS: - validate_mstatus_fs(env, GETPC()); + validate_mstatus_fs(env, GETPC(), false); return cpu_riscv_get_fflags(env); case CSR_FRM: - validate_mstatus_fs(env, GETPC()); + validate_mstatus_fs(env, GETPC(), false); return env->frm; case CSR_FCSR: - validate_mstatus_fs(env, GETPC()); + validate_mstatus_fs(env, GETPC(), false); return (cpu_riscv_get_fflags(env) << FSR_AEXC_SHIFT) | (env->frm << FSR_RD_SHIFT); /* rdtime/rdtimeh is trapped and emulated by bbl in system mode */ diff --git a/target/riscv/translate.c b/target/riscv/translate.c index a30724aa90..08fc42a679 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -660,6 +660,31 @@ static void gen_store(DisasContext *ctx, uint32_t opc,= int rs1, int rs2, tcg_temp_free(dat); } =20 +#ifndef CONFIG_USER_ONLY +/* The states of mstatus_fs are: + * 0 =3D disabled, 1 =3D initial, 2 =3D clean, 3 =3D dirty + * We will have already diagnosed disabled state, + * and need to turn initial/clean into dirty. + */ +static void mark_fs_dirty(DisasContext *ctx) +{ + TCGv tmp; + if (ctx->mstatus_fs =3D=3D MSTATUS_FS) { + return; + } + /* Remember the state change for the rest of the TB. */ + ctx->mstatus_fs =3D MSTATUS_FS; + + tmp =3D tcg_temp_new(); + tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPURISCVState, mstatus)); + tcg_gen_ori_tl(tmp, tmp, MSTATUS_FS); + tcg_gen_st_tl(tmp, cpu_env, offsetof(CPURISCVState, mstatus)); + tcg_temp_free(tmp); +} +#else +static inline void mark_fs_dirty(DisasContext *ctx) { } +#endif + static void gen_fp_load(DisasContext *ctx, uint32_t opc, int rd, int rs1, target_long imm) { @@ -688,6 +713,8 @@ static void gen_fp_load(DisasContext *ctx, uint32_t opc= , int rd, break; } tcg_temp_free(t0); + + mark_fs_dirty(ctx); } =20 static void gen_fp_store(DisasContext *ctx, uint32_t opc, int rs1, @@ -985,6 +1012,7 @@ static void gen_fp_arith(DisasContext *ctx, uint32_t o= pc, int rd, int rs1, int rs2, int rm) { TCGv t0 =3D NULL; + bool fp_output =3D true; =20 if (ctx->mstatus_fs =3D=3D 0) { goto do_illegal; @@ -1047,6 +1075,7 @@ static void gen_fp_arith(DisasContext *ctx, uint32_t = opc, int rd, } gen_set_gpr(rd, t0); tcg_temp_free(t0); + fp_output =3D false; break; =20 case OPC_RISC_FCVT_W_S: @@ -1076,6 +1105,7 @@ static void gen_fp_arith(DisasContext *ctx, uint32_t = opc, int rd, } gen_set_gpr(rd, t0); tcg_temp_free(t0); + fp_output =3D false; break; =20 case OPC_RISC_FCVT_S_W: @@ -1126,6 +1156,7 @@ static void gen_fp_arith(DisasContext *ctx, uint32_t = opc, int rd, } gen_set_gpr(rd, t0); tcg_temp_free(t0); + fp_output =3D false; break; =20 case OPC_RISC_FMV_S_X: @@ -1218,6 +1249,7 @@ static void gen_fp_arith(DisasContext *ctx, uint32_t = opc, int rd, } gen_set_gpr(rd, t0); tcg_temp_free(t0); + fp_output =3D false; break; =20 case OPC_RISC_FCVT_W_D: @@ -1247,6 +1279,7 @@ static void gen_fp_arith(DisasContext *ctx, uint32_t = opc, int rd, } gen_set_gpr(rd, t0); tcg_temp_free(t0); + fp_output =3D false; break; =20 case OPC_RISC_FCVT_D_W: @@ -1294,6 +1327,7 @@ static void gen_fp_arith(DisasContext *ctx, uint32_t = opc, int rd, default: goto do_illegal; } + fp_output =3D false; break; =20 case OPC_RISC_FMV_D_X: @@ -1310,7 +1344,11 @@ static void gen_fp_arith(DisasContext *ctx, uint32_t= opc, int rd, tcg_temp_free(t0); } gen_exception_illegal(ctx); - break; + return; + } + + if (fp_output) { + mark_fs_dirty(ctx); } } =20 --=20 2.14.3