The list did not author any patches, but it does rewrite the
'From:' header of messages sent from any domain with restrictive
SPF policies that would otherwise prevent the message from reaching
all list recipients. If a maintainer is not careful to undo the
list header rewrite, and the author did not include a manual
'From:' line in the body to fix the munged header, then 'git am'
happily attributes the patch to the list. Add some mailmap
entries to correct the few that have escaped our attention; while
we also work on improving the tooling to catch the problem in
the future before a merge is even made.
Also improve the comments occurring in the file, including line
length improvements.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
Probably worth inclusion in 2.12-rc1, since it makes statistics
about the release easier to follow.
.mailmap | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/.mailmap b/.mailmap
index cf689b9ec99..b02c357e9a1 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1,6 +1,7 @@
-# This mailmap just translates the weird addresses from the original import into git
-# into proper addresses so that they are counted properly in git shortlog output.
-#
+# This mailmap fixes up author names/addresses.
+
+# The first section translates weird addresses from the original git import
+# into proper addresses so that they are counted properly by git shortlog.
Andrzej Zaborowski <balrogg@gmail.com> balrog <balrog@c046a42c-6fe2-441c-8c8c-71466251a162>
Anthony Liguori <anthony@codemonkey.ws> aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>
Anthony Liguori <anthony@codemonkey.ws> Anthony Liguori <aliguori@us.ibm.com>
@@ -15,10 +16,19 @@ Paul Burton <paul.burton@mips.com> <paul.burton@imgtec.com>
Paul Burton <paul.burton@mips.com> <paul@archlinuxmips.org>
Thiemo Seufer <ths@networkno.de> ths <ths@c046a42c-6fe2-441c-8c8c-71466251a162>
malc <av1474@comtv.ru> malc <malc@c046a42c-6fe2-441c-8c8c-71466251a162>
+
# There is also a:
# (no author) <(no author)@c046a42c-6fe2-441c-8c8c-71466251a162>
# for the cvs2svn initialization commit e63c3dc74bf.
-#
+
+# Next, translate a few commits where mailman rewrote the From: line due
+# to strict SPF, although we prefer to avoid adding more entries like that.
+Ed Swierk <eswierk@skyportsystems.com> Ed Swierk via Qemu-devel <qemu-devel@nongnu.org>
+Ian McKellar <ianloic@google.com> Ian McKellar via Qemu-devel <qemu-devel@nongnu.org>
+Julia Suvorova <jusual@mail.ru> Julia Suvorova via Qemu-devel <qemu-devel@nongnu.org>
+Justin Terry (VM) <juterry@microsoft.com> Justin Terry (VM) via Qemu-devel <qemu-devel@nongnu.org>
+
+
# Also list preferred name forms where people have changed their
# git author config
Daniel P. Berrangé <berrange@redhat.com>
--
2.14.3
On 03/26/2018 03:41 PM, Eric Blake wrote: > The list did not author any patches, but it does rewrite the > 'From:' header of messages sent from any domain with restrictive > SPF policies that would otherwise prevent the message from reaching > all list recipients. If a maintainer is not careful to undo the > list header rewrite, and the author did not include a manual > 'From:' line in the body to fix the munged header, then 'git am' > happily attributes the patch to the list. Add some mailmap > entries to correct the few that have escaped our attention; while > we also work on improving the tooling to catch the problem in > the future before a merge is even made. Thanks! > > Also improve the comments occurring in the file, including line > length improvements. > > Signed-off-by: Eric Blake <eblake@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > > Probably worth inclusion in 2.12-rc1, since it makes statistics > about the release easier to follow. > > .mailmap | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/.mailmap b/.mailmap > index cf689b9ec99..b02c357e9a1 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -1,6 +1,7 @@ > -# This mailmap just translates the weird addresses from the original import into git > -# into proper addresses so that they are counted properly in git shortlog output. > -# > +# This mailmap fixes up author names/addresses. > + > +# The first section translates weird addresses from the original git import > +# into proper addresses so that they are counted properly by git shortlog. > Andrzej Zaborowski <balrogg@gmail.com> balrog <balrog@c046a42c-6fe2-441c-8c8c-71466251a162> > Anthony Liguori <anthony@codemonkey.ws> aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162> > Anthony Liguori <anthony@codemonkey.ws> Anthony Liguori <aliguori@us.ibm.com> > @@ -15,10 +16,19 @@ Paul Burton <paul.burton@mips.com> <paul.burton@imgtec.com> > Paul Burton <paul.burton@mips.com> <paul@archlinuxmips.org> > Thiemo Seufer <ths@networkno.de> ths <ths@c046a42c-6fe2-441c-8c8c-71466251a162> > malc <av1474@comtv.ru> malc <malc@c046a42c-6fe2-441c-8c8c-71466251a162> > + > # There is also a: > # (no author) <(no author)@c046a42c-6fe2-441c-8c8c-71466251a162> > # for the cvs2svn initialization commit e63c3dc74bf. > -# > + > +# Next, translate a few commits where mailman rewrote the From: line due > +# to strict SPF, although we prefer to avoid adding more entries like that. > +Ed Swierk <eswierk@skyportsystems.com> Ed Swierk via Qemu-devel <qemu-devel@nongnu.org> > +Ian McKellar <ianloic@google.com> Ian McKellar via Qemu-devel <qemu-devel@nongnu.org> > +Julia Suvorova <jusual@mail.ru> Julia Suvorova via Qemu-devel <qemu-devel@nongnu.org> > +Justin Terry (VM) <juterry@microsoft.com> Justin Terry (VM) via Qemu-devel <qemu-devel@nongnu.org> > + > + > # Also list preferred name forms where people have changed their > # git author config > Daniel P. Berrangé <berrange@redhat.com> >
On 03/26/2018 01:41 PM, Eric Blake wrote: > The list did not author any patches, but it does rewrite the > 'From:' header of messages sent from any domain with restrictive > SPF policies that would otherwise prevent the message from reaching > all list recipients. If a maintainer is not careful to undo the > list header rewrite, and the author did not include a manual > 'From:' line in the body to fix the munged header, then 'git am' > happily attributes the patch to the list. Add some mailmap > entries to correct the few that have escaped our attention; while > we also work on improving the tooling to catch the problem in > the future before a merge is even made. > > Also improve the comments occurring in the file, including line > length improvements. > > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > > Probably worth inclusion in 2.12-rc1, since it makes statistics > about the release easier to follow. I'll include this in my qapi+misc pull for 2.12-rc2 -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
On 04/03/2018 01:45 PM, Eric Blake wrote: > On 03/26/2018 01:41 PM, Eric Blake wrote: >> The list did not author any patches, but it does rewrite the >> 'From:' header of messages sent from any domain with restrictive >> SPF policies that would otherwise prevent the message from reaching >> all list recipients. If a maintainer is not careful to undo the >> list header rewrite, and the author did not include a manual >> 'From:' line in the body to fix the munged header, then 'git am' >> happily attributes the patch to the list. Add some mailmap >> entries to correct the few that have escaped our attention; while >> we also work on improving the tooling to catch the problem in >> the future before a merge is even made. >> >> Also improve the comments occurring in the file, including line >> length improvements. >> >> Signed-off-by: Eric Blake <eblake@redhat.com> >> --- >> >> Probably worth inclusion in 2.12-rc1, since it makes statistics >> about the release easier to follow. > > I'll include this in my qapi+misc pull for 2.12-rc2 That pull request was abandoned; Paolo, do you want to pick this up in your misc tree? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
© 2016 - 2024 Red Hat, Inc.