[v1] Dirty bitmaps fixing and refactoring

[Qemu-devel] [PATCH 0/7] Dirty bitmaps fixing and refactoring

Vladimir Sementsov-Ogievskiy posted 7 patches 6 years ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180326112056.8420-1-vsementsov@virtuozzo.com

Test checkpatch passed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test docker-quick@centos6 passed

Test s390x passed

There is a newer version of this series

include/block/block_int.h    | 14 +++++----
include/block/dirty-bitmap.h | 15 ++++++----
block/dirty-bitmap.c         | 23 +++++++++------
blockdev.c                   | 69 ++++++++++++++------------------------------
4 files changed, 54 insertions(+), 67 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/7] Dirty bitmaps fixing and refactoring

Posted by Vladimir Sementsov-Ogievskiy 6 years ago

Nothing critical here.

01 - these functions are unused for now, but the will be used in
     the qmp bitmaps api.

Vladimir Sementsov-Ogievskiy (7):
  block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap
  dirty-bitmaps: fix comment about dirty_bitmap_mutex
  dirty-bitmap: remove missed bdrv_dirty_bitmap_get_autoload header
  dirty-bitmap: separate unused meta-bitmap related functions
  blockdev: refactor block-dirty-bitmap-clear transaction
  block/dirty-bitmap: bdrv_clear_dirty_bitmap: drop unused parameter
  blockdev: unify block-dirty-bitmap-clear command and transaction
    action

 include/block/block_int.h    | 14 +++++----
 include/block/dirty-bitmap.h | 15 ++++++----
 block/dirty-bitmap.c         | 23 +++++++++------
 blockdev.c                   | 69 ++++++++++++++------------------------------
 4 files changed, 54 insertions(+), 67 deletions(-)

-- 
2.11.1

Re: [Qemu-devel] [PATCH 0/7] Dirty bitmaps fixing and refactoring

Posted by Paolo Bonzini 6 years ago

On 26/03/2018 13:20, Vladimir Sementsov-Ogievskiy wrote:
> Nothing critical here.
> 
> 01 - these functions are unused for now, but the will be used in
>      the qmp bitmaps api.
> 
> Vladimir Sementsov-Ogievskiy (7):
>   block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap
>   dirty-bitmaps: fix comment about dirty_bitmap_mutex
>   dirty-bitmap: remove missed bdrv_dirty_bitmap_get_autoload header
>   dirty-bitmap: separate unused meta-bitmap related functions
>   blockdev: refactor block-dirty-bitmap-clear transaction
>   block/dirty-bitmap: bdrv_clear_dirty_bitmap: drop unused parameter
>   blockdev: unify block-dirty-bitmap-clear command and transaction
>     action
> 
>  include/block/block_int.h    | 14 +++++----
>  include/block/dirty-bitmap.h | 15 ++++++----
>  block/dirty-bitmap.c         | 23 +++++++++------
>  blockdev.c                   | 69 ++++++++++++++------------------------------
>  4 files changed, 54 insertions(+), 67 deletions(-)
> 

Looks good apart from some dead code still being there.

Paolo