[Qemu-devel] [PULL v2 0/9] Socket next patches

Daniel P. Berrangé posted 9 patches 6 years ago
Failed in applying to current master (apply log)
Test checkpatch failed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test s390x passed
chardev/char-socket.c          |  34 ++-
chardev/char.c                 |   3 +
include/qemu/cutils.h          |   4 +
include/qemu/sockets.h         |   1 +
io/channel-util.c              |  13 -
qapi/sockets.json              |   7 +
tests/.gitignore               |   1 +
tests/Makefile.include         |   5 +-
tests/socket-helpers.c         | 149 ++++++++++
tests/socket-helpers.h         |  42 +++
tests/test-char.c              |  47 ++-
tests/test-cutils.c            | 657 +++++++++++++++++++++++++++++++++++++++++
tests/test-io-channel-socket.c |  72 +----
tests/test-util-sockets.c      | 266 +++++++++++++++++
util/cutils.c                  | 109 +++++++
util/qemu-sockets.c            |  36 ++-
16 files changed, 1348 insertions(+), 98 deletions(-)
create mode 100644 tests/socket-helpers.c
create mode 100644 tests/socket-helpers.h
create mode 100644 tests/test-util-sockets.c
[Qemu-devel] [PULL v2 0/9] Socket next patches
Posted by Daniel P. Berrangé 6 years ago
The following changes since commit 59667bb167f773965ce6547352f312eff0d4d523:

  Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2018-03-13 14:02:47 +0000)

are available in the Git repository at:

  https://github.com/berrange/qemu tags/socket-next-pull-request

for you to fetch changes up to 0935700f8544033ebbd41e1f13cd528f8a58d24d:

  char: allow passing pre-opened socket file descriptor at startup (2018-03-13 18:06:06 +0000)

----------------------------------------------------------------

----------------------------------------------------------------

Daniel P. Berrangé (9):
  char: don't silently skip tn3270 protocol init when TLS is enabled
  cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int
    types
  sockets: pull code for testing IP availability out of specific test
  sockets: strengthen test suite IP protocol availability checks
  sockets: move fd_is_socket() into common sockets code
  sockets: check that the named file descriptor is a socket
  sockets: allow SocketAddress 'fd' to reference numeric file
    descriptors
  char: refactor parsing of socket address information
  char: allow passing pre-opened socket file descriptor at startup

 chardev/char-socket.c          |  34 ++-
 chardev/char.c                 |   3 +
 include/qemu/cutils.h          |   4 +
 include/qemu/sockets.h         |   1 +
 io/channel-util.c              |  13 -
 qapi/sockets.json              |   7 +
 tests/.gitignore               |   1 +
 tests/Makefile.include         |   5 +-
 tests/socket-helpers.c         | 149 ++++++++++
 tests/socket-helpers.h         |  42 +++
 tests/test-char.c              |  47 ++-
 tests/test-cutils.c            | 657 +++++++++++++++++++++++++++++++++++++++++
 tests/test-io-channel-socket.c |  72 +----
 tests/test-util-sockets.c      | 266 +++++++++++++++++
 util/cutils.c                  | 109 +++++++
 util/qemu-sockets.c            |  36 ++-
 16 files changed, 1348 insertions(+), 98 deletions(-)
 create mode 100644 tests/socket-helpers.c
 create mode 100644 tests/socket-helpers.h
 create mode 100644 tests/test-util-sockets.c

-- 
2.14.3


Re: [Qemu-devel] [PULL v2 0/9] Socket next patches
Posted by no-reply@patchew.org 6 years ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180313181248.16215-1-berrange@redhat.com
Subject: [Qemu-devel] [PULL v2 0/9] Socket next patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20180313171345.659672-1-eblake@redhat.com -> patchew/20180313171345.659672-1-eblake@redhat.com
 * [new tag]               patchew/20180313181248.16215-1-berrange@redhat.com -> patchew/20180313181248.16215-1-berrange@redhat.com
 t [tag update]            patchew/cover.1520952419.git.berto@igalia.com -> patchew/cover.1520952419.git.berto@igalia.com
Switched to a new branch 'test'
8f0c017d6b char: allow passing pre-opened socket file descriptor at startup
d82c3a9eae char: refactor parsing of socket address information
fe12adf7c9 sockets: allow SocketAddress 'fd' to reference numeric file descriptors
d3a939ca9c sockets: check that the named file descriptor is a socket
1ae57732b9 sockets: move fd_is_socket() into common sockets code
73cfc82063 sockets: strengthen test suite IP protocol availability checks
6ad4ad192a sockets: pull code for testing IP availability out of specific test
6b5e9d3bc1 cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int types
1dd1599b98 char: don't silently skip tn3270 protocol init when TLS is enabled

=== OUTPUT BEGIN ===
Checking PATCH 1/9: char: don't silently skip tn3270 protocol init when TLS is enabled...
Checking PATCH 2/9: cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int types...
ERROR: consider using qemu_strtoll in preference to strtoll
#753: FILE: util/cutils.c:338:
+    lresult = strtoll(nptr, &ep, base);

ERROR: consider using qemu_strtoull in preference to strtoull
#805: FILE: util/cutils.c:390:
+    lresult = strtoull(nptr, &ep, base);

total: 2 errors, 0 warnings, 794 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/9: sockets: pull code for testing IP availability out of specific test...
Checking PATCH 4/9: sockets: strengthen test suite IP protocol availability checks...
Checking PATCH 5/9: sockets: move fd_is_socket() into common sockets code...
Checking PATCH 6/9: sockets: check that the named file descriptor is a socket...
Checking PATCH 7/9: sockets: allow SocketAddress 'fd' to reference numeric file descriptors...
Checking PATCH 8/9: char: refactor parsing of socket address information...
Checking PATCH 9/9: char: allow passing pre-opened socket file descriptor at startup...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PULL v2 0/9] Socket next patches
Posted by Peter Maydell 6 years ago
On 13 March 2018 at 18:12, Daniel P. Berrangé <berrange@redhat.com> wrote:
> The following changes since commit 59667bb167f773965ce6547352f312eff0d4d523:
>
>   Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2018-03-13 14:02:47 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/berrange/qemu tags/socket-next-pull-request
>
> for you to fetch changes up to 0935700f8544033ebbd41e1f13cd528f8a58d24d:
>
>   char: allow passing pre-opened socket file descriptor at startup (2018-03-13 18:06:06 +0000)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------

Applied, thanks.

-- PMM