From nobody Fri Apr 19 09:17:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520940747531174.204147812182; Tue, 13 Mar 2018 04:32:27 -0700 (PDT) Received: from localhost ([::1]:39066 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eviAI-0003iX-Q9 for importer@patchew.org; Tue, 13 Mar 2018 07:32:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evi9Q-0003JF-EX for qemu-devel@nongnu.org; Tue, 13 Mar 2018 07:31:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evi9L-0007we-R6 for qemu-devel@nongnu.org; Tue, 13 Mar 2018 07:31:28 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:22755) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1evi9L-0007s7-Jv; Tue, 13 Mar 2018 07:31:23 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 029517456D6; Tue, 13 Mar 2018 12:31:15 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id DBFF174569F; Tue, 13 Mar 2018 12:31:14 +0100 (CET) From: BALATON Zoltan Date: Tue, 13 Mar 2018 12:26:56 +0100 To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Message-Id: <20180313113114.DBFF174569F@zero.eik.bme.hu> X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 152.66.115.2 Subject: [Qemu-devel] [PATCH v3] ppc440_pcix: Change some error_report to qemu_log_mask(LOG_UNIMP, ...) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Using log unimp is more appropriate for these messages and this also silences them by default so they won't clobber make check output when tests are added for this board. Signed-off-by: BALATON Zoltan Reviewed-by: Thomas Huth --- v3: Include qemu/log.h to avoid undeclared function warning v2: Use defined format string for printing hwaddr instead of casting. I guess this does not invalidate the R-b tag of v1 so I've added that too. hw/ppc/ppc440_pcix.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/ppc/ppc440_pcix.c b/hw/ppc/ppc440_pcix.c index ab2626a..b1307e6 100644 --- a/hw/ppc/ppc440_pcix.c +++ b/hw/ppc/ppc440_pcix.c @@ -21,6 +21,7 @@ =20 #include "qemu/osdep.h" #include "qemu/error-report.h" +#include "qemu/log.h" #include "hw/hw.h" #include "hw/ppc/ppc.h" #include "hw/ppc/ppc4xx.h" @@ -286,8 +287,9 @@ static void ppc440_pcix_reg_write4(void *opaque, hwaddr= addr, break; =20 default: - error_report("%s: unhandled PCI internal register 0x%lx", __func__, - (unsigned long)addr); + qemu_log_mask(LOG_UNIMP, + "%s: unhandled PCI internal register 0x%"HWADDR_PRIx= "\n", + __func__, addr); break; } } @@ -377,8 +379,9 @@ static uint64_t ppc440_pcix_reg_read4(void *opaque, hwa= ddr addr, break; =20 default: - error_report("%s: invalid PCI internal register 0x%lx", __func__, - (unsigned long)addr); + qemu_log_mask(LOG_UNIMP, + "%s: invalid PCI internal register 0x%" HWADDR_PRIx = "\n", + __func__, addr); val =3D 0; } =20 --=20 2.7.6