aspeed: simplify using the 'unimplemented device'

[Qemu-devel] [PATCH v2 0/2] aspeed: simplify using the 'unimplemented device'

Philippe Mathieu-Daudé posted 2 patches 6 years, 2 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180209085755.30414-1-f4bug@amsat.org

Test checkpatch passed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test docker-quick@centos6 passed

Test ppcbe passed

Test ppcle passed

Test s390x passed

include/hw/arm/aspeed_soc.h |  1 -
hw/arm/aspeed_soc.c         | 35 +++++------------------------------
2 files changed, 5 insertions(+), 31 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/2] aspeed: simplify using the 'unimplemented device'

Posted by Philippe Mathieu-Daudé 6 years, 2 months ago

Since v1:
- corrected buggy UART base address (noticed by Peter)
- tested using openbmc-build provided by Andrew
- added Cédric R-b

tested with:

  $ qemu-system-arm -M romulus-bmc -m 512 \
    -drive file=image-bmc,if=mtd,format=raw -nographic

using this image:

  https://openpower.xyz/job/openbmc-build/1240/distro=ubuntu,target=romulus/artifact/deploy/images/romulus/image-bmc

(which is a good candidate for an Avocado / pyexpect test).

Philippe Mathieu-Daudé (2):
  hw/arm/aspeed: directly map the serial device to the system address
    space
  hw/arm/aspeed: simplify using the 'unimplemented device' for
    aspeed_soc.io

 include/hw/arm/aspeed_soc.h |  1 -
 hw/arm/aspeed_soc.c         | 35 +++++------------------------------
 2 files changed, 5 insertions(+), 31 deletions(-)

-- 
2.16.1

Re: [Qemu-devel] [PATCH v2 0/2] aspeed: simplify using the 'unimplemented device'

Posted by Peter Maydell 6 years, 2 months ago

On 9 February 2018 at 08:57, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Since v1:
> - corrected buggy UART base address (noticed by Peter)
> - tested using openbmc-build provided by Andrew
> - added Cédric R-b
>
> tested with:
>
>   $ qemu-system-arm -M romulus-bmc -m 512 \
>     -drive file=image-bmc,if=mtd,format=raw -nographic
>
> using this image:
>
>   https://openpower.xyz/job/openbmc-build/1240/distro=ubuntu,target=romulus/artifact/deploy/images/romulus/image-bmc
>
> (which is a good candidate for an Avocado / pyexpect test).
>
> Philippe Mathieu-Daudé (2):
>   hw/arm/aspeed: directly map the serial device to the system address
>     space
>   hw/arm/aspeed: simplify using the 'unimplemented device' for
>     aspeed_soc.io
>
>  include/hw/arm/aspeed_soc.h |  1 -
>  hw/arm/aspeed_soc.c         | 35 +++++------------------------------
>  2 files changed, 5 insertions(+), 31 deletions(-)

Applied, thanks.

-- PMM