From nobody Fri May 3 13:54:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1518112262404927.1442948344053; Thu, 8 Feb 2018 09:51:02 -0800 (PST) Received: from localhost ([::1]:57328 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejqLd-0002tp-IB for importer@patchew.org; Thu, 08 Feb 2018 12:51:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejpto-00031j-1A for qemu-devel@nongnu.org; Thu, 08 Feb 2018 12:22:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejptm-0006g3-CG for qemu-devel@nongnu.org; Thu, 08 Feb 2018 12:22:16 -0500 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:39888) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ejptm-0006fo-8F; Thu, 08 Feb 2018 12:22:14 -0500 Received: by mail-qk0-x241.google.com with SMTP id d72so6573349qkc.6; Thu, 08 Feb 2018 09:22:14 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id l66sm253466qkf.87.2018.02.08.09.22.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2018 09:22:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gVWe93aghW5erkY99SxFziTAEOlhMJl4x7Y7R5TRllA=; b=O6xO0te6f2Fr/T7AtR2EeDbYJdNzTxikn7UdNpYg6Kkpng4ZCbqIKOtpPx0yZtbno2 k/3RBaAxGacZghirWkcMCXE2C+8siELraIEIVVTRUMFo/OCDCDgjY2Zzai+1ecD2Jc1n huKaN7vFTKoPKxQuPeYhU8i7LTgIiOKOtBMEl1D7G/dDCrCwR0YoRDKNjLYVjtDopdQv LC8603sxBPJ7TF8PfYa3eOJz/FUsLKiMotQj44uuyiCJPE7JuPTTIxZh0KtdB8kn0UTB MbRvRp9ivCfA7hXWyDrJvJMzDzLLSdw15KD0UHBpJk1hiK7uMvRf2lyvOGnhihmHAwNi mL7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=gVWe93aghW5erkY99SxFziTAEOlhMJl4x7Y7R5TRllA=; b=LNLoZ9c3pKBlmTTWCX6GvN8QFPEXRyzLJAX20dr8/WaVpFmlwBQGX7Xej57DwAhwSt HUSoNU4wVALYoRwY64uYCw1nEYdh7ubyxcHTvH5qj/KerG7kSXxUDOpN3CjiQ4gr1UyE 6EHKCTWMa7iasAEOILUKf3KeLMO80aZiCaiMpzPOwDUVb2X/X7nyi8dxgkEJqzcZ+lzT JutQGQ2n7zlSCeYqCMVmazzRTGtzPK51PmaStoJe1B/HLRA0XBcS53CdOPUh0Q/slhm8 SZupT/K/oqYvVbLuuz7s7+TUi+prrtehVjP5wdZRep7ztC812Bi2tixrDXg1x9LzDAyw B2cQ== X-Gm-Message-State: APf1xPC+XcSh6LPYKhu+mtmaSm4YnxweaUS8gIGd5da2S4X2QqRa1sUH FSOdXw5rj2vrHQknWAeLKeybgc30 X-Google-Smtp-Source: AH8x226vznlLA0F/hx8JZtf+9D4eFrTQ9TK+HdJuiubOhTWpJNxVgLwAITNjs9zp+38V8zB7DjchJQ== X-Received: by 10.55.207.152 with SMTP id v24mr2053898qkl.253.1518110533843; Thu, 08 Feb 2018 09:22:13 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Andrew Jeffery Date: Thu, 8 Feb 2018 14:22:01 -0300 Message-Id: <20180208172202.9984-2-f4bug@amsat.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180208172202.9984-1-f4bug@amsat.org> References: <20180208172202.9984-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH 1/2] hw/arm/aspeed: directly map the serial device to the system address space X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/aspeed_soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c index c83b7e207b..a786750e14 100644 --- a/hw/arm/aspeed_soc.c +++ b/hw/arm/aspeed_soc.c @@ -257,7 +257,7 @@ static void aspeed_soc_realize(DeviceState *dev, Error = **errp) /* UART - attach an 8250 to the IO space as our UART5 */ if (serial_hds[0]) { qemu_irq uart5 =3D qdev_get_gpio_in(DEVICE(&s->vic), uart_irqs[4]); - serial_mm_init(&s->iomem, ASPEED_SOC_UART_5_BASE, 2, + serial_mm_init(get_system_memory(), ASPEED_SOC_UART_5_BASE, 2, uart5, 38400, serial_hds[0], DEVICE_LITTLE_ENDIAN); } =20 --=20 2.16.1 From nobody Fri May 3 13:54:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1518111565655452.38613357389386; Thu, 8 Feb 2018 09:39:25 -0800 (PST) Received: from localhost ([::1]:56854 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejqAO-0001Ew-SM for importer@patchew.org; Thu, 08 Feb 2018 12:39:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejptq-00034Q-Dw for qemu-devel@nongnu.org; Thu, 08 Feb 2018 12:22:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejptp-0006he-Dn for qemu-devel@nongnu.org; Thu, 08 Feb 2018 12:22:18 -0500 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:47079) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ejptp-0006hF-9q; Thu, 08 Feb 2018 12:22:17 -0500 Received: by mail-qk0-x244.google.com with SMTP id d125so6555508qkg.13; Thu, 08 Feb 2018 09:22:17 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id l66sm253466qkf.87.2018.02.08.09.22.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2018 09:22:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gQPw4nj/djjsXDUAN6bIZlkV/KD0cJagKx8Sq1y0JgQ=; b=Qn5Sxrr7AZ2xTVmU//ojOo4FkOnAJAWoCu2Js/zqLqP6JEY+V/D2H/STAUoNCf+LBU 0lkQ/LtyqDGPHoJw2b2L9d6Bk5/M0DFRk7t1jH1StzaItHZYD/yG5LnB/V9LA9GSQuAm 1TElDhG+GHgyRCxFDqkNR3YtjE9wLtMvOWv+klp3Qa7QNljQxc9gMCDO8I+2vhKVBWEQ T9sTlV9nbRI0GN41vgXn4Afa5uO4UBsiU2GDGL66VvHRypD21uyTWs/5UrN4yGZDt+Y6 J60P5WPGzROYGgwRv9SUeYfYk7TwM0mVBfBAyfZbuFeQ8l6ssmGMw5i59J3I232uti4Q 7fSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=gQPw4nj/djjsXDUAN6bIZlkV/KD0cJagKx8Sq1y0JgQ=; b=Mo6HiLThdLl5PQ+H31O2K64+aGWz2/q7CoayZu8GmNZFxluC+jhYzeWCY2XMSNZF5g P1kyqMwp1TyrESpJXN9r5WpBZ/HxC/ILPTGK/OnHuzv/LeIN/TKd5YGIpI39t+01E4S2 6/My1dHpFoXYFU12vRnKu6nBll2dd23bQQ0wNG44snY968VJmKVedhpjKN/xtJN5t2jh BkT/F4vR+ec0HSYt4F4AHmwkZV1PDaOBwf1+XEvRFLbbmpJ4YQuRTHTtAwFNwVbGk6yr GPpZZ9WwRtP0Gk/vuNT8gPSrS9sunjkG+2eP6nONYYhdOe6JfYvnp4cr2HpW0j2ttmXX 5JhQ== X-Gm-Message-State: APf1xPCmhD7pa/yXhen84so2Yb8YHRBBzC8sC3iXvJb9EPdYKL6onKM5 In8H1PNSPfazJQxIiI6Pytc= X-Google-Smtp-Source: AH8x225kXvZBEyXW9KDyCzYHUDi2JTXFLvsXJnTt3BALf6WWvva8MaM7o2ykk3mCaCvWBXkXRGKo/A== X-Received: by 10.55.214.217 with SMTP id p86mr2124210qkl.252.1518110536808; Thu, 08 Feb 2018 09:22:16 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Andrew Jeffery Date: Thu, 8 Feb 2018 14:22:02 -0300 Message-Id: <20180208172202.9984-3-f4bug@amsat.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180208172202.9984-1-f4bug@amsat.org> References: <20180208172202.9984-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH 2/2] hw/arm/aspeed: simplify using the 'unimplemented device' for aspeed_soc.io X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_soc.h | 1 - hw/arm/aspeed_soc.c | 32 +++----------------------------- 2 files changed, 3 insertions(+), 30 deletions(-) diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h index f26914a2b9..11ec0179db 100644 --- a/include/hw/arm/aspeed_soc.h +++ b/include/hw/arm/aspeed_soc.h @@ -31,7 +31,6 @@ typedef struct AspeedSoCState { =20 /*< public >*/ ARMCPU cpu; - MemoryRegion iomem; MemoryRegion sram; AspeedVICState vic; AspeedTimerCtrlState timerctrl; diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c index a786750e14..3d21128d47 100644 --- a/hw/arm/aspeed_soc.c +++ b/hw/arm/aspeed_soc.c @@ -15,6 +15,7 @@ #include "qemu-common.h" #include "cpu.h" #include "exec/address-spaces.h" +#include "hw/misc/unimp.h" #include "hw/arm/aspeed_soc.h" #include "hw/char/serial.h" #include "qemu/log.h" @@ -99,31 +100,6 @@ static const AspeedSoCInfo aspeed_socs[] =3D { }, }; =20 -/* - * IO handlers: simply catch any reads/writes to IO addresses that aren't - * handled by a device mapping. - */ - -static uint64_t aspeed_soc_io_read(void *p, hwaddr offset, unsigned size) -{ - qemu_log_mask(LOG_UNIMP, "%s: 0x%" HWADDR_PRIx " [%u]\n", - __func__, offset, size); - return 0; -} - -static void aspeed_soc_io_write(void *opaque, hwaddr offset, uint64_t valu= e, - unsigned size) -{ - qemu_log_mask(LOG_UNIMP, "%s: 0x%" HWADDR_PRIx " <- 0x%" PRIx64 " [%u]= \n", - __func__, offset, value, size); -} - -static const MemoryRegionOps aspeed_soc_io_ops =3D { - .read =3D aspeed_soc_io_read, - .write =3D aspeed_soc_io_write, - .endianness =3D DEVICE_LITTLE_ENDIAN, -}; - static void aspeed_soc_init(Object *obj) { AspeedSoCState *s =3D ASPEED_SOC(obj); @@ -199,10 +175,8 @@ static void aspeed_soc_realize(DeviceState *dev, Error= **errp) Error *err =3D NULL, *local_err =3D NULL; =20 /* IO space */ - memory_region_init_io(&s->iomem, NULL, &aspeed_soc_io_ops, NULL, - "aspeed_soc.io", ASPEED_SOC_IOMEM_SIZE); - memory_region_add_subregion_overlap(get_system_memory(), - ASPEED_SOC_IOMEM_BASE, &s->iomem, = -1); + create_unimplemented_device("aspeed_soc.io", + ASPEED_SOC_IOMEM_BASE, ASPEED_SOC_IOMEM_SI= ZE); =20 /* CPU */ object_property_set_bool(OBJECT(&s->cpu), true, "realized", &err); --=20 2.16.1