From nobody Mon Apr 29 19:42:16 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1517493090170592.1150671996935; Thu, 1 Feb 2018 05:51:30 -0800 (PST) Received: from localhost ([::1]:37845 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehFGz-0003g5-Eg for importer@patchew.org; Thu, 01 Feb 2018 08:51:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehFEO-0001sz-Kj for qemu-devel@nongnu.org; Thu, 01 Feb 2018 08:48:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehFEM-0006V6-34 for qemu-devel@nongnu.org; Thu, 01 Feb 2018 08:48:48 -0500 Received: from mail-eopbgr30105.outbound.protection.outlook.com ([40.107.3.105]:60643 helo=EUR03-AM5-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ehFEK-0006Tr-RT for qemu-devel@nongnu.org; Thu, 01 Feb 2018 08:48:46 -0500 Received: from localhost.sw.ru (195.214.232.6) by DB6PR0801MB2072.eurprd08.prod.outlook.com (2603:10a6:4:77::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Thu, 1 Feb 2018 13:48:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=s2j4FgketYLzYT0jthiyg9B3SC9nuun5sfZw3fOuiXM=; b=R/onYc/jvvja5pPkTIZzV+s+ZjuqIBC8ygOTzV5lfHBRncK1Id/vr62Y7V6R3wCnJtHlaRtOJz9ePifbNSzWil3/qbc8ZKPeslVoyGmad1P53GTfTJWzl1KhlrwgPpkpC9jLzd3JszCGvpgQD+eo63J7xV8KrJpB1SLPeNzm7ek= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=klim.kireev@virtuozzo.com; From: Klim Kireev To: qemu-devel@nongnu.org Date: Thu, 1 Feb 2018 16:48:31 +0300 Message-Id: <20180201134831.17709-1-klim.kireev@virtuozzo.com> X-Mailer: git-send-email 2.14.3 MIME-Version: 1.0 X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1P189CA0034.EURP189.PROD.OUTLOOK.COM (2603:10a6:7:53::47) To DB6PR0801MB2072.eurprd08.prod.outlook.com (2603:10a6:4:77::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b58b3f7e-3da2-4bcf-b551-08d5697a80e2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB6PR0801MB2072; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0801MB2072; 3:eLys2xdbvxCrw+SrziTzMLrKc91Nj4G7hDyUSvHlXoPNwgPvogKAFalVIOZVgil/Wlv74s5I2jvzdw70wJihlZIRNG6d5sx6MYVijrVoA1MYAxAdbltA9MAru5E1k/VwRsbvvLSaOWXaP/ML9OlED3ujIoorHnUBdSA2XKCODNq+wzJWki05nKI2eSl3let/HRT4Zxm4L3BtaMT7rwFQnarJbDxyY/OEGIJPDQOVN0PrRAtbRcFXGNVHDB0D++Ot; 25:uCFeyvCrsVg6ileB50Ah0V/TMa2cgRdaSxD64ejepdeJuoFpcdy3fsNh5Rwo/TZj5zFvIrxqdPelHZ1TP4bq5c55oIK6N4ICLai0UlhF3dQcV40F18kaqtHp5lJXSeyLf6/mDFu0JMm0OluagXYGlMZPPwjjj4WtmHM3CSjlaH58UtMvX5xPwIm0RpNkn7OWCNb3PHUGK2g3a84N0B8K7QnLxCHWZRY/lGXztQrzRQw96GmQ8pPUi5Gxji4kKHZlDaA6FY6hFvcz/kVMxu6FD04IDH7SqmQCBJDvdkKYhDJswMDYqP1iVtig2rDxHbnINZkS0n8Ym90X25V17J2N/g==; 31:eoV0aWd4WSfuypLSkq26iVQA5ZgwvYjXCqxzsgQ12Ma3YuwhMBHMpeEUTI+o16Dl+9hyuu89vWKAQxVtwBIKbq6zmCcPQh/oLuXYSjxsVIcfKeeqIs15wF8USxv5cCJPjsfhx2BX4fJjJHs0lZE+Q7HT0GZLsGRkAIWd0CV9zEIbQMDY/6rtPHzXasdiu5x+AJ3AsjPXyyNCyWb9vbYS8Sdgc8EXrIWWHqjLrCGkltY= X-MS-TrafficTypeDiagnostic: DB6PR0801MB2072: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0801MB2072; 20:0FnWEJVckCHXtJtEhEC9AY5uHVJ2Yyw56EV3Ofxb/Z/OJ5oF2/b5Su/FLgwgxk1VZFlidMV8rp6Lq3+W8dqkENQY1MBL8NzTnuVdBJEfsQW6u5DNxZ60SDtOnMukXT6bvktIEx9q4rLgjZ3o3ePra2ivOQj1TBHJpHCY88uR5JEx6Erw+GsYqf06+q/nGI34ggvD4iheiWplcVIZj6EdbtMTUeZKRmphtTHCE9VKNsVr4+5o8dFPfUoLaL92PJE5vvGScuTjuT1iufZdWQ200r/EDfj6/Fv/REG0xhMTuylTS0St/QLW12Tu0yxAgQy8tWIxrrsRbVi3gmXBwKtfZoEIm8FDgf7K3jb4k9zCJ07u4jvqtXQ5acsP/6HlZu7S2QFUvZQXFkokuFdmJ+GNq83Q4LSMvwy7Ju9aVOvuqyg=; 4:o0nmPiwAsQahP6OQM6rbMxYWjN60VT687c2f333k9DwIMiLW/J9+6ihFW628Oh4gjFQoyguD+knW9AN+y0DHU3QFXzxILouC5EvlZtQbbMe3rNQyWaOSgPR8KnMv5jDMA9MVdD0RG/nZgRseC6YtSWOtGFtyQr7h5H2ThN3Fof9IrTzFf8DQJ3635iJmiNgoq9u35Je4TGMCj6N5Z66t4XElgZDwfBj2pGtxXHxoqDT1Wou9jijdAQ3DW870RsZ6tsXJUpBsbGnWp3/QK5Eacg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231101)(2400082)(944501161)(6041288)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:DB6PR0801MB2072; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0801MB2072; X-Forefront-PRVS: 0570F1F193 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(979002)(6069001)(376002)(39380400002)(346002)(39850400004)(366004)(396003)(189003)(199004)(6486002)(51416003)(69596002)(59450400001)(68736007)(25786009)(76506005)(53936002)(186003)(3846002)(6116002)(1076002)(48376002)(36756003)(53416004)(50466002)(52116002)(86362001)(16526019)(5660300001)(16586007)(97736004)(66066001)(6916009)(478600001)(55236004)(81166006)(6512007)(47776003)(2361001)(2906002)(8676002)(2351001)(106356001)(81156014)(316002)(50226002)(105586002)(8936002)(7736002)(305945005)(386003)(6506007)(4326008)(6666003)(26005)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1102; SCL:1; SRVR:DB6PR0801MB2072; H:localhost.sw.ru; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0801MB2072; 23:d+JkHa7FH26tVusUV2NIv2sShDf/yLrOPgOs5Fn?= =?us-ascii?Q?jhBi2suvxWDCIy8CB4J61PTgpXjU8+rlnNSFbYcCc3oN1vH9kydshqWf/Eol?= =?us-ascii?Q?s0K/yInhq4sUTL+Rlp9gqBa8PsxG5NEQaR2XEMH+e8hxDgF7eFosWzKAubXZ?= =?us-ascii?Q?be84vpv39GttKxxO64RYGfJyQ9K2Hm3REf+h9ZQH8TVg/rMHXMVs22V/LkKL?= =?us-ascii?Q?js3Q8XaRFEyi4Sj6POTiAHPxlkCGw4IrF08D7+YgR9NXMFBmKBVbt/xhUGNh?= =?us-ascii?Q?qTpA/ianUJVkcAea+C+Znz2CQvrEhqT4uKj/nA+oPpXcQ6yW4PoCoLh3dsr5?= =?us-ascii?Q?Gkm+uQpMbsaRkm+c+wm/e33xiCXNFHBrkAmt1EEJz7TV+nEgZDNwFUSzUTtt?= =?us-ascii?Q?b7lqjIObp4KusnsIIEYtbKkwjOFXQrg4nlf0EKRII3kWsPr/zpw09Tu9FEyv?= =?us-ascii?Q?2AJPOzyVU0FGvnapADR0nzoC36uPrisco0wB5q6W/HJ+BZkOXpn73YE1/+wJ?= =?us-ascii?Q?a7+K9NqHDRr1kWppssfTd2kBC5LtymcV0fK3jXQx1xCh0LZQqNiClmPuHzUj?= =?us-ascii?Q?hliT390Uh0Kvtj+0bzCe2lEOdq8g1Mm4lOhr8x/Pt8QP+4bpg2ZUblipyg6f?= =?us-ascii?Q?vm8q5a8ozWG4rMayQ22Wz8pCiPvTWrW8cNV5ihVuCucbKkgWLNE8UZngiD/R?= =?us-ascii?Q?/S8OHJvDTKMnsqPR1t3qLqtt6Kkly791PjJturkCKZ9ggzEWpRG6aewNES8Z?= =?us-ascii?Q?UbHMKWVyu7hTVYwyL/JJtbzpuyS3whK/RbmccY55JRW21wBRgzGfFb0Ogqsl?= =?us-ascii?Q?SjOOElEMJC9Q0H/543RNzqeQUyolQojZ3jdpNSCmdxf6od81pIxEeD266dNh?= =?us-ascii?Q?QIG6l9zDuUVPDumKABTK3+sFqNljiqgIyV7cQUraoqHzI9b5PStUsxtObCfs?= =?us-ascii?Q?iLYfZunLc6xxfo0Dyse+8JpU6JdN6pbPKYFb0eBKoJIb75XCcKA9atcwNj8n?= =?us-ascii?Q?O1Tn9HvuBEG7N0RMy7JW6+jCEbD54gZu7ARLvLX1bwePqaLPjNu7ij/GBwYV?= =?us-ascii?Q?mkvFJj1+zfaOemJFMKrtOA8rHtzcPoHkTLgbnloo5UylDLVk7ZLUNZxs9Gms?= =?us-ascii?Q?OhgP9bGeWH0dh1mK6GeUtClu8r3tZGK3JaEhBtvA3d05/FUzN66dFEeVc+tw?= =?us-ascii?Q?X52jUE/xnV+4LNDh1vYwDgtglYh7pLJ7XPbxwetBwo+DGYOGcgW0zUW8+X1V?= =?us-ascii?Q?Eb7QGV+px3JiBYUWDpq8At3OTPvd8jF+HdRgOg4yPV0+5sC6db1IgwHnCShx?= =?us-ascii?Q?LeHmQhNJoDDBfdYgB7Vxe2UuPxeDYS1fF+uE1V9Ehto8p?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0801MB2072; 6:2/jHLZbLSV/kR1GGY/6Dro9eK0wD+5iZdgtiPl5K3M043gHvA7s7MfMcAHbhvLcdypUoz9cUU/aDgiaVK1dUqe5QugCZbEaGKh8Y/Zh5wcoJ6J/WzHkkQtgHni9CYq/C7Kip1j7fJQ/RC6a08zWcCn+JGShZLxfNVIo/cued5RcC27GVJ3A+E/3biC81c80nQjGCIQkj/k8GBNMXXc3nE792Ia/oxBGEzAk60850IcM+iTFOPSQp/xowgfHXyIPMR0Z5eUGjV/WJOEtnDvYf9jMX62mOEI7Xqrvvo7cqyxj2Hfn9oDPalZNFs0iK93bPBOIzh8LrQ8yd6Dw8Ls5iGbWshBQybkJNtS2n85yHGC8=; 5:MW2ujfrkRqOt0F8DiaEkjP5uXw6m7uPeB2T/Ct7xuRnnWVHp2kJHe0uF9dT6KmVfkC0Ym5w4ZbCD1PIQdpRZd1BVPWE51s8jvntcY8Nw/bZvGTNjcwMiabKvoYvCTIyiOQ/XhXxCYYRUqY3tNJHzpaaAWKCGbsAuTNT9iQoex6M=; 24:tmZ0D8mVgSkTi6SFyv1ihSrQGeJsEV1GX0sTwn9VFahg2tXkPCFPLVZoffJYLiZ+jN9otobMxC9Ibqt3StU5OPIzHGR20Onx+N74DxWxWXo=; 7:oOThsGwloiXH9+mWrc6U85ICu6woesJudSb1cUf69hqPP8fAxjeetiWbLbVlFuV6pBK5nv+Sv0O2Nzl+D7q6ZxSyPYYTXFPW5M5Px5BjxQj/7BogPVgf2pNRUrMrc98OTuNsHcSzs0wl32rhGX8kY9Jn/xp9NFIjSlaA0QY0nsSxSceGcQgQ+y8Y9vMaAEduX7E3vATLL80fTlMmJkPvbxTJdd9ETYOCs8YAoiykQtOUMnjiUNBBOvibVkosxAp6 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB6PR0801MB2072; 20:f4z0CcyhSZx+0VQDRV8EiSAxj9zW3xcr7Luard2BzNgFmKQpvUA3BAtWfilyjSMl84XDti7Iw78RKJYvM8WXO54BNOo8lgV2Cl06E7kK5svnRGKLQtkGRJKxt/NiOWuPu7RxrQWUwshe05CGGIlQ6rg9ht6mfg07nknOYDwuc6M= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2018 13:48:40.8154 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b58b3f7e-3da2-4bcf-b551-08d5697a80e2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2072 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.3.105 Subject: [Qemu-devel] [PATCH] tests/test-filter-redirector: move close() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@redhat.com, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since we have separate handler on POLLHUP, which drops data after closing the connection we need to fix this test, because it sends data and instantly close the socket creating race condition. In some cases on other end of socket client closes it faster than reads data. To prevent it I suggest to close socket after recieving. Signed-off-by: Klim Kireev --- tests/test-filter-redirector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-filter-redirector.c b/tests/test-filter-redirector.c index f2566144cf..fbaf19bbd8 100644 --- a/tests/test-filter-redirector.c +++ b/tests/test-filter-redirector.c @@ -186,7 +186,6 @@ static void test_redirector_rx(void) =20 ret =3D iov_send(send_sock, iov, 2, 0, sizeof(size) + sizeof(send_buf)= ); g_assert_cmpint(ret, =3D=3D, sizeof(send_buf) + sizeof(size)); - close(send_sock); =20 ret =3D qemu_recv(backend_sock[0], &len, sizeof(len), 0); g_assert_cmpint(ret, =3D=3D, sizeof(len)); @@ -197,6 +196,7 @@ static void test_redirector_rx(void) ret =3D qemu_recv(backend_sock[0], recv_buf, len, 0); g_assert_cmpstr(recv_buf, =3D=3D, send_buf); =20 + close(send_sock); g_free(recv_buf); unlink(sock_path0); unlink(sock_path1); --=20 2.14.3