From nobody Sun Apr 28 16:16:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1517483973625710.0626649104743; Thu, 1 Feb 2018 03:19:33 -0800 (PST) Received: from localhost ([::1]:56815 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehCtw-0006IA-LO for importer@patchew.org; Thu, 01 Feb 2018 06:19:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehCqq-0004kJ-2A for qemu-devel@nongnu.org; Thu, 01 Feb 2018 06:16:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehCql-0003cr-BH for qemu-devel@nongnu.org; Thu, 01 Feb 2018 06:16:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43254) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ehCql-0003cU-5a for qemu-devel@nongnu.org; Thu, 01 Feb 2018 06:16:15 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 835FB25770; Thu, 1 Feb 2018 11:16:14 +0000 (UTC) Received: from localhost (ovpn-112-22.ams2.redhat.com [10.36.112.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id E210560BF3; Thu, 1 Feb 2018 11:16:10 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Thu, 1 Feb 2018 12:16:05 +0100 Message-Id: <20180201111605.7392-2-marcandre.lureau@redhat.com> In-Reply-To: <20180201111605.7392-1-marcandre.lureau@redhat.com> References: <20180201111605.7392-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 01 Feb 2018 11:16:14 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 1/1] dump-guest-memory.py: skip vmcoreinfo section if not available X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Cleber Rosa , Eduardo Habkost , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" On some architectures, qemu doesn't support vmcoreinfo device, and dump-guest-memory fails: (gdb) dump-guest-memory /tmp/vmcore ppc64-le guest RAM blocks: target_start target_end host_addr message count Reviewed-by: Laszlo Ersek ---------------- ---------------- ---------------- ------- ----- 0000000000000000 0000000200000000 00003ffd86980000 added 1 0000200080000000 0000200080800000 00003ffd86170000 added 2 Python Exception No symbol "vmcoreinfo_realize" in curr= ent context.: Error occurred in Python command: No symbol "vmcoreinfo_realize" in current= context. Check that vmcoreinfo_realize symbol exists before evaluating an expression with it. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Laszlo Ersek --- scripts/dump-guest-memory.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py index 03fbf69f8a..51acfcd0c0 100644 --- a/scripts/dump-guest-memory.py +++ b/scripts/dump-guest-memory.py @@ -546,6 +546,8 @@ shape and this command should mostly work.""" return None =20 def add_vmcoreinfo(self): + if gdb.lookup_symbol("vmcoreinfo_realize")[0] is None: + return vmci =3D 'vmcoreinfo_realize::vmcoreinfo_state' if not gdb.parse_and_eval("%s" % vmci) \ or not gdb.parse_and_eval("(%s)->has_vmcoreinfo" % vmci): --=20 2.16.0.rc1.1.gef27df75a1