[Qemu-devel] [PATCH] Add a git-publish configuration file

Fam Zheng posted 1 patch 6 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180131053318.13109-1-famz@redhat.com
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test ppc passed
Test s390x passed
.gitpublish | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 57 insertions(+)
create mode 100644 .gitpublish
[Qemu-devel] [PATCH] Add a git-publish configuration file
Posted by Fam Zheng 6 years, 2 months ago
git-publish [1] is a convenient tool to send patches and has been
popular among QEMU developers.  Recently it has been made available in
Fedora official repo thanks to Stefan's work.

One nice feature of the tool is a per-project configuration with
profiles, especially in which the cccmd option is a handy method to
create the Cc list.

[1]: https://github.com/stefanha/git-publish

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 .gitpublish | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 57 insertions(+)
 create mode 100644 .gitpublish

diff --git a/.gitpublish b/.gitpublish
new file mode 100644
index 0000000000..2099c1520f
--- /dev/null
+++ b/.gitpublish
@@ -0,0 +1,57 @@
+#
+# Common git-publish profiles that can be used to send patches to QEMU upstream.
+#
+# See https://github.com/stefanha/git-publish for more information
+#
+[gitpublishprofile "qemu"]
+base = master
+prefix = PATCH
+to = qemu-devel@nongnu.org
+cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
+
+[gitpublishprofile "qemu-rfc"]
+base = master
+prefix = RFC PATCH
+to = qemu-devel@nongnu.org
+cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
+
+[gitpublishprofile "qemu-stable"]
+base = master
+prefix = PATCH
+to = qemu-devel@nongnu.org
+cc = qemu-stable@nongnu.org
+cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
+
+[gitpublishprofile "qemu-trivial"]
+base = master
+prefix = PATCH
+to = qemu-devel@nongnu.org
+cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
+
+[gitpublishprofile "qemu-block"]
+base = master
+prefix = PATCH
+to = qemu-devel@nongnu.org
+cc = qemu-block@nongnu.org
+cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
+
+[gitpublishprofile "qemu-arm"]
+base = master
+prefix = PATCH
+to = qemu-devel@nongnu.org
+cc = qemu-arm@nongnu.org
+cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
+
+[gitpublishprofile "qemu-s390"]
+base = master
+prefix = PATCH
+to = qemu-devel@nongnu.org
+cc = qemu-s390@nongnu.org
+cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
+
+[gitpublishprofile "qemu-ppc"]
+base = master
+prefix = PATCH
+to = qemu-devel@nongnu.org
+cc = qemu-pcc@nongnu.org
+cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
-- 
2.14.3


Re: [Qemu-devel] [PATCH] Add a git-publish configuration file
Posted by Marc-André Lureau 6 years, 2 months ago
Hi

On Wed, Jan 31, 2018 at 6:33 AM, Fam Zheng <famz@redhat.com> wrote:
> git-publish [1] is a convenient tool to send patches and has been
> popular among QEMU developers.  Recently it has been made available in
> Fedora official repo thanks to Stefan's work.
>
> One nice feature of the tool is a per-project configuration with
> profiles, especially in which the cccmd option is a handy method to
> create the Cc list.
>
> [1]: https://github.com/stefanha/git-publish

It would be worth to update README "Submitting patches" with an example
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  .gitpublish | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
>  create mode 100644 .gitpublish
>
> diff --git a/.gitpublish b/.gitpublish
> new file mode 100644
> index 0000000000..2099c1520f
> --- /dev/null
> +++ b/.gitpublish
> @@ -0,0 +1,57 @@
> +#
> +# Common git-publish profiles that can be used to send patches to QEMU upstream.
> +#
> +# See https://github.com/stefanha/git-publish for more information
> +#
> +[gitpublishprofile "qemu"]
> +base = master
> +prefix = PATCH
> +to = qemu-devel@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> +
> +[gitpublishprofile "qemu-rfc"]
> +base = master
> +prefix = RFC PATCH
> +to = qemu-devel@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> +
> +[gitpublishprofile "qemu-stable"]
> +base = master
> +prefix = PATCH
> +to = qemu-devel@nongnu.org
> +cc = qemu-stable@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> +
> +[gitpublishprofile "qemu-trivial"]
> +base = master
> +prefix = PATCH
> +to = qemu-devel@nongnu.org

cc qemu-trivial@nongnu.org ?

> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> +
> +[gitpublishprofile "qemu-block"]
> +base = master
> +prefix = PATCH
> +to = qemu-devel@nongnu.org
> +cc = qemu-block@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> +
> +[gitpublishprofile "qemu-arm"]
> +base = master
> +prefix = PATCH
> +to = qemu-devel@nongnu.org
> +cc = qemu-arm@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> +
> +[gitpublishprofile "qemu-s390"]
> +base = master
> +prefix = PATCH
> +to = qemu-devel@nongnu.org
> +cc = qemu-s390@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> +
> +[gitpublishprofile "qemu-ppc"]
> +base = master
> +prefix = PATCH
> +to = qemu-devel@nongnu.org
> +cc = qemu-pcc@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> --
> 2.14.3
>
>



-- 
Marc-André Lureau

Re: [Qemu-devel] [PATCH] Add a git-publish configuration file
Posted by Stefan Hajnoczi 6 years, 2 months ago
On Wed, Jan 31, 2018 at 11:06:05AM +0100, Marc-André Lureau wrote:
> Hi
> 
> On Wed, Jan 31, 2018 at 6:33 AM, Fam Zheng <famz@redhat.com> wrote:
> > git-publish [1] is a convenient tool to send patches and has been
> > popular among QEMU developers.  Recently it has been made available in
> > Fedora official repo thanks to Stefan's work.
> >
> > One nice feature of the tool is a per-project configuration with
> > profiles, especially in which the cccmd option is a handy method to
> > create the Cc list.
> >
> > [1]: https://github.com/stefanha/git-publish
> 
> It would be worth to update README "Submitting patches" with an example

Good idea!

The workflow for a new patch series is:

  $ git checkout -b my-feature
  ...work on feature...
  $ git publish

Your patch series has been tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

  $ git checkout my-feature # same topic branch
  ...work on feature...
  $ git publish

Your patch series has been tagged as my-feature-v2.

> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  .gitpublish | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 57 insertions(+)
> >  create mode 100644 .gitpublish
> >
> > diff --git a/.gitpublish b/.gitpublish
> > new file mode 100644
> > index 0000000000..2099c1520f
> > --- /dev/null
> > +++ b/.gitpublish
> > @@ -0,0 +1,57 @@
> > +#
> > +# Common git-publish profiles that can be used to send patches to QEMU upstream.
> > +#
> > +# See https://github.com/stefanha/git-publish for more information
> > +#
> > +[gitpublishprofile "qemu"]

Please rename the "qemu" profile to "default".  This way no --profile
needs to be given:

  $ git publish

The default profile settings can be overridden by command-line options
and branch-specific settings.
Re: [Qemu-devel] [PATCH] Add a git-publish configuration file
Posted by Fam Zheng 6 years, 2 months ago
On Thu, Feb 1, 2018 at 6:46 PM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> On Wed, Jan 31, 2018 at 11:06:05AM +0100, Marc-André Lureau wrote:
>> Hi
>>
>> On Wed, Jan 31, 2018 at 6:33 AM, Fam Zheng <famz@redhat.com> wrote:
>> > git-publish [1] is a convenient tool to send patches and has been
>> > popular among QEMU developers.  Recently it has been made available in
>> > Fedora official repo thanks to Stefan's work.
>> >
>> > One nice feature of the tool is a per-project configuration with
>> > profiles, especially in which the cccmd option is a handy method to
>> > create the Cc list.
>> >
>> > [1]: https://github.com/stefanha/git-publish
>>
>> It would be worth to update README "Submitting patches" with an example
>
> Good idea!
>
> The workflow for a new patch series is:
>
>   $ git checkout -b my-feature
>   ...work on feature...
>   $ git publish
>
> Your patch series has been tagged as my-feature-v1 if you need to refer
> back to it in the future.
>
> Sending v2:
>
>   $ git checkout my-feature # same topic branch
>   ...work on feature...
>   $ git publish
>
> Your patch series has been tagged as my-feature-v2.

Will add a paragraph in README.

>
>> >
>> > Signed-off-by: Fam Zheng <famz@redhat.com>
>> > ---
>> >  .gitpublish | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> >  1 file changed, 57 insertions(+)
>> >  create mode 100644 .gitpublish
>> >
>> > diff --git a/.gitpublish b/.gitpublish
>> > new file mode 100644
>> > index 0000000000..2099c1520f
>> > --- /dev/null
>> > +++ b/.gitpublish
>> > @@ -0,0 +1,57 @@
>> > +#
>> > +# Common git-publish profiles that can be used to send patches to QEMU upstream.
>> > +#
>> > +# See https://github.com/stefanha/git-publish for more information
>> > +#
>> > +[gitpublishprofile "qemu"]
>
> Please rename the "qemu" profile to "default".  This way no --profile
> needs to be given:
>
>   $ git publish
>
> The default profile settings can be overridden by command-line options
> and branch-specific settings.

Yes, good idea.

Fam

Re: [Qemu-devel] [PATCH] Add a git-publish configuration file
Posted by Fam Zheng 6 years, 2 months ago
On Wed, Jan 31, 2018 at 6:06 PM, Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
> Hi
>
> On Wed, Jan 31, 2018 at 6:33 AM, Fam Zheng <famz@redhat.com> wrote:
>> git-publish [1] is a convenient tool to send patches and has been
>> popular among QEMU developers.  Recently it has been made available in
>> Fedora official repo thanks to Stefan's work.
>>
>> One nice feature of the tool is a per-project configuration with
>> profiles, especially in which the cccmd option is a handy method to
>> create the Cc list.
>>
>> [1]: https://github.com/stefanha/git-publish
>
> It would be worth to update README "Submitting patches" with an example

Good idea. Thanks for reviewing!


>>
>> Signed-off-by: Fam Zheng <famz@redhat.com>
>> ---
>>  .gitpublish | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 57 insertions(+)
>>  create mode 100644 .gitpublish
>>
>> diff --git a/.gitpublish b/.gitpublish
>> new file mode 100644
>> index 0000000000..2099c1520f
>> --- /dev/null
>> +++ b/.gitpublish
>> @@ -0,0 +1,57 @@
>> +#
>> +# Common git-publish profiles that can be used to send patches to QEMU upstream.
>> +#
>> +# See https://github.com/stefanha/git-publish for more information
>> +#
>> +[gitpublishprofile "qemu"]
>> +base = master
>> +prefix = PATCH
>> +to = qemu-devel@nongnu.org
>> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
>> +
>> +[gitpublishprofile "qemu-rfc"]
>> +base = master
>> +prefix = RFC PATCH
>> +to = qemu-devel@nongnu.org
>> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
>> +
>> +[gitpublishprofile "qemu-stable"]
>> +base = master
>> +prefix = PATCH
>> +to = qemu-devel@nongnu.org
>> +cc = qemu-stable@nongnu.org
>> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
>> +
>> +[gitpublishprofile "qemu-trivial"]
>> +base = master
>> +prefix = PATCH
>> +to = qemu-devel@nongnu.org
>
> cc qemu-trivial@nongnu.org ?

Good catch, I must have deleted it by mistake.

Fam

Re: [Qemu-devel] [PATCH] Add a git-publish configuration file
Posted by John Snow 6 years, 2 months ago

On 01/31/2018 12:33 AM, Fam Zheng wrote:
> git-publish [1] is a convenient tool to send patches and has been
> popular among QEMU developers.  Recently it has been made available in
> Fedora official repo thanks to Stefan's work.
> 
> One nice feature of the tool is a per-project configuration with
> profiles, especially in which the cccmd option is a handy method to
> create the Cc list.
> 
> [1]: https://github.com/stefanha/git-publish
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  .gitpublish | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
>  create mode 100644 .gitpublish
> 
> diff --git a/.gitpublish b/.gitpublish
> new file mode 100644
> index 0000000000..2099c1520f
> --- /dev/null
> +++ b/.gitpublish
> @@ -0,0 +1,57 @@
> +#
> +# Common git-publish profiles that can be used to send patches to QEMU upstream.
> +#
> +# See https://github.com/stefanha/git-publish for more information
> +#
> +[gitpublishprofile "qemu"]
> +base = master
> +prefix = PATCH
> +to = qemu-devel@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> +
> +[gitpublishprofile "qemu-rfc"]
> +base = master
> +prefix = RFC PATCH
> +to = qemu-devel@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> +
> +[gitpublishprofile "qemu-stable"]
> +base = master
> +prefix = PATCH
> +to = qemu-devel@nongnu.org
> +cc = qemu-stable@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> +
> +[gitpublishprofile "qemu-trivial"]
> +base = master
> +prefix = PATCH
> +to = qemu-devel@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> +
> +[gitpublishprofile "qemu-block"]
> +base = master
> +prefix = PATCH
> +to = qemu-devel@nongnu.org
> +cc = qemu-block@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> +
> +[gitpublishprofile "qemu-arm"]
> +base = master
> +prefix = PATCH
> +to = qemu-devel@nongnu.org
> +cc = qemu-arm@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> +
> +[gitpublishprofile "qemu-s390"]
> +base = master
> +prefix = PATCH
> +to = qemu-devel@nongnu.org
> +cc = qemu-s390@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> +
> +[gitpublishprofile "qemu-ppc"]
> +base = master
> +prefix = PATCH
> +to = qemu-devel@nongnu.org
> +cc = qemu-pcc@nongnu.org
> +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null
> 

Awesome!!