sii3112: Change angle brackets to quotes in #include lines

[Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines

Posted by BALATON Zoltan 6 years, 2 months ago

This matches what other files do for qemu includes

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/ide/sii3112.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c
index 17aa930..e3896c6 100644
--- a/hw/ide/sii3112.c
+++ b/hw/ide/sii3112.c
@@ -12,8 +12,8 @@
  * http://wiki.osdev.org/User:Quok/Silicon_Image_Datasheets
  */
 
-#include <qemu/osdep.h>
-#include <hw/ide/pci.h>
+#include "qemu/osdep.h"
+#include "hw/ide/pci.h"
 #include "trace.h"
 
 #define TYPE_SII3112_PCI "sii3112"
-- 
2.7.6

Re: [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines

Posted by Peter Maydell 6 years, 2 months ago

On 30 January 2018 at 13:10, BALATON Zoltan <balaton@eik.bme.hu> wrote:
> This matches what other files do for qemu includes
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

Re: [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines

Posted by David Gibson 6 years, 2 months ago

On Tue, Jan 30, 2018 at 02:10:10PM +0100, BALATON Zoltan wrote:
> This matches what other files do for qemu includes
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

Applied, thanks.

> ---
>  hw/ide/sii3112.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c
> index 17aa930..e3896c6 100644
> --- a/hw/ide/sii3112.c
> +++ b/hw/ide/sii3112.c
> @@ -12,8 +12,8 @@
>   * http://wiki.osdev.org/User:Quok/Silicon_Image_Datasheets
>   */
>  
> -#include <qemu/osdep.h>
> -#include <hw/ide/pci.h>
> +#include "qemu/osdep.h"
> +#include "hw/ide/pci.h"
>  #include "trace.h"
>  
>  #define TYPE_SII3112_PCI "sii3112"

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines

Posted by BALATON Zoltan 6 years, 2 months ago

On Wed, 31 Jan 2018, David Gibson wrote:
> On Tue, Jan 30, 2018 at 02:10:10PM +0100, BALATON Zoltan wrote:
>> This matches what other files do for qemu includes
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>
> Applied, thanks.

Thanks but Markus instead included this in his cleanup patches here:
http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg00075.html
so you can drop this from your tree now.

Regards,
BALATON Zoltan

Re: [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines

Posted by David Gibson 6 years, 2 months ago

On Thu, Feb 01, 2018 at 12:51:04PM +0100, BALATON Zoltan wrote:
> On Wed, 31 Jan 2018, David Gibson wrote:
> > On Tue, Jan 30, 2018 at 02:10:10PM +0100, BALATON Zoltan wrote:
> > > This matches what other files do for qemu includes
> > > 
> > > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> > 
> > Applied, thanks.
> 
> Thanks but Markus instead included this in his cleanup patches here:
> http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg00075.html
> so you can drop this from your tree now.

Ok, done.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson