[v5] vfio-pci: Allow mmap of MSIX BAR

[Qemu-devel] [PATCH qemu v5 0/2] vfio-pci: Allow mmap of MSIX BAR

Alexey Kardashevskiy posted 2 patches 6 years, 2 months ago

Diff against v6 v7
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180130035527.47336-1-aik@ozlabs.ru

Test checkpatch failed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test docker-quick@centos6 passed

Test ppc passed

Test s390x passed

There is a newer version of this series

include/hw/vfio/vfio-common.h |  2 ++
linux-headers/linux/vfio.h    |  5 +++
hw/ppc/spapr.c                |  7 ++++
hw/vfio/common.c              | 74 +++++++++++++++++++++++++++++++++++++++----
hw/vfio/pci.c                 | 11 +++++++
5 files changed, 92 insertions(+), 7 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH qemu v5 0/2] vfio-pci: Allow mmap of MSIX BAR

Posted by Alexey Kardashevskiy 6 years, 2 months ago

This is to enable MSIX BAR mapping to the guest and by the same time
avoid failing on p2p DMA mappings. This attempt makes a try to
separate p2p handling from msix.


This is based on sha1
a6506a9 Suraj Jitindar Singh "target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS".

Please comment. Thanks.



Alexey Kardashevskiy (2):
  vfio/common: Add 'p2p' property to enable DMA mapping of MMIO regions
  RFC: vfio-pci: Allow mmap of MSIX BAR

 include/hw/vfio/vfio-common.h |  2 ++
 linux-headers/linux/vfio.h    |  5 +++
 hw/ppc/spapr.c                |  7 ++++
 hw/vfio/common.c              | 74 +++++++++++++++++++++++++++++++++++++++----
 hw/vfio/pci.c                 | 11 +++++++
 5 files changed, 92 insertions(+), 7 deletions(-)

-- 
2.11.0

Re: [Qemu-devel] [PATCH qemu v5 0/2] vfio-pci: Allow mmap of MSIX BAR

Posted by no-reply@patchew.org 6 years, 2 months ago

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180130035527.47336-1-aik@ozlabs.ru
Subject: [Qemu-devel] [PATCH qemu v5 0/2] vfio-pci: Allow mmap of MSIX BAR

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
261b4a1327 RFC: vfio-pci: Allow mmap of MSIX BAR
efd447736c vfio/common: Add 'p2p' property to enable DMA mapping of MMIO regions

=== OUTPUT BEGIN ===
Checking PATCH 1/2: vfio/common: Add 'p2p' property to enable DMA mapping of MMIO regions...
ERROR: line over 90 characters
#59: FILE: hw/vfio/common.c:523:
+            error_report("Region %"HWADDR_PRIx"..%"HWADDR_PRIx" is not aligned to %"HWADDR_PRIx" and cannot be mapped for DMA",

total: 1 errors, 0 warnings, 105 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: RFC: vfio-pci: Allow mmap of MSIX BAR...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org