tracetool: Fix ust tracepoint issues

[Qemu-devel] [PATCH 0/2] tracetool: Fix ust tracepoint issues

Jon Emil Jahren posted 2 patches 6 years, 2 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180129041648.30884-1-jonemilj@gmail.com

Test checkpatch passed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test docker-quick@centos6 passed

Test ppc passed

Test s390x passed

scripts/tracetool/__init__.py            | 5 +++--
scripts/tracetool/format/ust_events_h.py | 3 ++-
2 files changed, 5 insertions(+), 3 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/2] tracetool: Fix ust tracepoint issues

Posted by Jon Emil Jahren 6 years, 2 months ago

There are some issues with the argument parsing for ust.
The first issue is that the regex pattern matching arguments with PRI
types matched too much. This was fixed by using a non-greedy star,
instead of a greedy.
The second issue is that bool type is not recognized. This was fixed by
adding the bool type to be traced as an integer.
Both issues causes missing information in the trace.

The following patches fix the issues mentioned.

Jon Emil Jahren (2):
  tracetool: Update argument format regex to non-greedy star
  tracetool: For ust trace bool type as ctf_integer

 scripts/tracetool/__init__.py            | 5 +++--
 scripts/tracetool/format/ust_events_h.py | 3 ++-
 2 files changed, 5 insertions(+), 3 deletions(-)

-- 
2.14.3

Re: [Qemu-devel] [PATCH 0/2] tracetool: Fix ust tracepoint issues

Posted by Stefan Hajnoczi 6 years, 2 months ago

On Mon, Jan 29, 2018 at 05:16:46AM +0100, Jon Emil Jahren wrote:
> There are some issues with the argument parsing for ust.
> The first issue is that the regex pattern matching arguments with PRI
> types matched too much. This was fixed by using a non-greedy star,
> instead of a greedy.
> The second issue is that bool type is not recognized. This was fixed by
> adding the bool type to be traced as an integer.
> Both issues causes missing information in the trace.
> 
> The following patches fix the issues mentioned.
> 
> Jon Emil Jahren (2):
>   tracetool: Update argument format regex to non-greedy star
>   tracetool: For ust trace bool type as ctf_integer
> 
>  scripts/tracetool/__init__.py            | 5 +++--
>  scripts/tracetool/format/ust_events_h.py | 3 ++-
>  2 files changed, 5 insertions(+), 3 deletions(-)

Excellent work, thanks for the patches!

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan