From nobody Mon Apr 29 06:43:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516804138753179.21914442856837; Wed, 24 Jan 2018 06:28:58 -0800 (PST) Received: from localhost ([::1]:52119 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeM2n-0003N5-7n for importer@patchew.org; Wed, 24 Jan 2018 09:28:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeLuB-00075x-Gw for qemu-devel@nongnu.org; Wed, 24 Jan 2018 09:20:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeLu6-00080J-M6 for qemu-devel@nongnu.org; Wed, 24 Jan 2018 09:19:59 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:53471) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eeLu6-0007yG-G0 for qemu-devel@nongnu.org; Wed, 24 Jan 2018 09:19:54 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8E6052230D; Wed, 24 Jan 2018 09:19:52 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Wed, 24 Jan 2018 09:19:52 -0500 Received: from localhost.localdomain (ip5b40bfaa.dynamic.kabel-deutschland.de [91.64.191.170]) by mail.messagingengine.com (Postfix) with ESMTPA id C6BF3247A9; Wed, 24 Jan 2018 09:19:51 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=n/YkMZJHJXwGBY4MscDO6nA1EPJOM 8dhpxXheI1GzGU=; b=BCUnN9mNRBkzw/jpH0ml0YPcdTjpDSIYc2Mucv2Klru2+ jsxOahST+PRFAjpUVJZMEmh6ETre1pjgHLbaSObgjTZnja90YVjTsHU4LSdYmf4P aRfAKpOcYSYiZRTFPTDe0wQsZVND84I5igmocqbhUNVxPQYn9Lqn/u3gwKSJukQV 23eemH4uOC6Cg8CcEKC4MeImWPxOLTHqN56jl4aQFW5hrrj4GnHs757m41CcIvFs lBrIMdh96QVEAK+LiI44uETvAWYlSocvrXLlgrRx+2j3zuuG6j6CUFvNT68txo/S 7CBTAfDs/SZs8fD5WbiSIkS3MwWlT/E8gZ3h/EhtA== X-ME-Sender: From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: qemu-devel@nongnu.org Date: Wed, 24 Jan 2018 15:18:48 +0100 Message-Id: <20180124141848.3969-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.13.6 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Organization: Invisible Things Lab Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.28 X-Mailman-Approved-At: Wed, 24 Jan 2018 09:27:13 -0500 Subject: [Qemu-devel] [PATCH] intel_iommu: allow updating FEADDR and FEUADDR with one 64bit write X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Allow updating those two adjacent 32bit fields with one 64bit write. This fixes qemu crash when booting Xen inside. See discussion on Xen side of the thing here: http://xen.markmail.org/message/6mrmemrnmhxvaxba Signed-off-by: Marek Marczykowski-G=C3=B3recki --- hw/i386/intel_iommu.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 2e841cde27..d214dce277 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2129,8 +2129,12 @@ static void vtd_mem_write(void *opaque, hwaddr addr, =20 /* Fault Event Address Register, 32-bit */ case DMAR_FEADDR_REG: - assert(size =3D=3D 4); - vtd_set_long(s, addr, val); + assert(size =3D=3D 4 || size =3D=3D 8); + if (size =3D=3D 4) { + vtd_set_long(s, addr, val); + } else { + vtd_set_quad(s, addr, val); + } break; =20 /* Fault Event Upper Address Register, 32-bit */ --=20 2.13.6