[Qemu-devel] [PATCH 00/11] linux-user: improve NETLINK strace

Philippe Mathieu-Daudé posted 11 patches 6 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180124130126.20871-1-f4bug@amsat.org
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test ppc passed
Test s390x passed
linux-user/syscall_defs.h |   7 +++
linux-user/strace.c       | 122 +++++++++++++++++++++++++++++++++++++++++++++-
linux-user/syscall.c      |  16 +++---
linux-user/strace.list    |  16 +++---
4 files changed, 144 insertions(+), 17 deletions(-)
[Qemu-devel] [PATCH 00/11] linux-user: improve NETLINK strace
Posted by Philippe Mathieu-Daudé 6 years, 2 months ago
Few patches I'v been writting while trying to figure out this issue:
http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html

Regards,

Phil.

Philippe Mathieu-Daudé (11):
  linux-user/strace: dump AF_NETLINK sockaddr content
  linux-user/strace: improve sendto() output
  linux-user/strace: add print_sockaddr_ptr() to handle plain/pointer addrlen
  linux-user/strace: improve recvfrom() output
  linux-user/strace: improve getsockname() output
  linux-user/strace: improve recvmsg() output
  linux-user/strace: improve bind() output
  linux-user/strace: improve gettimeofday() output
  linux-user/strace: improve capget()/capset() output
  linux-user/syscall: verify recvfrom(addr) is user-writable
  linux-user/syscall: simplify recvfrom()

 linux-user/syscall_defs.h |   7 +++
 linux-user/strace.c       | 122 +++++++++++++++++++++++++++++++++++++++++++++-
 linux-user/syscall.c      |  16 +++---
 linux-user/strace.list    |  16 +++---
 4 files changed, 144 insertions(+), 17 deletions(-)

-- 
2.15.1


Re: [Qemu-devel] [PATCH 00/11] linux-user: improve NETLINK strace
Posted by Guido Günther 6 years, 2 months ago
Hi,
On Wed, Jan 24, 2018 at 10:01:15AM -0300, Philippe Mathieu-Daudé wrote:
> Few patches I'v been writting while trying to figure out this issue:
> http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html

I can't comment code wise but it makes the -strace output much more
useful in this area.
 -- Guido

> 
> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (11):
>   linux-user/strace: dump AF_NETLINK sockaddr content
>   linux-user/strace: improve sendto() output
>   linux-user/strace: add print_sockaddr_ptr() to handle plain/pointer addrlen
>   linux-user/strace: improve recvfrom() output
>   linux-user/strace: improve getsockname() output
>   linux-user/strace: improve recvmsg() output
>   linux-user/strace: improve bind() output
>   linux-user/strace: improve gettimeofday() output
>   linux-user/strace: improve capget()/capset() output
>   linux-user/syscall: verify recvfrom(addr) is user-writable
>   linux-user/syscall: simplify recvfrom()
> 
>  linux-user/syscall_defs.h |   7 +++
>  linux-user/strace.c       | 122 +++++++++++++++++++++++++++++++++++++++++++++-
>  linux-user/syscall.c      |  16 +++---
>  linux-user/strace.list    |  16 +++---
>  4 files changed, 144 insertions(+), 17 deletions(-)
> 
> -- 
> 2.15.1
> 

Re: [Qemu-devel] [PATCH 00/11] linux-user: improve NETLINK strace
Posted by Laurent Vivier 6 years, 2 months ago
Le 24/01/2018 à 19:50, Guido Günther a écrit :
> Hi,
> On Wed, Jan 24, 2018 at 10:01:15AM -0300, Philippe Mathieu-Daudé wrote:
>> Few patches I'v been writting while trying to figure out this issue:
>> http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html
> 
> I can't comment code wise but it makes the -strace output much more
> useful in this area.

If you have tested the patches and found they work well, you can add a:

Tested-by: .....

Thanks,
Laurent


Re: [Qemu-devel] [PATCH 00/11] linux-user: improve NETLINK strace
Posted by Guido Günther 6 years, 2 months ago
Hi,
On Wed, Jan 24, 2018 at 10:01:15AM -0300, Philippe Mathieu-Daudé wrote:
> Few patches I'v been writting while trying to figure out this issue:
> http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html

Whole series

Tested-By: Guido Günther <agx@sigxcpu.org>

> 
> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (11):
>   linux-user/strace: dump AF_NETLINK sockaddr content
>   linux-user/strace: improve sendto() output
>   linux-user/strace: add print_sockaddr_ptr() to handle plain/pointer addrlen
>   linux-user/strace: improve recvfrom() output
>   linux-user/strace: improve getsockname() output
>   linux-user/strace: improve recvmsg() output
>   linux-user/strace: improve bind() output
>   linux-user/strace: improve gettimeofday() output
>   linux-user/strace: improve capget()/capset() output
>   linux-user/syscall: verify recvfrom(addr) is user-writable
>   linux-user/syscall: simplify recvfrom()
> 
>  linux-user/syscall_defs.h |   7 +++
>  linux-user/strace.c       | 122 +++++++++++++++++++++++++++++++++++++++++++++-
>  linux-user/syscall.c      |  16 +++---
>  linux-user/strace.list    |  16 +++---
>  4 files changed, 144 insertions(+), 17 deletions(-)
> 
> -- 
> 2.15.1
> 

Re: [Qemu-devel] [PATCH 00/11] linux-user: improve NETLINK strace
Posted by Philippe Mathieu-Daudé 6 years, 2 months ago
On Sun, Jan 28, 2018 at 8:12 AM, Guido Günther <agx@sigxcpu.org> wrote:
> Hi,
> On Wed, Jan 24, 2018 at 10:01:15AM -0300, Philippe Mathieu-Daudé wrote:
>> Few patches I'v been writting while trying to figure out this issue:
>> http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html
>
> Whole series
>
> Tested-By: Guido Günther <agx@sigxcpu.org>

Thank you Guido!