From nobody Mon May 6 15:03:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516730202049931.9717997766709; Tue, 23 Jan 2018 09:56:42 -0800 (PST) Received: from localhost ([::1]:43259 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee2o7-00039Z-EZ for importer@patchew.org; Tue, 23 Jan 2018 12:56:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee2nG-0002ml-8V for qemu-devel@nongnu.org; Tue, 23 Jan 2018 12:55:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee2nB-0004E6-5m for qemu-devel@nongnu.org; Tue, 23 Jan 2018 12:55:34 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50462) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ee2nA-0004DG-9j for qemu-devel@nongnu.org; Tue, 23 Jan 2018 12:55:28 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0NHtIbh011786 for ; Tue, 23 Jan 2018 12:55:26 -0500 Received: from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fp9jpgq09-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 23 Jan 2018 12:55:21 -0500 Received: from localhost by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 23 Jan 2018 10:54:19 -0700 Received: from b03cxnp08025.gho.boulder.ibm.com (9.17.130.17) by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 23 Jan 2018 10:54:16 -0700 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w0NHsGlX11862370; Tue, 23 Jan 2018 10:54:16 -0700 Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EA664BE038; Tue, 23 Jan 2018 10:54:15 -0700 (MST) Received: from pacoca.br.ibm.com (unknown [9.18.235.216]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP id 89080BE03E; Tue, 23 Jan 2018 10:54:14 -0700 (MST) From: Jose Ricardo Ziviani To: qemu-devel@nongnu.org, mst@redhat.com, pbonzini@redhat.com Date: Tue, 23 Jan 2018 15:54:09 -0200 X-Mailer: git-send-email 2.14.3 X-TM-AS-GCONF: 00 x-cbid: 18012317-0008-0000-0000-00000936691B X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008414; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000247; SDB=6.00979253; UDB=6.00496322; IPR=6.00758559; BA=6.00005792; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00019170; XFM=3.00000015; UTC=2018-01-23 17:54:18 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18012317-0009-0000-0000-000045AD8AC9 Message-Id: <20180123175409.9349-1-joserz@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-01-23_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801230245 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.156.1 Subject: [Qemu-devel] [PATCH v2] kvm-all: Partially reverts 4fe6d78b2e to remove the cleanup call X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ghammer@redhat.com, danielhb@linux.vnet.ibm.com, anton@samba.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This commit partially reverts the commit 4fe6d78b2e because of issues reported in the virtio. Examples: $ qemu-system-ppc64 -cpu POWER8 -nographic -vga none -m 4G \ -M pseries,accel=3Dkvm -netdev type=3Duser,id=3Dnet0 \ -device virtio-net-pci,netdev=3Dnet0 -drive file=3D../disk.qcow2,if=3Dvir= tio Populating /vdevice/nvram@71000001 Populating /vdevice/v-scsi@71000002 SCSI: Looking for devices 8200000000000000 CD-ROM : "QEMU QEMU CD-ROM 2.5+" Populating /pci@800000020000000 00 0000 (D) : 1af4 1000 virtio [ net ] Aborted $ qemu-system-x86_64 -m 4G -enable-kvm -drive file=3Dutil.qcow2,if=3Dvirtio Running QEMU with GTK 2.x is deprecated, and will be removed in a future release. Please switch to GTK 3.x instead [1] 5282 abort Reference http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg05457.= html Reported-by: Anton Blanchard Signed-off-by: Jose Ricardo Ziviani Reviewed-by: Daniel Henrique Barboza Tested-by: Daniel Henrique Barboza --- accel/kvm/kvm-all.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 071f4f57c0..f290f487a5 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -812,10 +812,6 @@ static void kvm_mem_ioeventfd_del(MemoryListener *list= ener, if (r < 0) { abort(); } - - if (e->cleanup) { - e->cleanup(e); - } } =20 static void kvm_io_ioeventfd_add(MemoryListener *listener, --=20 2.14.3