From nobody Fri May 3 18:14:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1516719721877422.4099338286982; Tue, 23 Jan 2018 07:02:01 -0800 (PST) Received: from localhost ([::1]:33948 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee059-0001uH-Qo for importer@patchew.org; Tue, 23 Jan 2018 10:01:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edzwE-0002Nk-AY for qemu-devel@nongnu.org; Tue, 23 Jan 2018 09:52:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edzw9-0006xs-Kh for qemu-devel@nongnu.org; Tue, 23 Jan 2018 09:52:38 -0500 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:40444) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edzw9-0006xO-G7; Tue, 23 Jan 2018 09:52:33 -0500 Received: by mail-qt0-x243.google.com with SMTP id s39so1877343qth.7; Tue, 23 Jan 2018 06:52:33 -0800 (PST) Received: from x1.lan ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id y30sm394574qtm.50.2018.01.23.06.52.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jan 2018 06:52:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OO7IOEVHKU0zW67RebaFImuEQvXXUTHJp8DbB94rL1Q=; b=onPkjjrRDaIJM+Vi1ZKqEB617PPlej6yheXRpzygIV1xRfiZ4HnuKj/VtcyK78hx0s h/tnQHZOnMG8CnUrXPINkR/NcgB7ow4mFuStxwtiZ2WNwamEpeStYmPD8MmPaIZ7NJoV ipVgeHbeV7FbPKICadQR3mEy8VD6yC42m+9YxvqGAf50vtJJVRX6dZEDVzSFYq7pt+nc mWhvmPuHIn7dmjwOfMmKHHsjMN1QkBCq4aZQEfma3rEX6PuZ8jZLlbkzMuAoCv9Pcimq 86PM2Ypb4fUBeOnuMeiSIX7I5eg/9Kip0bRSrKn9JC4a8rvD3gl46UQT0Z2Sebw0Bun8 77Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=OO7IOEVHKU0zW67RebaFImuEQvXXUTHJp8DbB94rL1Q=; b=NEXDaX3Blkt1TNELt3BICfVXBMdZS02avOxbjKHXxtNh/qCYavuJ22RfoqteKF8V0T y3nNlA+XWWL3x0anPB16ND4nrtWHLowwAD+OLxn7ZHJ4JBD5BtNOLMn7CtXi3Ztp6SNi Pabs8UbIC3ppMeNXWpLEteow4eEk32lZD+2NpbTMSJmLySlOuPe1j4PgnEdnT7V3WySM Yd7vwyrqb1pzeBLLPv7mVUmRKuvqIQHFcBDrd3UZMRo8/BLfbZCqMOC34mDT5SO9ljvR tFYQznjcYTOu0vyMZEE7KW2KBR0xCFG+nfochuPtOt9yK51m8iHmcdjzOjs5lMfCmTdT NvCA== X-Gm-Message-State: AKwxytcB6FmUKTZMwyt8nJo9M6q79bgA4wAF1NKU+/0yzwMgJsKkPzFm +EQkbDUAfPQf0Clpvo2xTrM= X-Google-Smtp-Source: AH8x2251ta3SKWCLGfPPhhRhejrYyTtS2T2fqbcQn4C9W/+o/tosFwB6PNS0Pk1Q0axe17xezBCszQ== X-Received: by 10.237.42.198 with SMTP id t64mr3914653qtd.177.1516719151344; Tue, 23 Jan 2018 06:52:31 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Guido=20G=C3=BCnther?= , Laurent Vivier , Riku Voipio Date: Tue, 23 Jan 2018 11:52:22 -0300 Message-Id: <20180123145222.2487-1-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH] linux-user/syscall: let recvfrom(struct sockaddr *) use abi_ulong X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Currently recvfrom() is restricted to handle 32-bit pointers, remove this limit for 64-bit hosts. This fixes: 31572 socket(AF_NETLINK, SOCK_RAW, NETLINK_AUDIT) =3D 3 ... 31572 sendto(3, {{len=3D124, type=3D0x454 /* NLMSG_??? */, flags=3DNLM_F_= REQUEST|NLM_F_ACK, seq=3D1, pid=3D0}, "op=3Dtest:message acct=3D\"?\" exe= =3D\"/tmp/nl-bad-addr\" hostname=3Dlocalhost addr=3D? terminal=3D/dev/pts/2= res=3Dsuccess\0\0\0"}, 124, 0, 0xfffffa3897d0, 0) =3D 124 31572 ppoll([{fd=3D3, events=3DPOLLIN}], 1, {tv_sec=3D0, tv_nsec=3D500000= 000}, NULL, 0) =3D 1 ([{fd=3D3, revents=3DPOLLIN}], left {tv_sec=3D0, tv_ns= ec=3D499993180}) 31572 recvfrom(3, 0x112a50eb4, 8988, MSG_PEEK|MSG_DONTWAIT, 0xfffffa3897e= 0, 0x42) =3D -1 EFAULT (Bad address) Reported-by: Guido G=C3=BCnther Message-id: 20180123120541.GA14216@bogon.m.sigxcpu.org Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- linux-user/syscall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 11c9116c4a..28805b1785 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -4032,7 +4032,7 @@ static abi_long do_recvfrom(int fd, abi_ulong msg, si= ze_t len, int flags, if (!host_msg) return -TARGET_EFAULT; if (target_addr) { - if (get_user_u32(addrlen, target_addrlen)) { + if (get_user_ual(addrlen, target_addrlen)) { ret =3D -TARGET_EFAULT; goto fail; } @@ -4053,7 +4053,7 @@ static abi_long do_recvfrom(int fd, abi_ulong msg, si= ze_t len, int flags, } if (target_addr) { host_to_target_sockaddr(target_addr, addr, addrlen); - if (put_user_u32(addrlen, target_addrlen)) { + if (put_user_ual(addrlen, target_addrlen)) { ret =3D -TARGET_EFAULT; goto fail; } --=20 2.15.1