[v2] memory/vfio: notify region_del() when unregister listeners

[Qemu-devel] [PATCH v2 0/4] memory/vfio: notify region_del() when unregister listeners

Posted by Peter Xu 6 years, 2 months ago

v2
- add begin() hooks [Paolo]
- move vfio patch to front [Paolo]
- one more patch for arm devlistener unregister [Paolo]
- one more patch for vhost traces
- removing RFC tag

This series fixes bug reported here:

  https://bugzilla.redhat.com/show_bug.cgi?id=1531393

The first patch only adds traces for vhost, with which I tested on
vhost to make sure that my last patch works as expected with vhost.
Please pick it if anyone wants, or ignore it if no one likes it.

The 2nd patch is the arm fix for preparation of the last patch.

The 3rd patch is the vfio fix for preparation of the last patch.

The 4th patch is the core fix of the problem.

Please review, thanks.

Thanks.

Peter Xu (4):
  vhost: add traces for memory listeners
  arm: postpone device listener unregister
  vfio: listener unregister before unset container
  memory: do explicit cleanup when remove listeners

 hw/vfio/common.c       | 16 ++++++++++++----
 hw/virtio/trace-events |  6 ++++++
 hw/virtio/vhost.c      | 11 +++++++----
 memory.c               | 27 +++++++++++++++++++++++++++
 target/arm/kvm.c       |  2 +-
 5 files changed, 53 insertions(+), 9 deletions(-)

-- 
2.14.3

Re: [Qemu-devel] [PATCH v2 0/4] memory/vfio: notify region_del() when unregister listeners

Posted by Paolo Bonzini 6 years, 2 months ago

On 22/01/2018 07:02, Peter Xu wrote:
> v2
> - add begin() hooks [Paolo]
> - move vfio patch to front [Paolo]
> - one more patch for arm devlistener unregister [Paolo]
> - one more patch for vhost traces
> - removing RFC tag
> 
> This series fixes bug reported here:
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=1531393
> 
> The first patch only adds traces for vhost, with which I tested on
> vhost to make sure that my last patch works as expected with vhost.
> Please pick it if anyone wants, or ignore it if no one likes it.
> 
> The 2nd patch is the arm fix for preparation of the last patch.
> 
> The 3rd patch is the vfio fix for preparation of the last patch.
> 
> The 4th patch is the core fix of the problem.
> 
> Please review, thanks.
> 
> Thanks.
> 
> Peter Xu (4):
>   vhost: add traces for memory listeners
>   arm: postpone device listener unregister
>   vfio: listener unregister before unset container
>   memory: do explicit cleanup when remove listeners
> 
>  hw/vfio/common.c       | 16 ++++++++++++----
>  hw/virtio/trace-events |  6 ++++++
>  hw/virtio/vhost.c      | 11 +++++++----
>  memory.c               | 27 +++++++++++++++++++++++++++
>  target/arm/kvm.c       |  2 +-
>  5 files changed, 53 insertions(+), 9 deletions(-)
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Alex, Peter, can you ack or apply patches 2/3?

Thanks,

Paolo

Re: [Qemu-devel] [PATCH v2 0/4] memory/vfio: notify region_del() when unregister listeners

Posted by Paolo Bonzini 6 years, 2 months ago

On 22/01/2018 01:02, Peter Xu wrote:
> v2
> - add begin() hooks [Paolo]
> - move vfio patch to front [Paolo]
> - one more patch for arm devlistener unregister [Paolo]
> - one more patch for vhost traces
> - removing RFC tag
> 
> This series fixes bug reported here:
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=1531393
> 
> The first patch only adds traces for vhost, with which I tested on
> vhost to make sure that my last patch works as expected with vhost.
> Please pick it if anyone wants, or ignore it if no one likes it.
> 
> The 2nd patch is the arm fix for preparation of the last patch.
> 
> The 3rd patch is the vfio fix for preparation of the last patch.
> 
> The 4th patch is the core fix of the problem.
> 
> Please review, thanks.
> 
> Thanks.
> 
> Peter Xu (4):
>   vhost: add traces for memory listeners
>   arm: postpone device listener unregister
>   vfio: listener unregister before unset container
>   memory: do explicit cleanup when remove listeners
> 
>  hw/vfio/common.c       | 16 ++++++++++++----
>  hw/virtio/trace-events |  6 ++++++
>  hw/virtio/vhost.c      | 11 +++++++----
>  memory.c               | 27 +++++++++++++++++++++++++++
>  target/arm/kvm.c       |  2 +-
>  5 files changed, 53 insertions(+), 9 deletions(-)
> 

Queued, thanks.

Paolo