[Qemu-devel] [PATCHv2 00/10] sun4u: APB tidy-up/rename and tracepoint conversions

Mark Cave-Ayland posted 10 patches 6 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180121091154.17426-1-mark.cave-ayland@ilande.co.uk
Test checkpatch failed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test ppc passed
Test s390x passed
Makefile.objs                          |   1 +
default-configs/sparc64-softmmu.mak    |   3 +-
hw/pci-bridge/Makefile.objs            |   2 +
hw/pci-bridge/simba.c                  | 101 ++++++++++++
hw/pci-host/Makefile.objs              |   2 +-
hw/pci-host/{apb.c => sabre.c}         | 270 ++++++++++++---------------------
hw/pci-host/trace-events               |  11 ++
hw/sparc64/sparc64.c                   |  85 +++++------
hw/sparc64/sun4u.c                     |  45 +++---
hw/sparc64/trace-events                |  18 +++
include/hw/pci-bridge/simba.h          |  38 +++++
include/hw/pci-host/{apb.h => sabre.h} |  26 ++--
12 files changed, 342 insertions(+), 260 deletions(-)
create mode 100644 hw/pci-bridge/simba.c
rename hw/pci-host/{apb.c => sabre.c} (62%)
create mode 100644 hw/pci-host/trace-events
create mode 100644 include/hw/pci-bridge/simba.h
rename include/hw/pci-host/{apb.h => sabre.h} (69%)
[Qemu-devel] [PATCHv2 00/10] sun4u: APB tidy-up/rename and tracepoint conversions
Posted by Mark Cave-Ayland 6 years, 2 months ago
This patchset is the next round of sun4u tidy-ups mostly centered around the
APB (PCI host bridge). In its current form apb.c contains both the PCI host
bridge and the secondary PCI bridge, so we split the PCI bridge into a new
file and move it under hw/pci-bridge.

To order to avoid further confusion between PBM/APB naming I've gone for using
the Sun internal code names, sabre and simba for the two PCI bridges to keep
things consistent.

Finally there are a couple of conversions to trace-events for sabre and the
sparc CPU as used when debugging this patchset. Note that as hw/pci-host is
listed as having no maintainers, I've CCd the PCI bridge maintainers on the
hw/pci-host tracepoint conversion which I hope is reasonable.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

v2:
- Rebase onto master
- Add R-b and A-b tags from reviewers
- Squash patches 9 and 10 as requested by Philippe and Marcel


Mark Cave-Ayland (10):
  apb: split simba PCI bridge into hw/pci-bridge/simba.c
  simba: rename PBMPCIBridge and QOM types to reflect simba naming
  apb: rename APB functions to use sabre prefix
  apb: change pbm_pci_host prefix functions to use sabre_pci prefix
  apb: QOMify sabre PCI host bridge
  apb: rename QOM type from TYPE_APB to TYPE_SABRE
  sun4u: rename apb variables and constants
  apb: rename apb.c to sabre.c
  sabre: convert from SABRE_DPRINTF macro to trace-events
  sparc64: convert hw/sparc64/sparc64.c from DPRINTF macros to trace
    events

 Makefile.objs                          |   1 +
 default-configs/sparc64-softmmu.mak    |   3 +-
 hw/pci-bridge/Makefile.objs            |   2 +
 hw/pci-bridge/simba.c                  | 101 ++++++++++++
 hw/pci-host/Makefile.objs              |   2 +-
 hw/pci-host/{apb.c => sabre.c}         | 270 ++++++++++++---------------------
 hw/pci-host/trace-events               |  11 ++
 hw/sparc64/sparc64.c                   |  85 +++++------
 hw/sparc64/sun4u.c                     |  45 +++---
 hw/sparc64/trace-events                |  18 +++
 include/hw/pci-bridge/simba.h          |  38 +++++
 include/hw/pci-host/{apb.h => sabre.h} |  26 ++--
 12 files changed, 342 insertions(+), 260 deletions(-)
 create mode 100644 hw/pci-bridge/simba.c
 rename hw/pci-host/{apb.c => sabre.c} (62%)
 create mode 100644 hw/pci-host/trace-events
 create mode 100644 include/hw/pci-bridge/simba.h
 rename include/hw/pci-host/{apb.h => sabre.h} (69%)

-- 
2.11.0


Re: [Qemu-devel] [PATCHv2 00/10] sun4u: APB tidy-up/rename and tracepoint conversions
Posted by no-reply@patchew.org 6 years, 2 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180121091154.17426-1-mark.cave-ayland@ilande.co.uk
Subject: [Qemu-devel] [PATCHv2 00/10] sun4u: APB tidy-up/rename and tracepoint conversions

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20180121091154.17426-1-mark.cave-ayland@ilande.co.uk -> patchew/20180121091154.17426-1-mark.cave-ayland@ilande.co.uk
Switched to a new branch 'test'
0eb52aeef3 sparc64: convert hw/sparc64/sparc64.c from DPRINTF macros to trace events
32f1d8e1b5 sabre: convert from SABRE_DPRINTF macro to trace-events
6958f18f5a apb: rename apb.c to sabre.c
fe3e1b336c sun4u: rename apb variables and constants
a750fff18e apb: rename QOM type from TYPE_APB to TYPE_SABRE
9280916a01 apb: QOMify sabre PCI host bridge
5180d214a9 apb: change pbm_pci_host prefix functions to use sabre_pci prefix
748c2e2536 apb: rename APB functions to use sabre prefix
05b08c4f2f simba: rename PBMPCIBridge and QOM types to reflect simba naming
ea5afa753a apb: split simba PCI bridge into hw/pci-bridge/simba.c

=== OUTPUT BEGIN ===
Checking PATCH 1/10: apb: split simba PCI bridge into hw/pci-bridge/simba.c...
Checking PATCH 2/10: simba: rename PBMPCIBridge and QOM types to reflect simba naming...
Checking PATCH 3/10: apb: rename APB functions to use sabre prefix...
Checking PATCH 4/10: apb: change pbm_pci_host prefix functions to use sabre_pci prefix...
Checking PATCH 5/10: apb: QOMify sabre PCI host bridge...
Checking PATCH 6/10: apb: rename QOM type from TYPE_APB to TYPE_SABRE...
Checking PATCH 7/10: sun4u: rename apb variables and constants...
Checking PATCH 8/10: apb: rename apb.c to sabre.c...
ERROR: do not use C99 // comments
#91: FILE: hw/pci-host/sabre.c:41:
+//#define DEBUG_SABRE

total: 1 errors, 0 warnings, 188 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 9/10: sabre: convert from SABRE_DPRINTF macro to trace-events...
Checking PATCH 10/10: sparc64: convert hw/sparc64/sparc64.c from DPRINTF macros to trace events...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org