From nobody Thu Mar 28 13:23:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15157256190220.6411829083129987; Thu, 11 Jan 2018 18:53:39 -0800 (PST) Received: from localhost ([::1]:35602 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZpTO-0002oC-Bz for importer@patchew.org; Thu, 11 Jan 2018 21:53:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZpQA-0000Pd-2S for qemu-devel@nongnu.org; Thu, 11 Jan 2018 21:50:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZpQ6-0002sv-TY for qemu-devel@nongnu.org; Thu, 11 Jan 2018 21:50:18 -0500 Received: from m15-114.126.com ([220.181.15.114]:56065) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZpQ6-0002oJ-8y for qemu-devel@nongnu.org; Thu, 11 Jan 2018 21:50:14 -0500 Received: from localhost.localdomain (unknown [58.213.111.46]) by smtp7 (Coremail) with SMTP id DsmowAAnfdJTIlhacQ59Ag--.415S2; Fri, 12 Jan 2018 10:50:06 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=Z9jSH52QTSU3qluFJB A06BQkDzlrawxCTuolZHB9dJI=; b=E2TdK1UXUvJOCkJA5apuONGTqxrJWRqlko 1QClsI7sYKryorV/EF58K0RwBKPUIMxxBQMz5ze/DtR6/kOgqdsc6SBARs1Qc26O voIgNS/ibFsgpsVtSJhtBMb2scVtTqfkolKYq3/M5woFu79lLMP2f5IgXAT4JpNv 5vYrtuPNY= From: Chen Hanxiao To: qemu-devel@nongnu.org Date: Fri, 12 Jan 2018 10:47:45 +0800 Message-Id: <20180112024745.7609-1-chen_han_xiao@126.com> X-Mailer: git-send-email 2.14.3 X-CM-TRANSID: DsmowAAnfdJTIlhacQ59Ag--.415S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKF48Gw4kGFW8Xw4xAFWfuFg_yoWfCFb_GF yUJFZxGr4qk3W8Ja4jyr13Aw48A3y3ArnYg3sYg3W2ya4UuFZ0qan7ZrWrGr1fCa9FvFya qws5CrZ8KFySqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU81a0PUUUUU== X-Originating-IP: [58.213.111.46] X-CM-SenderInfo: xfkh0spkdqs5xldrqiyswou0bp/1tbiaR7LrlpD388GUQAAsM X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 220.181.15.114 Subject: [Qemu-devel] [resend][PATCH] qga: unset frozen state if no mount points are frozen X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , Chen Hanxiao Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Chen Hanxiao If we set mountpoints to qmp_guest_fsfreeze_freeze_list, we may got nothing to freeze as all mountpoints are not valid. Call ga_unset_frozen in this senario. Cc: Michael Roth Signed-off-by: Chen Hanxiao --- Rebase on master qga/commands-posix.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index e809e382eb..9fd51f1d7a 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -1273,6 +1273,12 @@ int64_t qmp_guest_fsfreeze_freeze_list(bool has_moun= tpoints, } =20 free_fs_mount_list(&mounts); + /* We may not issue any FIFREEZE here when had mountpoints. + * Just unset ga_state here and ready for the next call. + */ + if (has_mountpoints && i =3D=3D 0) { + ga_unset_frozen(ga_state); + } return i; =20 error: --=20 2.14.3