[v2] NBD server refactoring before BLOCK_STATUS

[Qemu-devel] [PATCH v2 0/6] NBD server refactoring before BLOCK_STATUS

Eric Blake posted 6 patches 6 years, 3 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180110230825.18321-1-eblake@redhat.com

Test checkpatch passed

Test docker passed

Test ppc passed

Test s390x passed

nbd/server.c | 341 ++++++++++++++++++++++++++++++-----------------------------
1 file changed, 171 insertions(+), 170 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/6] NBD server refactoring before BLOCK_STATUS

Posted by Eric Blake 6 years, 3 months ago

This is my promised revision of Vladimir's v1 posted here:
https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg04119.html

Sorry for my delay; it was due in part to an embargo while dealing
with 2 bounds-check CVEs in the NBD code that I discovered while
reviewing his v1 (fixed in time for 2.11), then waiting for the
2.12 tree to reopen, coupled with my holiday break.  I'm hoping
we can get actual BLOCK_STATUS code reviewed and applied much
faster than this preliminary series has gone.

Based-on: <20180110225944.17920-1-eblake@redhat.com>

Since v1:
- original patch 4/5 now in a pull request
- replace original 2-3/5 with a single patch, giving more useful
semantics to nbd_opt_drop/nbd_opt_read
- add a couple of other easy fixes while touching the file

Eric Blake (4):
  nbd/server: Hoist nbd_reject_length() earlier
  nbd/server: Better error for NBD_OPT_EXPORT_NAME failure
  nbd/server: Add va_list form of nbd_negotiate_send_rep_err()
  nbd/server: Add helper functions for parsing option payload

Vladimir Sementsov-Ogievskiy (2):
  nbd/server: refactor negotiation functions parameters
  nbd/server: structurize option reply sending

 nbd/server.c | 341 ++++++++++++++++++++++++++++++-----------------------------
 1 file changed, 171 insertions(+), 170 deletions(-)

-- 
2.14.3