This series improves the tracetool error messages to make them more
user-friendly.

Stefan Hajnoczi (3):
  tracetool: prefix parse errors with line numbers
  tracetool: clarify that "formats" means "format strings"
  tracetool: report error on foo() instead of foo(void)

 scripts/tracetool/__init__.py | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

-- 
2.14.3

On 01/10/2018 02:25 PM, Stefan Hajnoczi wrote:
> This series improves the tracetool error messages to make them more
> user-friendly.
> 
> Stefan Hajnoczi (3):
>   tracetool: prefix parse errors with line numbers
>   tracetool: clarify that "formats" means "format strings"
>   tracetool: report error on foo() instead of foo(void)

Series:
Reviewed-by: Eric Blake <eblake@redhat.com>

but see nit on patch 1

> 
>  scripts/tracetool/__init__.py | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

On Wed, Jan 10, 2018 at 02:48:16PM -0600, Eric Blake wrote:
> On 01/10/2018 02:25 PM, Stefan Hajnoczi wrote:
> > This series improves the tracetool error messages to make them more
> > user-friendly.
> > 
> > Stefan Hajnoczi (3):
> >   tracetool: prefix parse errors with line numbers
> >   tracetool: clarify that "formats" means "format strings"
> >   tracetool: report error on foo() instead of foo(void)
> 
> Series:
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> but see nit on patch 1

Thanks, will fix!

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180110202553.31889-1-stefanha@redhat.com
Subject: [Qemu-devel] [PATCH 0/3] tracetool: improve error messages

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
08b156de69 tracetool: report error on foo() instead of foo(void)
7c4579f8ce tracetool: clarify that "formats" means "format strings"
3842c08817 tracetool: prefix parse errors with line numbers

=== OUTPUT BEGIN ===
Checking PATCH 1/3: tracetool: prefix parse errors with line numbers...
Checking PATCH 2/3: tracetool: clarify that "formats" means "format strings"...
ERROR: line over 90 characters
#37: FILE: scripts/tracetool/__init__.py:240:
+            raise ValueError("Only events with 'tcg' property can have two format strings")

WARNING: line over 80 characters
#40: FILE: scripts/tracetool/__init__.py:242:
+            raise ValueError("Events with 'tcg' property must have two format strings")

total: 1 errors, 1 warnings, 27 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/3: tracetool: report error on foo() instead of foo(void)...
WARNING: line over 80 characters
#24: FILE: scripts/tracetool/__init__.py:79:
+                raise ValueError("Empty argument (did you forget to use 'void'?)")

total: 0 errors, 1 warnings, 8 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

On Wed, Jan 10, 2018 at 08:25:50PM +0000, Stefan Hajnoczi wrote:
> This series improves the tracetool error messages to make them more
> user-friendly.
> 
> Stefan Hajnoczi (3):
>   tracetool: prefix parse errors with line numbers
>   tracetool: clarify that "formats" means "format strings"
>   tracetool: report error on foo() instead of foo(void)
> 
>  scripts/tracetool/__init__.py | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)
> 
> -- 
> 2.14.3
> 

Thanks, applied (with Eric Blake's improvement) to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan