From nobody Thu May 2 13:34:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1513096659300457.25638847623884; Tue, 12 Dec 2017 08:37:39 -0800 (PST) Received: from localhost ([::1]:59303 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOnYY-0003ht-H7 for importer@patchew.org; Tue, 12 Dec 2017 11:37:22 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOnXQ-0003KM-KJ for qemu-devel@nongnu.org; Tue, 12 Dec 2017 11:36:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOnXP-0008SF-KY for qemu-devel@nongnu.org; Tue, 12 Dec 2017 11:36:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33720) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eOnXP-0008Ru-C4 for qemu-devel@nongnu.org; Tue, 12 Dec 2017 11:36:11 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8592261471 for ; Tue, 12 Dec 2017 16:36:10 +0000 (UTC) Received: from localhost (unknown [10.41.0.123]) by smtp.corp.redhat.com (Postfix) with ESMTP id B797563B81; Tue, 12 Dec 2017 16:35:58 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Tue, 12 Dec 2017 17:35:56 +0100 Message-Id: <20171212163556.2543-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 12 Dec 2017 16:36:10 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] dump-guest-memory.py: fix "You can't do that without a process to debug" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Cleber Rosa , lersek@redhat.com, Eduardo Habkost , mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" If the script is run with a core (no running process), it produces an error: (gdb) dump-guest-memory /tmp/vmcore X86_64 guest RAM blocks: target_start target_end host_addr message count ---------------- ---------------- ---------------- ------- ----- 0000000000000000 00000000000a0000 00007f7935800000 added 1 00000000000a0000 00000000000b0000 00007f7934200000 added 2 00000000000c0000 00000000000ca000 00007f79358c0000 added 3 00000000000ca000 00000000000cd000 00007f79358ca000 joined 3 00000000000cd000 00000000000e8000 00007f79358cd000 joined 3 00000000000e8000 00000000000f0000 00007f79358e8000 joined 3 00000000000f0000 0000000000100000 00007f79358f0000 joined 3 0000000000100000 0000000080000000 00007f7935900000 joined 3 00000000fd000000 00000000fe000000 00007f7934200000 added 4 00000000fffc0000 0000000100000000 00007f7935600000 added 5 Python Exception You can't do that without a process to= debug.: Error occurred in Python command: You can't do that without a process to debug. Replace the function call with a variable. I tried to use static function variables, as suggested by Laszlo in earlier reviews, but the compiler always took the chance to optimize them away. Signed-off-by: Marc-Andr=C3=A9 Lureau --- scripts/dump-guest-memory.py | 3 +-- hw/misc/vmcoreinfo.c | 4 ++++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py index 1af26c1a45..9dec796762 100644 --- a/scripts/dump-guest-memory.py +++ b/scripts/dump-guest-memory.py @@ -546,8 +546,7 @@ shape and this command should mostly work.""" return None =20 def add_vmcoreinfo(self): - vmci =3D '(VMCoreInfoState *)' + \ - 'object_resolve_path_type("", "vmcoreinfo", 0)' + vmci =3D 'vmcoreinfo_state' if not gdb.parse_and_eval("%s" % vmci) \ or not gdb.parse_and_eval("(%s)->has_vmcoreinfo" % vmci): return diff --git a/hw/misc/vmcoreinfo.c b/hw/misc/vmcoreinfo.c index 31db57ab44..d429a4f7d6 100644 --- a/hw/misc/vmcoreinfo.c +++ b/hw/misc/vmcoreinfo.c @@ -31,6 +31,9 @@ static void vmcoreinfo_reset(void *dev) s->vmcoreinfo.host_format =3D cpu_to_le16(VMCOREINFO_FORMAT_ELF); } =20 +/* this variable is exported for gdb script dump-guest-memory.py */ +VMCoreInfoState *vmcoreinfo_state; + static void vmcoreinfo_realize(DeviceState *dev, Error **errp) { VMCoreInfoState *s =3D VMCOREINFO(dev); @@ -56,6 +59,7 @@ static void vmcoreinfo_realize(DeviceState *dev, Error **= errp) &s->vmcoreinfo, sizeof(s->vmcoreinfo), false); =20 qemu_register_reset(vmcoreinfo_reset, dev); + vmcoreinfo_state =3D s; } =20 static const VMStateDescription vmstate_vmcoreinfo =3D { --=20 2.15.1.355.g36791d7216