[Qemu-devel] [PATCH v2 0/6] nbd export qmp interface

Vladimir Sementsov-Ogievskiy posted 6 patches 6 years, 3 months ago
Failed in applying to current master (apply log)
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
There is a newer version of this series
qapi/block.json               |  27 ++++++++-
include/block/nbd.h           |   3 +-
blockdev-nbd.c                |  41 +++++++++++--
hmp.c                         |   5 +-
nbd/server.c                  |  31 +++++++++-
tests/qemu-iotests/147        |  68 +++++++++++++++++-----
tests/qemu-iotests/147.out    |   4 +-
tests/qemu-iotests/201        | 130 ++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/201.out    |   5 ++
tests/qemu-iotests/group      |   1 +
tests/qemu-iotests/iotests.py |  38 ++++++++++++
11 files changed, 325 insertions(+), 28 deletions(-)
create mode 100644 tests/qemu-iotests/201
create mode 100644 tests/qemu-iotests/201.out
[Qemu-devel] [PATCH v2 0/6] nbd export qmp interface
Posted by Vladimir Sementsov-Ogievskiy 6 years, 3 months ago
Here:
    1. separate export name from device name
    1.1 several exports per device possible
    2. add nbd-server-remove

v2:
01: add r-bs by Max and Eric, add comment to code (hope you don't mind)
03: address export by its name, not by device name
    make it possible to force-remove export, which is already
    non-force-removed (thourh new "hidden" field)
other patches are new

v1:
Add command to remove nbd export, pair to nbd-server-add.
The whole thing and description are in patch 02.


Vladimir Sementsov-Ogievskiy (6):
  nbd/server: add additional assert to nbd_export_put
  qapi: add name parameter to nbd-server-add
  qapi: add nbd-server-remove
  iotest 147: add cases to test new @name parameter of nbd-server-add
  iotests: implement QemuIoInteractive class
  iotest 201: new test for qmp nbd-server-remove

 qapi/block.json               |  27 ++++++++-
 include/block/nbd.h           |   3 +-
 blockdev-nbd.c                |  41 +++++++++++--
 hmp.c                         |   5 +-
 nbd/server.c                  |  31 +++++++++-
 tests/qemu-iotests/147        |  68 +++++++++++++++++-----
 tests/qemu-iotests/147.out    |   4 +-
 tests/qemu-iotests/201        | 130 ++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/201.out    |   5 ++
 tests/qemu-iotests/group      |   1 +
 tests/qemu-iotests/iotests.py |  38 ++++++++++++
 11 files changed, 325 insertions(+), 28 deletions(-)
 create mode 100644 tests/qemu-iotests/201
 create mode 100644 tests/qemu-iotests/201.out

-- 
2.11.1


Re: [Qemu-devel] [PATCH v2 0/6] nbd export qmp interface
Posted by Markus Armbruster 6 years, 3 months ago
Looks like you forgot to cc: Eric.  Fixing...

Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:

> Here:
>     1. separate export name from device name
>     1.1 several exports per device possible
>     2. add nbd-server-remove
>
> v2:
> 01: add r-bs by Max and Eric, add comment to code (hope you don't mind)
> 03: address export by its name, not by device name
>     make it possible to force-remove export, which is already
>     non-force-removed (thourh new "hidden" field)
> other patches are new
>
> v1:
> Add command to remove nbd export, pair to nbd-server-add.
> The whole thing and description are in patch 02.
>
>
> Vladimir Sementsov-Ogievskiy (6):
>   nbd/server: add additional assert to nbd_export_put
>   qapi: add name parameter to nbd-server-add
>   qapi: add nbd-server-remove
>   iotest 147: add cases to test new @name parameter of nbd-server-add
>   iotests: implement QemuIoInteractive class
>   iotest 201: new test for qmp nbd-server-remove
>
>  qapi/block.json               |  27 ++++++++-
>  include/block/nbd.h           |   3 +-
>  blockdev-nbd.c                |  41 +++++++++++--
>  hmp.c                         |   5 +-
>  nbd/server.c                  |  31 +++++++++-
>  tests/qemu-iotests/147        |  68 +++++++++++++++++-----
>  tests/qemu-iotests/147.out    |   4 +-
>  tests/qemu-iotests/201        | 130 ++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/201.out    |   5 ++
>  tests/qemu-iotests/group      |   1 +
>  tests/qemu-iotests/iotests.py |  38 ++++++++++++
>  11 files changed, 325 insertions(+), 28 deletions(-)
>  create mode 100644 tests/qemu-iotests/201
>  create mode 100644 tests/qemu-iotests/201.out

Re: [Qemu-devel] [PATCH v2 0/6] nbd export qmp interface
Posted by Eric Blake 6 years, 3 months ago
On 12/21/2017 09:28 AM, Markus Armbruster wrote:
> Looks like you forgot to cc: Eric.  Fixing...

Or that he did cc me, and the mailman bug ate the cc line because of my 
list subscription settings.  (Have I mentioned that I hate that mailman 
2 bug, but don't know whether mailman 3 will make it any better?)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH v2 0/6] nbd export qmp interface
Posted by Vladimir Sementsov-Ogievskiy 6 years, 3 months ago
21.12.2017 21:32, Eric Blake wrote:
> On 12/21/2017 09:28 AM, Markus Armbruster wrote:
>> Looks like you forgot to cc: Eric. Fixing...
>
> Or that he did cc me, and the mailman bug ate the cc line because of 
> my list subscription settings.  (Have I mentioned that I hate that 
> mailman 2 bug, but don't know whether mailman 3 will make it any better?)
>

Hmm, when did it eat it? I've send this with git send-email, and in my 
thunderbird I see (through view->source)

From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: <qemu-devel@nongnu.org>, <qemu-block@nongnu.org>
CC: <armbru@redhat.com>, <dgilbert@redhat.com>, <pbonzini@redhat.com>,
	<eblake@redhat.com>, <mreitz@redhat.com>, <kwolf@redhat.com>,
	<vsementsov@virtuozzo.com>, <den@openvz.org>
Subject: [PATCH v2 0/6] nbd export qmp interface
Date: Thu, 7 Dec 2017 18:50:56 +0300
Message-ID: <20171207155102.66622-1-vsementsov@virtuozzo.com>



-- 
Best regards,
Vladimir


Re: [Qemu-devel] [PATCH v2 0/6] nbd export qmp interface
Posted by Eric Blake 6 years, 3 months ago
On 12/22/2017 02:53 AM, Vladimir Sementsov-Ogievskiy wrote:
> 21.12.2017 21:32, Eric Blake wrote:
>> On 12/21/2017 09:28 AM, Markus Armbruster wrote:
>>> Looks like you forgot to cc: Eric. Fixing...
>>
>> Or that he did cc me, and the mailman bug ate the cc line because of 
>> my list subscription settings.  (Have I mentioned that I hate that 
>> mailman 2 bug, but don't know whether mailman 3 will make it any better?)
>>
> 
> Hmm, when did it eat it? I've send this with git send-email, and in my 
> thunderbird I see (through view->source)

Mailman eats the cc line of anyone that sets the 'avoid duplicate emails 
to me' checkbox, but only for people that get the mail through mailman. 
If you get the email directly (as is true in this case), then you see 
the original cc's.  It's a highly annoying behavior of mailman 2; I wish 
there were two separate knobs (one for avoiding duplicates, one for 
controlling whether your name appears in cc), rather than one knob that 
does both things at once.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

[Qemu-devel] ping Re: [PATCH v2 0/6] nbd export qmp interface
Posted by Vladimir Sementsov-Ogievskiy 6 years, 3 months ago
Hi, what about this?

07.12.2017 18:50, Vladimir Sementsov-Ogievskiy wrote:
> Here:
>      1. separate export name from device name
>      1.1 several exports per device possible
>      2. add nbd-server-remove
>
> v2:
> 01: add r-bs by Max and Eric, add comment to code (hope you don't mind)
> 03: address export by its name, not by device name
>      make it possible to force-remove export, which is already
>      non-force-removed (thourh new "hidden" field)
> other patches are new
>
> v1:
> Add command to remove nbd export, pair to nbd-server-add.
> The whole thing and description are in patch 02.
>
>
> Vladimir Sementsov-Ogievskiy (6):
>    nbd/server: add additional assert to nbd_export_put
>    qapi: add name parameter to nbd-server-add
>    qapi: add nbd-server-remove
>    iotest 147: add cases to test new @name parameter of nbd-server-add
>    iotests: implement QemuIoInteractive class
>    iotest 201: new test for qmp nbd-server-remove
>
>   qapi/block.json               |  27 ++++++++-
>   include/block/nbd.h           |   3 +-
>   blockdev-nbd.c                |  41 +++++++++++--
>   hmp.c                         |   5 +-
>   nbd/server.c                  |  31 +++++++++-
>   tests/qemu-iotests/147        |  68 +++++++++++++++++-----
>   tests/qemu-iotests/147.out    |   4 +-
>   tests/qemu-iotests/201        | 130 ++++++++++++++++++++++++++++++++++++++++++
>   tests/qemu-iotests/201.out    |   5 ++
>   tests/qemu-iotests/group      |   1 +
>   tests/qemu-iotests/iotests.py |  38 ++++++++++++
>   11 files changed, 325 insertions(+), 28 deletions(-)
>   create mode 100644 tests/qemu-iotests/201
>   create mode 100644 tests/qemu-iotests/201.out
>


-- 
Best regards,
Vladimir