From nobody Fri May 3 04:48:35 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1512574239016421.1850555863771; Wed, 6 Dec 2017 07:30:39 -0800 (PST) Received: from localhost ([::1]:56272 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMbeG-0005Tw-Ux for importer@patchew.org; Wed, 06 Dec 2017 10:30:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMbdE-0004oJ-AU for qemu-devel@nongnu.org; Wed, 06 Dec 2017 10:29:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMbdB-0004dT-4L for qemu-devel@nongnu.org; Wed, 06 Dec 2017 10:29:08 -0500 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:35178) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eMbdA-0004d3-Sz for qemu-devel@nongnu.org; Wed, 06 Dec 2017 10:29:05 -0500 Received: by mail-wr0-x241.google.com with SMTP id g53so4335555wra.2 for ; Wed, 06 Dec 2017 07:29:04 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id l1sm2979094wmh.13.2017.12.06.07.29.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Dec 2017 07:29:02 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 333F63E039C; Wed, 6 Dec 2017 15:29:02 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jf+g5y6WM/jRIbnyZASYnkQwfDmgjB886R6IeSQn3FQ=; b=Lfh7z7l0mDklq8ZvNuPXMer4pidef48CEODy18qNjeh/x5HKtwfwzUi2jhbju3nIPj uBeTo/ANGQSdHmmCOdN4EArDzUDnbrH57kG0fM3oYz+s7ezjekxBfBCUL8a1se3LEi5Y wnchVoAytLToDtu7hcRFfOx2hL+CCnGPILUnQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jf+g5y6WM/jRIbnyZASYnkQwfDmgjB886R6IeSQn3FQ=; b=BP2hJ0oWiQ3qtJJyRmYLLR9FundNCM1mDFK/nF0Fh/Dvcycm2K5pSECMe6tkRPAbr6 4+tqfhJGDhevnS1Vc7djbeLuUWqlg8eW34A+GlFvwxsvns3V+v2tk3d+oLaXXHOGRf8P cwDnWWvvTVAh9pPFgid3eTsOPI+OINqLXBLDmEcJG3objFculyCdBjWO1Ya9Vqfo5rIa DTUoZB79sU+JfzESgIWf7Z+/I0sCh0Goy6/YqgZ4QRVTncCRYl73ig+sFigbSqldtc6k hbmbHP1NW6Sq2I7o8vP/JaRTYK9YiPqP+Id/fpkkXXwUOf1gABAWypWKoyumKKdD3YRy igwg== X-Gm-Message-State: AKGB3mK6Q0rhXqjkebuNpBOHuZRkp/j+g0IrosREjhJGMCwjZM/6uHad YfY7FbChFnOoq/KlKCpKEvlVYg== X-Google-Smtp-Source: AGs4zMa78U9ZY49Mg5SSpBNcqjFS3T76DIme6eafg99PPWy1fi3knmy8gWpKjzu/ODI1EvESn8U3zA== X-Received: by 10.223.135.179 with SMTP id b48mr13630197wrb.24.1512574143540; Wed, 06 Dec 2017 07:29:03 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Wed, 6 Dec 2017 15:28:45 +0000 Message-Id: <20171206152845.8215-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PATCH for 2.11] target/sh4/translate.c: fix TCG leak during gusa sequence X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org, Aurelien Jarno , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_6 Z_629925259 SPT_0 This fixes bug #1735384 while running java under qemu-sh4. When debug was enabled it showed a problem with TCG temps. Once fixed I was able to run java -version normally. Reported-by: John Paul Adrian Glaubitz Suggested-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson Tested-by: John Paul Adrian Glaubitz Cc: qemu-stable@nongnu.org --- target/sh4/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 703020fe87..b4b5c822d0 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -2189,7 +2189,7 @@ static int decode_gusa(DisasContext *ctx, CPUSH4State= *env, int *pmax_insns) } =20 /* If op_src is not a valid register, then op_arg was a constant. */ - if (op_src < 0) { + if (op_src < 0 && !TCGV_IS_UNUSED(op_arg)) { tcg_temp_free_i32(op_arg); } =20 --=20 2.15.1