From nobody Mon Apr 29 13:02:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1512561850241286.638803371334; Wed, 6 Dec 2017 04:04:10 -0800 (PST) Received: from localhost ([::1]:55114 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMYQp-0006Qr-1U for importer@patchew.org; Wed, 06 Dec 2017 07:04:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMYPV-0005qM-3v for qemu-devel@nongnu.org; Wed, 06 Dec 2017 07:02:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMYPQ-000525-3W for qemu-devel@nongnu.org; Wed, 06 Dec 2017 07:02:45 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:39466 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eMYPP-000512-Te for qemu-devel@nongnu.org; Wed, 06 Dec 2017 07:02:40 -0500 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vB6BxJou120829 for ; Wed, 6 Dec 2017 07:02:37 -0500 Received: from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209]) by mx0b-001b2d01.pphosted.com with ESMTP id 2epcha2y3v-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 06 Dec 2017 07:02:35 -0500 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 Dec 2017 07:02:35 -0500 Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25) by e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 6 Dec 2017 07:02:32 -0500 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id vB6C2WYJ48824532; Wed, 6 Dec 2017 12:02:32 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B192FAC03A; Wed, 6 Dec 2017 07:03:31 -0500 (EST) Received: from localhost.localdomain (unknown [9.80.229.1]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP id 450FFAC040; Wed, 6 Dec 2017 07:03:30 -0500 (EST) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Date: Wed, 6 Dec 2017 10:02:15 -0200 X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171206120217.11392-1-danielhb@linux.vnet.ibm.com> References: <20171206120217.11392-1-danielhb@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 17120612-0056-0000-0000-000003F48BFA X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008159; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000244; SDB=6.00956234; UDB=6.00483355; IPR=6.00736271; BA=6.00005729; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018380; XFM=3.00000015; UTC=2017-12-06 12:02:34 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17120612-0057-0000-0000-0000082BC1F2 Message-Id: <20171206120217.11392-2-danielhb@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-12-06_05:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712060175 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.158.5 Subject: [Qemu-devel] [PATCH 1/3] qmp: introduce query-wakeup-from-suspend-support command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com, Daniel Henrique Barboza , armbru@redhat.com, dgilbert@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When issuing the qmp/hmp 'system_wakeup' command, what happens in a nutshell is: - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason and notify the event - in the main_loop, all vcpus are paused, a system reset is issued, all subscribers of wakeup_notifiers receives a notification, vcpus are then resumed and the wake up QAPI event is fired Note that this procedure alone doesn't ensure that the guest will awake from SUSPENDED state - the subscribers of the wake up event must take action to resume the guest, otherwise the guest will simply reboot. At this moment there are only two subscribers of the wake up event: one in hw/acpi/core.c and another one in hw/i386/xen/xen-hvm.c. This means that system_wakeup does not work as intended with other architectures. However, only the presence of 'system_wakeup' is required for QGA to support 'guest-suspend-ram' and 'guest-suspend-hybrid' at this moment. This means that the user/management will expect to suspend the guest using one of those suspend commands and then resume execution using system_wakeup, regardless of the support offered in system_wakeup in the first place. This patch implements a new QMP command called 'query-wakeup-from-suspend-support' that allows the caller to query if the guest supports wake up from suspend via system_wakeup. It goes over the subscribers of the wake up event and, if it's empty, it assumes that the guest does not support wake up from suspend (and thus, pm-suspend itself). This is the expected output of the command when running a x86 guest: {"execute" : "query-wakeup-from-suspend-support"} {"return": {"enabled": true}} This is the output when running a pseries guest: {"execute" : "query-wakeup-from-suspend-support"} {"return": {"enabled": false}} With this extra tool, management can avoid situations where a guest that does not have proper suspend/wake capabilities ends up in inconsistent state (e.g. https://github.com/open-power-host-os/qemu/issues/31). Signed-off-by: Daniel Henrique Barboza --- include/sysemu/sysemu.h | 1 + qapi-schema.json | 23 +++++++++++++++++++++++ qmp.c | 9 +++++++++ vl.c | 5 +++++ 4 files changed, 38 insertions(+) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index c083869fcf..70b94dcda5 100644 --- a/include/sysemu/sysemu.h +++ b/include/sysemu/sysemu.h @@ -69,6 +69,7 @@ typedef enum WakeupReason { void qemu_system_reset_request(ShutdownCause reason); void qemu_system_suspend_request(void); void qemu_register_suspend_notifier(Notifier *notifier); +bool qemu_wakeup_notifier_is_empty(void); void qemu_system_wakeup_request(WakeupReason reason); void qemu_system_wakeup_enable(WakeupReason reason, bool enabled); void qemu_register_wakeup_notifier(Notifier *notifier); diff --git a/qapi-schema.json b/qapi-schema.json index 18457954a8..cf5bf327bd 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3200,3 +3200,26 @@ # Since: 2.11 ## { 'command': 'watchdog-set-action', 'data' : {'action': 'WatchdogAction'} } + +## +# @WakeupSuspendSupportInfo: +# +# Information about the wake up from suspend support of the VM. +# +# @enabled: true if the target supports wake up from suspend +# +# Since: 2.12 +## +{ 'struct': 'WakeupSuspendSupportInfo', + 'data': { 'enabled': 'bool' } } + +## +# @query-wakeup-from-suspend-support: +# +# Return information about the wake up from suspend support of the VM. +# +# Returns: WakeupSuspendSupportInfo +# +# Since: 2.12 +## +{ 'command': 'query-wakeup-from-suspend-support', 'returns': 'WakeupSuspen= dSupportInfo' } diff --git a/qmp.c b/qmp.c index e8c303116a..26fefbbe88 100644 --- a/qmp.c +++ b/qmp.c @@ -722,3 +722,12 @@ MemoryInfo *qmp_query_memory_size_summary(Error **errp) =20 return mem_info; } + +WakeupSuspendSupportInfo *qmp_query_wakeup_from_suspend_support(Error **er= rp) +{ + WakeupSuspendSupportInfo *info =3D g_malloc0(sizeof(*info)); + + info->enabled =3D !qemu_wakeup_notifier_is_empty(); + + return info; +} diff --git a/vl.c b/vl.c index 1ad1c04637..b07aa6f098 100644 --- a/vl.c +++ b/vl.c @@ -1889,6 +1889,11 @@ void qemu_register_wakeup_notifier(Notifier *notifie= r) notifier_list_add(&wakeup_notifiers, notifier); } =20 +bool qemu_wakeup_notifier_is_empty(void) +{ + return QLIST_EMPTY(&wakeup_notifiers.notifiers); +} + void qemu_system_killed(int signal, pid_t pid) { shutdown_signal =3D signal; --=20 2.13.6 From nobody Mon Apr 29 13:02:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1512561981593947.4077717310203; Wed, 6 Dec 2017 04:06:21 -0800 (PST) Received: from localhost ([::1]:55129 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMYSv-0007tb-K8 for importer@patchew.org; Wed, 06 Dec 2017 07:06:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMYPV-0005qN-MA for qemu-devel@nongnu.org; Wed, 06 Dec 2017 07:02:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMYPQ-00052V-N7 for qemu-devel@nongnu.org; Wed, 06 Dec 2017 07:02:45 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:60246 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eMYPQ-00052G-Hu for qemu-devel@nongnu.org; Wed, 06 Dec 2017 07:02:40 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vB6BxFGP004166 for ; Wed, 6 Dec 2017 07:02:40 -0500 Received: from e12.ny.us.ibm.com (e12.ny.us.ibm.com [129.33.205.202]) by mx0b-001b2d01.pphosted.com with ESMTP id 2epdk68bd5-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 06 Dec 2017 07:02:39 -0500 Received: from localhost by e12.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 Dec 2017 07:02:37 -0500 Received: from b01cxnp23033.gho.pok.ibm.com (9.57.198.28) by e12.ny.us.ibm.com (146.89.104.199) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 6 Dec 2017 07:02:35 -0500 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id vB6C2ZAV36634780; Wed, 6 Dec 2017 12:02:35 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8129CAC043; Wed, 6 Dec 2017 07:03:34 -0500 (EST) Received: from localhost.localdomain (unknown [9.80.229.1]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP id 1BCCCAC040; Wed, 6 Dec 2017 07:03:32 -0500 (EST) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Date: Wed, 6 Dec 2017 10:02:16 -0200 X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171206120217.11392-1-danielhb@linux.vnet.ibm.com> References: <20171206120217.11392-1-danielhb@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 17120612-0048-0000-0000-000002108D2F X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008159; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000244; SDB=6.00956234; UDB=6.00483355; IPR=6.00736271; BA=6.00005729; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018380; XFM=3.00000015; UTC=2017-12-06 12:02:36 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17120612-0049-0000-0000-00004361494A Message-Id: <20171206120217.11392-3-danielhb@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-12-06_05:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712060175 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.158.5 Subject: [Qemu-devel] [PATCH 2/3] hmp: introduce wakeup-from-suspend-support command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com, Daniel Henrique Barboza , armbru@redhat.com, dgilbert@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This is the HMP side of 'query-wakeup-from-suspend-support', a new QMP command that queries the guest support for system_wakeup. This is the expected output of the new command when running a x86 guest: (qemu) info wakeup_from_suspend_support wake up from suspend support: enabled (qemu) And when running a pseries guest: (qemu) info wakeup_from_suspend_support wake up from suspend support: disabled (qemu) Signed-off-by: Daniel Henrique Barboza --- hmp-commands-info.hx | 15 +++++++++++++++ hmp.c | 11 +++++++++++ hmp.h | 1 + 3 files changed, 27 insertions(+) diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 54c3e5eac6..9d5e93bfcf 100644 --- a/hmp-commands-info.hx +++ b/hmp-commands-info.hx @@ -867,6 +867,21 @@ Display the amount of initially allocated and present = hotpluggable (if enabled) memory in bytes. ETEXI =20 + { + .name =3D "wakeup_from_suspend_support", + .args_type =3D "", + .params =3D "", + .help =3D "shows if the guest has support for wake up " + "from suspend", + .cmd =3D hmp_info_wakeup_from_suspend_support, + }, + +STEXI +@item info wakeup_from_suspend_support +@findex info wakeup_from_suspend_support +Shows if the guest has support for wake up from suspended state. +ETEXI + STEXI @end table ETEXI diff --git a/hmp.c b/hmp.c index 35a7041824..3b74b9ee19 100644 --- a/hmp.c +++ b/hmp.c @@ -2918,3 +2918,14 @@ void hmp_info_memory_size_summary(Monitor *mon, cons= t QDict *qdict) } hmp_handle_error(mon, &err); } + +void hmp_info_wakeup_from_suspend_support(Monitor *mon, const QDict *qdict) +{ + WakeupSuspendSupportInfo *info; + + info =3D qmp_query_wakeup_from_suspend_support(NULL); + monitor_printf(mon, "wake up from suspend support: %s\n", + info->enabled ? "enabled" : "disabled"); + + qapi_free_WakeupSuspendSupportInfo(info); +} diff --git a/hmp.h b/hmp.h index a6f56b1f29..2d394cbec2 100644 --- a/hmp.h +++ b/hmp.h @@ -147,5 +147,6 @@ void hmp_info_ramblock(Monitor *mon, const QDict *qdict= ); void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict); void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict); void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict); +void hmp_info_wakeup_from_suspend_support(Monitor *mon, const QDict *qdict= ); =20 #endif --=20 2.13.6 From nobody Mon Apr 29 13:02:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1512562068171773.9694558470743; Wed, 6 Dec 2017 04:07:48 -0800 (PST) Received: from localhost ([::1]:55138 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMYUD-0000Mg-CQ for importer@patchew.org; Wed, 06 Dec 2017 07:07:37 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMYPb-0005ta-Cs for qemu-devel@nongnu.org; Wed, 06 Dec 2017 07:02:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMYPW-00057q-Dn for qemu-devel@nongnu.org; Wed, 06 Dec 2017 07:02:51 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:60654) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eMYPW-00057I-56 for qemu-devel@nongnu.org; Wed, 06 Dec 2017 07:02:46 -0500 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vB6C246d028451 for ; Wed, 6 Dec 2017 07:02:43 -0500 Received: from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201]) by mx0a-001b2d01.pphosted.com with ESMTP id 2epdy17rrt-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 06 Dec 2017 07:02:42 -0500 Received: from localhost by e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 Dec 2017 07:02:41 -0500 Received: from b01cxnp23034.gho.pok.ibm.com (9.57.198.29) by e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 6 Dec 2017 07:02:38 -0500 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id vB6C2bZW45416678; Wed, 6 Dec 2017 12:02:37 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 79C97AC03F; Wed, 6 Dec 2017 07:03:37 -0500 (EST) Received: from localhost.localdomain (unknown [9.80.229.1]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP id 042BEAC03A; Wed, 6 Dec 2017 07:03:35 -0500 (EST) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Date: Wed, 6 Dec 2017 10:02:17 -0200 X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171206120217.11392-1-danielhb@linux.vnet.ibm.com> References: <20171206120217.11392-1-danielhb@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 17120612-2213-0000-0000-000002469240 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008159; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000244; SDB=6.00956234; UDB=6.00483355; IPR=6.00736271; BA=6.00005729; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018380; XFM=3.00000015; UTC=2017-12-06 12:02:39 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17120612-2214-0000-0000-0000585D6F47 Message-Id: <20171206120217.11392-4-danielhb@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-12-06_05:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712060175 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.156.1 Subject: [Qemu-devel] [PATCH 3/3] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com, Daniel Henrique Barboza , armbru@redhat.com, dgilbert@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch updates the descriptions of 'guest-suspend-ram' and 'guest-suspend-hybrid' to mention that both commands relies now on the existence of 'system_wakeup' and also on the proper support for wake up from suspend, retrieved by the QMP command 'query-wakeup-from-suspend-support'. Signed-off-by: Daniel Henrique Barboza --- qga/qapi-schema.json | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 17884c7c70..d64ada304b 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -566,8 +566,10 @@ # package installed in the guest. # # IMPORTANT: guest-suspend-ram requires QEMU to support the 'system_wakeup' -# command. Thus, it's *required* to query QEMU for the presence of the -# 'system_wakeup' command before issuing guest-suspend-ram. +# command and the guest to support wake up from suspend. Thus, it's +# *required* to query QEMU for the presence of the 'system_wakeup' command +# and to verify that wake up from suspend is enabled using +# 'query-wakeup-from-suspend-support' before issuing guest-suspend-ram. # # This command does NOT return a response on success. There are two options # to check for success: @@ -593,8 +595,10 @@ # This command requires the pm-utils package to be installed in the guest. # # IMPORTANT: guest-suspend-hybrid requires QEMU to support the 'system_wak= eup' -# command. Thus, it's *required* to query QEMU for the presence of the -# 'system_wakeup' command before issuing guest-suspend-hybrid. +# command and the guest to support wake up from suspend. Thus, it's +# *required* to query QEMU for the presence of the 'system_wakeup' command +# and to verify that wake up from suspend is enabled using +# 'query-wakeup-from-suspend-support' before issuing guest-suspend-hybrid. # # This command does NOT return a response on success. There are two options # to check for success: --=20 2.13.6