[Qemu-devel] [PULL 0/1] baum braille device update

Samuel Thibault posted 1 patch 6 years, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171204151705.26028-1-samuel.thibault@ens-lyon.org
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
chardev/baum.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
[Qemu-devel] [PULL 0/1] baum braille device update
Posted by Samuel Thibault 6 years, 3 months ago
warning: redirection vers https://people.debian.org/~sthibault/qemu.git/
The following changes since commit 7edaf99759017d3e175e37cffc3536e86a3bd380:

  Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into staging (2017-11-13 13:54:59 +0000)

are available in the Git repository at:

  http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault

for you to fetch changes up to 15405525fce773d43e7e5cabc2b9ac4b9d4d7672:

  baum: Truncate braille device size to 84x1 (2017-12-03 19:35:50 +0100)

----------------------------------------------------------------
baum updates

----------------------------------------------------------------
Samuel Thibault (1):
      baum: Truncate braille device size to 84x1

 chardev/baum.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PULL 0/1] baum braille device update
Posted by Peter Maydell 6 years, 3 months ago
On 4 December 2017 at 15:17, Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
> warning: redirection vers https://people.debian.org/~sthibault/qemu.git/
> The following changes since commit 7edaf99759017d3e175e37cffc3536e86a3bd380:
>
>   Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into staging (2017-11-13 13:54:59 +0000)
>
> are available in the Git repository at:
>
>   http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
>
> for you to fetch changes up to 15405525fce773d43e7e5cabc2b9ac4b9d4d7672:
>
>   baum: Truncate braille device size to 84x1 (2017-12-03 19:35:50 +0100)
>
> ----------------------------------------------------------------
> baum updates
>
> ----------------------------------------------------------------
> Samuel Thibault (1):
>       baum: Truncate braille device size to 84x1

Hi. Is this pull request intended for 2.11? We're currently
in freeze for that and only taking "absolutely release critical"
bug fixes...

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/1] baum braille device update
Posted by Samuel Thibault 6 years, 3 months ago
Hello,

Peter Maydell, on lun. 04 déc. 2017 15:21:48 +0000, wrote:
> On 4 December 2017 at 15:17, Samuel Thibault
> <samuel.thibault@ens-lyon.org> wrote:
> > warning: redirection vers https://people.debian.org/~sthibault/qemu.git/
> > The following changes since commit 7edaf99759017d3e175e37cffc3536e86a3bd380:
> >
> >   Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into staging (2017-11-13 13:54:59 +0000)
> >
> > are available in the Git repository at:
> >
> >   http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
> >
> > for you to fetch changes up to 15405525fce773d43e7e5cabc2b9ac4b9d4d7672:
> >
> >   baum: Truncate braille device size to 84x1 (2017-12-03 19:35:50 +0100)
> >
> > ----------------------------------------------------------------
> > baum updates
> >
> > ----------------------------------------------------------------
> > Samuel Thibault (1):
> >       baum: Truncate braille device size to 84x1
> 
> Hi. Is this pull request intended for 2.11?

If possible, yes.

> We're currently in freeze for that and only taking "absolutely release
> critical" bug fixes...

Ok, as you wish.

It's a relatively corner case: a friend of mine does have a 88-cell
braille display, and can not use it with guests by running qemu
-usbdevice braille due to this bug.

Samuel

Re: [Qemu-devel] [PULL 0/1] baum braille device update
Posted by Peter Maydell 6 years, 3 months ago
On 4 December 2017 at 15:26, Samuel Thibault <samuel.thibault@gnu.org> wrote:
> Hello,
>
> Peter Maydell, on lun. 04 déc. 2017 15:21:48 +0000, wrote:
>> On 4 December 2017 at 15:17, Samuel Thibault
>> <samuel.thibault@ens-lyon.org> wrote:
>> > ----------------------------------------------------------------
>> > Samuel Thibault (1):
>> >       baum: Truncate braille device size to 84x1
>>
>> Hi. Is this pull request intended for 2.11?
>
> If possible, yes.
>
>> We're currently in freeze for that and only taking "absolutely release
>> critical" bug fixes...
>
> Ok, as you wish.
>
> It's a relatively corner case: a friend of mine does have a 88-cell
> braille display, and can not use it with guests by running qemu
> -usbdevice braille due to this bug.

Mmm. Looking at the code for baum.c for 2.10, this isn't a
regression from 2.10 or a security issue, which is what it
would need to be for us to want to put this in at this point.

Also, looking in my mail archives I couldn't find where
this patch was initially posted on the list for review. Our
process is that all patches have to be posted for review first,
they can't just go straight into a pull request.

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/1] baum braille device update
Posted by Samuel Thibault 6 years, 3 months ago
Peter Maydell, on lun. 04 déc. 2017 15:36:32 +0000, wrote:
> On 4 December 2017 at 15:26, Samuel Thibault <samuel.thibault@gnu.org> wrote:
> > Peter Maydell, on lun. 04 déc. 2017 15:21:48 +0000, wrote:
> >> On 4 December 2017 at 15:17, Samuel Thibault
> >> <samuel.thibault@ens-lyon.org> wrote:
> >> > ----------------------------------------------------------------
> >> > Samuel Thibault (1):
> >> >       baum: Truncate braille device size to 84x1
> >>
> >> Hi. Is this pull request intended for 2.11?
> >
> > If possible, yes.
> >
> >> We're currently in freeze for that and only taking "absolutely release
> >> critical" bug fixes...
> >
> > Ok, as you wish.
> >
> > It's a relatively corner case: a friend of mine does have a 88-cell
> > braille display, and can not use it with guests by running qemu
> > -usbdevice braille due to this bug.
> 
> Mmm. Looking at the code for baum.c for 2.10, this isn't a
> regression from 2.10 or a security issue, which is what it
> would need to be for us to want to put this in at this point.

Ah, ok, nevermind then, it'll have to wait.

Sorry I didn't know that.

Samuel