[Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration

Juan Quintela posted 6 patches 6 years, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171201125813.1437-1-quintela@redhat.com
Test checkpatch passed
Test docker failed
Test ppc passed
Test s390x passed
There is a newer version of this series
tests/migration-test.c | 257 +++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 247 insertions(+), 10 deletions(-)
[Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration
Posted by Juan Quintela 6 years, 4 months ago
Hi

This is on top of my info_migrate series.

CHanges:

- No more tests for deprecated parameters. Now I only use
  migrate_set_parameter.  If there is a deprecated command for that,
  we tests it there.
- free "result" string, always good to return memory (Peter found it)
- use the new tcp_port parameter from info migrate.  So we are
  handling well the tcp case.
- lots of code movement around to make everything consistent.
- Several patches already integrated upstream.

Later, Juan.


[v2]
- to make review easier, I started renaming postcopy-test.c to migration-test.c
- Did cleanups/refactoring there
- Don't use global-qtest anymore
- check that the parameters that we sent got really set
- RFH: comrpress threads tests is not working for some weird reason.  Using the same code on command line works.
  still investigating why.

ToDoo:

- tcp: after discussions with dave, we ended in conclusion that we
  need to use the 0 port and let the system gives us a free one

  But .... that means that we need to be able to get that port back somehow.
  "info migrate" woring on destination side?

- compression threads.  There is some weird interaction with the test
  hardness and every migration thread get waiting in a different
  semaphore.  Investigating if it is a race/bug/whateverr

- deprecated commands: There was a suggestion to make
  migrate_set_parameter look at the parameter name and test old/new
  depending on something.  Not sure what to do here.

- testing commands: Is there a way to launch qemu and just sent
  qmp/hmp commands without having to really run anything else?

Please review,.

Later, Juan.

[v1]
- add test for precopy for unix/tcp
  exec and fd to came, don't know how to test rdma without hardware
- add tests using deprecated interfaces
- add test for xbzrle
  Note to myself, there is no way to set the cache size with migraton_set_parameters
- Add test for compress threads
  disabled on the series, right now it appears that compression is not working at all
- Move postcopy to use new results
  Idea is to move it on top of migration-test.c, but first I want some reviews on basic idea

Please, review.

Juan.

Juan Quintela (6):
  migration: free result string
  tests: migration test deprecated commands
  tests: Add migration precopy test
  tests: Add basic migration precopy tcp test
  tests: Add migration xbzrle test
  [RFH] tests: Add migration compress threads tests

 tests/migration-test.c | 257 +++++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 247 insertions(+), 10 deletions(-)

-- 
2.14.3


Re: [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration
Posted by Eric Blake 6 years, 4 months ago
On 12/01/2017 06:58 AM, Juan Quintela wrote:
> Hi
> 
> This is on top of my info_migrate series.

Let patchew know about it:

Based-on: <20171201125750.1372-1-quintela@redhat.com>
([PATCH v3 0/2] Improve info migrate output on destination)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration
Posted by Laurent Vivier 6 years, 4 months ago
On 01/12/2017 19:30, Eric Blake wrote:
> On 12/01/2017 06:58 AM, Juan Quintela wrote:
>> Hi
>>
>> This is on top of my info_migrate series.
> 
> Let patchew know about it:
> 
> Based-on: <20171201125750.1372-1-quintela@redhat.com>
> ([PATCH v3 0/2] Improve info migrate output on destination)

Is this tag documented somewhere?

Thanks,
Laurent

Re: [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration
Posted by Eric Blake 6 years, 4 months ago
On 12/01/2017 12:38 PM, Laurent Vivier wrote:
> On 01/12/2017 19:30, Eric Blake wrote:
>> On 12/01/2017 06:58 AM, Juan Quintela wrote:
>>> Hi
>>>
>>> This is on top of my info_migrate series.
>>
>> Let patchew know about it:
>>
>> Based-on: <20171201125750.1372-1-quintela@redhat.com>
>> ([PATCH v3 0/2] Improve info migrate output on destination)
> 
> Is this tag documented somewhere?
> 

https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg01288.html

But yes, it should also be documented in the wiki and/or other places 
where we document patch submission guidelines.

Volunteers?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration
Posted by Eric Blake 6 years, 3 months ago
On 12/01/2017 12:44 PM, Eric Blake wrote:
> On 12/01/2017 12:38 PM, Laurent Vivier wrote:
>> On 01/12/2017 19:30, Eric Blake wrote:
>>> On 12/01/2017 06:58 AM, Juan Quintela wrote:
>>>> Hi
>>>>
>>>> This is on top of my info_migrate series.
>>>
>>> Let patchew know about it:
>>>
>>> Based-on: <20171201125750.1372-1-quintela@redhat.com>
>>> ([PATCH v3 0/2] Improve info migrate output on destination)
>>
>> Is this tag documented somewhere?
>>
> 
> https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg01288.html
> 
> But yes, it should also be documented in the wiki and/or other places
> where we document patch submission guidelines.
> 
> Volunteers?

I've updated https://wiki.qemu.org/Contribute/SubmitAPatch to mention
patchew and the Based-on tag line, but there may still be other places
worth updating.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org