[Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c

Cornelia Huck posted 1 patch 6 years, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171130140536.31164-1-cohuck@redhat.com
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
target/s390x/helper.c | 18 ------------------
1 file changed, 18 deletions(-)
[Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c
Posted by Cornelia Huck 6 years, 4 months ago
It is not used anywhere.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 target/s390x/helper.c | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/target/s390x/helper.c b/target/s390x/helper.c
index 246ba20f0d..35d9741918 100644
--- a/target/s390x/helper.c
+++ b/target/s390x/helper.c
@@ -31,24 +31,6 @@
 #include "sysemu/sysemu.h"
 #endif
 
-//#define DEBUG_S390
-//#define DEBUG_S390_STDOUT
-
-#ifdef DEBUG_S390
-#ifdef DEBUG_S390_STDOUT
-#define DPRINTF(fmt, ...) \
-    do { fprintf(stderr, fmt, ## __VA_ARGS__); \
-         if (qemu_log_separate()) qemu_log(fmt, ##__VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
-    do { qemu_log(fmt, ## __VA_ARGS__); } while (0)
-#endif
-#else
-#define DPRINTF(fmt, ...) \
-    do { } while (0)
-#endif
-
-
 #ifndef CONFIG_USER_ONLY
 void s390x_tod_timer(void *opaque)
 {
-- 
2.13.6


Re: [Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c
Posted by Eric Blake 6 years, 4 months ago
On 11/30/2017 08:05 AM, Cornelia Huck wrote:
> It is not used anywhere.
> 
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>   target/s390x/helper.c | 18 ------------------
>   1 file changed, 18 deletions(-)

Yay! One less spot for bit-rotten debug.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c
Posted by David Hildenbrand 6 years, 4 months ago
On 30.11.2017 15:05, Cornelia Huck wrote:
> It is not used anywhere.
> 
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>  target/s390x/helper.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/target/s390x/helper.c b/target/s390x/helper.c
> index 246ba20f0d..35d9741918 100644
> --- a/target/s390x/helper.c
> +++ b/target/s390x/helper.c
> @@ -31,24 +31,6 @@
>  #include "sysemu/sysemu.h"
>  #endif
>  
> -//#define DEBUG_S390
> -//#define DEBUG_S390_STDOUT
> -
> -#ifdef DEBUG_S390
> -#ifdef DEBUG_S390_STDOUT
> -#define DPRINTF(fmt, ...) \
> -    do { fprintf(stderr, fmt, ## __VA_ARGS__); \
> -         if (qemu_log_separate()) qemu_log(fmt, ##__VA_ARGS__); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> -    do { qemu_log(fmt, ## __VA_ARGS__); } while (0)
> -#endif
> -#else
> -#define DPRINTF(fmt, ...) \
> -    do { } while (0)
> -#endif
> -
> -
>  #ifndef CONFIG_USER_ONLY
>  void s390x_tod_timer(void *opaque)
>  {
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 

Thanks,

David / dhildenb

Re: [Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c
Posted by Thomas Huth 6 years, 4 months ago
On 30.11.2017 15:29, David Hildenbrand wrote:
> On 30.11.2017 15:05, Cornelia Huck wrote:
>> It is not used anywhere.
Right, looks like I move the last user of this macro away during the
--disable-tcg rework.

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH] target/s390x: nuke DPRINTF in helper.c
Posted by Cornelia Huck 6 years, 4 months ago
On Thu, 30 Nov 2017 15:05:36 +0100
Cornelia Huck <cohuck@redhat.com> wrote:

> It is not used anywhere.
> 
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>  target/s390x/helper.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/target/s390x/helper.c b/target/s390x/helper.c
> index 246ba20f0d..35d9741918 100644
> --- a/target/s390x/helper.c
> +++ b/target/s390x/helper.c
> @@ -31,24 +31,6 @@
>  #include "sysemu/sysemu.h"
>  #endif
>  
> -//#define DEBUG_S390
> -//#define DEBUG_S390_STDOUT
> -
> -#ifdef DEBUG_S390
> -#ifdef DEBUG_S390_STDOUT
> -#define DPRINTF(fmt, ...) \
> -    do { fprintf(stderr, fmt, ## __VA_ARGS__); \
> -         if (qemu_log_separate()) qemu_log(fmt, ##__VA_ARGS__); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> -    do { qemu_log(fmt, ## __VA_ARGS__); } while (0)
> -#endif
> -#else
> -#define DPRINTF(fmt, ...) \
> -    do { } while (0)
> -#endif
> -
> -
>  #ifndef CONFIG_USER_ONLY
>  void s390x_tod_timer(void *opaque)
>  {

Queued to s390-next.