[Qemu-devel] [PATCH 0/3] macro do/while (0) cleanup

Eric Blake posted 3 patches 6 years, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171130134159.9697-1-eblake@redhat.com
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
There is a newer version of this series
tests/acpi-utils.h         |  8 ++++----
ui/sdl_zoom_template.h     |  8 ++++----
audio/paaudio.c            |  4 ++--
hw/adc/stm32f2xx_adc.c     |  2 +-
hw/block/m25p80.c          |  2 +-
hw/char/cadence_uart.c     |  2 +-
hw/char/stm32f2xx_usart.c  |  2 +-
hw/display/cg3.c           |  2 +-
hw/display/dpcd.c          |  2 +-
hw/display/xlnx_dp.c       |  2 +-
hw/dma/pl330.c             |  2 +-
hw/dma/xlnx-zynq-devcfg.c  |  2 +-
hw/dma/xlnx_dpdma.c        |  2 +-
hw/i2c/i2c-ddc.c           |  2 +-
hw/misc/auxbus.c           |  2 +-
hw/misc/macio/mac_dbdma.c  |  4 ++--
hw/misc/mmio_interface.c   |  2 +-
hw/misc/stm32f2xx_syscfg.c |  2 +-
hw/misc/zynq_slcr.c        |  2 +-
hw/net/cadence_gem.c       |  2 +-
hw/net/pcnet.c             | 20 ++++++++++----------
hw/ssi/mss-spi.c           |  2 +-
hw/ssi/stm32f2xx_spi.c     |  2 +-
hw/ssi/xilinx_spi.c        |  2 +-
hw/ssi/xilinx_spips.c      |  2 +-
hw/timer/a9gtimer.c        |  2 +-
hw/timer/cadence_ttc.c     |  2 +-
hw/timer/mss-timer.c       |  2 +-
hw/timer/stm32f2xx_timer.c |  2 +-
hw/tpm/tpm_passthrough.c   |  2 +-
hw/tpm/tpm_tis.c           |  2 +-
migration/rdma.c           |  2 +-
target/arm/translate-a64.c |  2 +-
target/mips/msa_helper.c   | 34 ++++++++++++++++++----------------
target/s390x/kvm.c         |  2 +-
tests/tcg/test-mmap.c      |  2 +-
36 files changed, 70 insertions(+), 68 deletions(-)
[Qemu-devel] [PATCH 0/3] macro do/while (0) cleanup
Posted by Eric Blake 6 years, 4 months ago
Noticed this by chance in the tests/ directory, so I broadened
it to a grep of the entire code base.  I suspect many of the
bad macros were the victims of copy-and-paste from some other
bad location (particularly given how many bit-rotten debug
print macros were involved).

https://wiki.qemu.org/BiteSizedTasks#Bitrot_prevention is still
left for someone else, for another day.

Eric Blake (3):
  net: Drop unusual use of do { } while (0);
  mips: Tweak location of ';' in macros
  maint: Fix macros with broken 'do/while(0);' usage

 tests/acpi-utils.h         |  8 ++++----
 ui/sdl_zoom_template.h     |  8 ++++----
 audio/paaudio.c            |  4 ++--
 hw/adc/stm32f2xx_adc.c     |  2 +-
 hw/block/m25p80.c          |  2 +-
 hw/char/cadence_uart.c     |  2 +-
 hw/char/stm32f2xx_usart.c  |  2 +-
 hw/display/cg3.c           |  2 +-
 hw/display/dpcd.c          |  2 +-
 hw/display/xlnx_dp.c       |  2 +-
 hw/dma/pl330.c             |  2 +-
 hw/dma/xlnx-zynq-devcfg.c  |  2 +-
 hw/dma/xlnx_dpdma.c        |  2 +-
 hw/i2c/i2c-ddc.c           |  2 +-
 hw/misc/auxbus.c           |  2 +-
 hw/misc/macio/mac_dbdma.c  |  4 ++--
 hw/misc/mmio_interface.c   |  2 +-
 hw/misc/stm32f2xx_syscfg.c |  2 +-
 hw/misc/zynq_slcr.c        |  2 +-
 hw/net/cadence_gem.c       |  2 +-
 hw/net/pcnet.c             | 20 ++++++++++----------
 hw/ssi/mss-spi.c           |  2 +-
 hw/ssi/stm32f2xx_spi.c     |  2 +-
 hw/ssi/xilinx_spi.c        |  2 +-
 hw/ssi/xilinx_spips.c      |  2 +-
 hw/timer/a9gtimer.c        |  2 +-
 hw/timer/cadence_ttc.c     |  2 +-
 hw/timer/mss-timer.c       |  2 +-
 hw/timer/stm32f2xx_timer.c |  2 +-
 hw/tpm/tpm_passthrough.c   |  2 +-
 hw/tpm/tpm_tis.c           |  2 +-
 migration/rdma.c           |  2 +-
 target/arm/translate-a64.c |  2 +-
 target/mips/msa_helper.c   | 34 ++++++++++++++++++----------------
 target/s390x/kvm.c         |  2 +-
 tests/tcg/test-mmap.c      |  2 +-
 36 files changed, 70 insertions(+), 68 deletions(-)

-- 
2.14.3