From nobody Fri May 3 13:04:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1511880948643960.030363836322; Tue, 28 Nov 2017 06:55:48 -0800 (PST) Received: from localhost ([::1]:38368 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJhIL-0003W9-A8 for importer@patchew.org; Tue, 28 Nov 2017 09:55:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJhHO-0002nA-Ii for qemu-devel@nongnu.org; Tue, 28 Nov 2017 09:54:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJhHI-0002Z9-VX for qemu-devel@nongnu.org; Tue, 28 Nov 2017 09:54:34 -0500 Received: from fanzine.igalia.com ([91.117.99.155]:41736) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJhHI-0002QD-IU; Tue, 28 Nov 2017 09:54:28 -0500 Received: from [194.100.51.2] (helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1eJhGg-00055I-78; Tue, 28 Nov 2017 15:53:50 +0100 Received: from berto by perseus.local with local (Exim 4.89) (envelope-from ) id 1eJhGO-0004Uu-0N; Tue, 28 Nov 2017 16:53:32 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Message-Id:Date:Subject:Cc:To:From; bh=DLgLyfE6YMUaRmd0IH/+yZWUXAVOxQrJFA5xUBgNQAI=; b=ZPQBFZAoPpHeGUYeT/CIuKJr+9FMZlA5ELyF1KIv1eANDz/INTcKqGzX1sUq982AxUnMsB3AjGa0DnuNnuAhawlcxWSeGNdPGv3CPWa0Z9hU8f7f4eqSxKi1DfP6KmO/aroKD/xWmSAvHFJhaS6msIRRI9m7k0w37NNN2gMgbiQXS6oOqP3BB0TUXPRRHTEZZxPF4llQpFCcFTESdEbPrldmTFGXRUfgTkNynZNZMTMOEXncy8/QpJqZpFLzurjVbLf1JQyXtxep094tgLF9VMlYPbfjFBp4hfQ3e1WNaeAhvlT7XE5GHPTMFzKKF2LCjnM7JZQcMFilaH/UukbylA==; From: Alberto Garcia To: qemu-devel@nongnu.org Date: Tue, 28 Nov 2017 16:53:27 +0200 Message-Id: <20171128145327.17248-1-berto@igalia.com> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: [Qemu-devel] [PATCH for-2.11] blockjob: Remove the job from the list earlier in block_job_unref() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Jeff Cody , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When destroying a block job in block_job_unref() we should remove it from the job list before calling block_job_remove_all_bdrv(). This is because removing the BDSs can trigger an aio_poll() and wake up other jobs that might attempt to use the block job list. If that happens the job we're currently destroying should not be in that list anymore. --- blockjob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blockjob.c b/blockjob.c index ff9a614531..2f0cc1528b 100644 --- a/blockjob.c +++ b/blockjob.c @@ -152,6 +152,7 @@ void block_job_unref(BlockJob *job) { if (--job->refcnt =3D=3D 0) { BlockDriverState *bs =3D blk_bs(job->blk); + QLIST_REMOVE(job, job_list); bs->job =3D NULL; block_job_remove_all_bdrv(job); blk_remove_aio_context_notifier(job->blk, @@ -160,7 +161,6 @@ void block_job_unref(BlockJob *job) blk_unref(job->blk); error_free(job->blocker); g_free(job->id); - QLIST_REMOVE(job, job_list); g_free(job); } } --=20 2.11.0