From nobody Mon Apr 29 11:45:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1511877016485366.75145715530266; Tue, 28 Nov 2017 05:50:16 -0800 (PST) Received: from localhost ([::1]:38079 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJgH4-00028Z-RM for importer@patchew.org; Tue, 28 Nov 2017 08:50:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJgDv-00080p-Ri for qemu-devel@nongnu.org; Tue, 28 Nov 2017 08:47:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJgDu-0003Ba-NQ for qemu-devel@nongnu.org; Tue, 28 Nov 2017 08:46:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21004) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eJgDu-0003BE-H9; Tue, 28 Nov 2017 08:46:54 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 890887652C; Tue, 28 Nov 2017 13:46:53 +0000 (UTC) Received: from localhost (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DCAFB5C549; Tue, 28 Nov 2017 13:46:52 +0000 (UTC) From: Cornelia Huck To: qemu-devel@nongnu.org, qemu-s390x@nongnu.org Date: Tue, 28 Nov 2017 14:46:47 +0100 Message-Id: <20171128134648.21530-2-cohuck@redhat.com> In-Reply-To: <20171128134648.21530-1-cohuck@redhat.com> References: <20171128134648.21530-1-cohuck@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 28 Nov 2017 13:46:53 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH RFC 1/2] s390x/css: attach css bridge X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: borntraeger@de.ibm.com, pasic@linux.vnet.ibm.com, Cornelia Huck , pmorel@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Logically, the css bridge should be attached to the machine. Signed-off-by: Cornelia Huck Reviewed-by: Christian Borntraeger Reviewed-by: David Hildenbrand --- hw/s390x/css-bridge.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/s390x/css-bridge.c b/hw/s390x/css-bridge.c index c4a9735d71..84d33eafc2 100644 --- a/hw/s390x/css-bridge.c +++ b/hw/s390x/css-bridge.c @@ -99,6 +99,8 @@ VirtualCssBus *virtual_css_bus_init(void) =20 /* Create bridge device */ dev =3D qdev_create(NULL, TYPE_VIRTUAL_CSS_BRIDGE); + object_property_add_child(qdev_get_machine(), TYPE_VIRTUAL_CSS_BRIDGE, + OBJECT(dev), NULL); qdev_init_nofail(dev); =20 /* Create bus on bridge device */ --=20 2.13.6 From nobody Mon Apr 29 11:45:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 151187693510514.416040204515298; Tue, 28 Nov 2017 05:48:55 -0800 (PST) Received: from localhost ([::1]:38068 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJgFg-0000hG-51 for importer@patchew.org; Tue, 28 Nov 2017 08:48:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJgE2-0008B1-AE for qemu-devel@nongnu.org; Tue, 28 Nov 2017 08:47:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJgDw-0003CX-JZ for qemu-devel@nongnu.org; Tue, 28 Nov 2017 08:47:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49956) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eJgDw-0003Bu-DN; Tue, 28 Nov 2017 08:46:56 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 786A17652C; Tue, 28 Nov 2017 13:46:55 +0000 (UTC) Received: from localhost (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 15DE3600D5; Tue, 28 Nov 2017 13:46:54 +0000 (UTC) From: Cornelia Huck To: qemu-devel@nongnu.org, qemu-s390x@nongnu.org Date: Tue, 28 Nov 2017 14:46:48 +0100 Message-Id: <20171128134648.21530-3-cohuck@redhat.com> In-Reply-To: <20171128134648.21530-1-cohuck@redhat.com> References: <20171128134648.21530-1-cohuck@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 28 Nov 2017 13:46:55 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH RFC 2/2] s390x: attach autogenerated nics X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: borntraeger@de.ibm.com, pasic@linux.vnet.ibm.com, Cornelia Huck , pmorel@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The autogenerated nics should be treated as any other device; use qdev_set_id() to have them show up under peripheral-anon. Signed-off-by: Cornelia Huck Reviewed-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index a23b8aec9f..830bae9d0f 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -35,6 +35,7 @@ #include "cpu_models.h" #include "qapi/qmp/qerror.h" #include "hw/nmi.h" +#include "include/monitor/qdev.h" =20 S390CPU *s390_cpu_addr2state(uint16_t cpu_addr) { @@ -259,6 +260,7 @@ static void s390_create_virtio_net(BusState *bus, const= char *name) =20 dev =3D qdev_create(bus, name); qdev_set_nic_properties(dev, nd); + qdev_set_id(dev, NULL); qdev_init_nofail(dev); } } --=20 2.13.6