[v1] build: fix typo in error message

[Qemu-devel] [PATCH] build: fix typo in error message

Mike Frysinger posted 1 patch 6 years, 4 months ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171127174944.12362-1-vapier@gentoo.org

Test checkpatch passed

Test docker passed

Test ppc passed

Test s390x passed

scripts/git-submodule.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] build: fix typo in error message

Posted by Mike Frysinger 6 years, 4 months ago

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 scripts/git-submodule.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh
index 030617b4ac0c..bc7224a27fe3 100755
--- a/scripts/git-submodule.sh
+++ b/scripts/git-submodule.sh
@@ -24,7 +24,7 @@ error() {
     echo "Alternatively you may disable automatic GIT submodule checkout"
     echo "with:"
     echo
-    echo " $ ./configure --disable-git-update'"
+    echo " $ ./configure --disable-git-update"
     echo
     echo "and then manually update submodules prior to running make, with:"
     echo
-- 
2.12.0

Re: [Qemu-devel] [PATCH] build: fix typo in error message

Posted by John Snow 6 years, 4 months ago


On 11/27/2017 12:49 PM, Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  scripts/git-submodule.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh
> index 030617b4ac0c..bc7224a27fe3 100755
> --- a/scripts/git-submodule.sh
> +++ b/scripts/git-submodule.sh
> @@ -24,7 +24,7 @@ error() {
>      echo "Alternatively you may disable automatic GIT submodule checkout"
>      echo "with:"
>      echo
> -    echo " $ ./configure --disable-git-update'"
> +    echo " $ ./configure --disable-git-update"
>      echo
>      echo "and then manually update submodules prior to running make, with:"
>      echo
> 

cc qemu-trivial

Reviewed-by: John Snow <jsnow@redhat.com>

Re: [Qemu-devel] [PATCH] build: fix typo in error message

Posted by Eric Blake 6 years, 4 months ago

On 11/27/2017 11:49 AM, Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  scripts/git-submodule.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh
> index 030617b4ac0c..bc7224a27fe3 100755
> --- a/scripts/git-submodule.sh
> +++ b/scripts/git-submodule.sh
> @@ -24,7 +24,7 @@ error() {
>      echo "Alternatively you may disable automatic GIT submodule checkout"
>      echo "with:"
>      echo
> -    echo " $ ./configure --disable-git-update'"
> +    echo " $ ./configure --disable-git-update"

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org