[Qemu-devel] [PATCH v2 0/2] add UUID property type

Roman Kagan posted 2 patches 6 years, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171127130518.26703-1-rkagan@virtuozzo.com
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
include/hw/qdev-properties.h |  9 +++++++
hw/acpi/vmgenid.c            | 30 ++++++----------------
hw/core/qdev-properties.c    | 61 ++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 78 insertions(+), 22 deletions(-)
[Qemu-devel] [PATCH v2 0/2] add UUID property type
Posted by Roman Kagan 6 years, 4 months ago
UUIDs (GUIDs) are widely used in VMBus-related stuff, so a dedicated
property type becomes helpful.

In the existing code, vmgenid can immediately profit from it.

Roman Kagan (2):
  qdev-properties: add UUID property type
  vmgenid: use UUID property type

v1 -> v2:
 - make the property default to autogeneration if not specified
   explicitly
 - use the corresponding define for "guid" field name

 include/hw/qdev-properties.h |  9 +++++++
 hw/acpi/vmgenid.c            | 30 ++++++----------------
 hw/core/qdev-properties.c    | 61 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 78 insertions(+), 22 deletions(-)

-- 
2.14.3


Re: [Qemu-devel] [PATCH v2 0/2] add UUID property type
Posted by Roman Kagan 6 years, 3 months ago
On Mon, Nov 27, 2017 at 04:05:16PM +0300, Roman Kagan wrote:
> UUIDs (GUIDs) are widely used in VMBus-related stuff, so a dedicated
> property type becomes helpful.
> 
> In the existing code, vmgenid can immediately profit from it.
> 
> Roman Kagan (2):
>   qdev-properties: add UUID property type
>   vmgenid: use UUID property type
> 
> v1 -> v2:
>  - make the property default to autogeneration if not specified
>    explicitly
>  - use the corresponding define for "guid" field name
> 
>  include/hw/qdev-properties.h |  9 +++++++
>  hw/acpi/vmgenid.c            | 30 ++++++----------------
>  hw/core/qdev-properties.c    | 61 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 78 insertions(+), 22 deletions(-)

Ping?

Re: [Qemu-devel] [PATCH v2 0/2] add UUID property type
Posted by Michael S. Tsirkin 6 years, 3 months ago
On Wed, Dec 20, 2017 at 04:51:31PM +0300, Roman Kagan wrote:
> On Mon, Nov 27, 2017 at 04:05:16PM +0300, Roman Kagan wrote:
> > UUIDs (GUIDs) are widely used in VMBus-related stuff, so a dedicated
> > property type becomes helpful.
> > 
> > In the existing code, vmgenid can immediately profit from it.
> > 
> > Roman Kagan (2):
> >   qdev-properties: add UUID property type
> >   vmgenid: use UUID property type
> > 
> > v1 -> v2:
> >  - make the property default to autogeneration if not specified
> >    explicitly
> >  - use the corresponding define for "guid" field name
> > 
> >  include/hw/qdev-properties.h |  9 +++++++
> >  hw/acpi/vmgenid.c            | 30 ++++++----------------
> >  hw/core/qdev-properties.c    | 61 ++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 78 insertions(+), 22 deletions(-)
> 
> Ping?

It's in my queue, will be in the next pull request.