[Qemu-devel] [PATCH v4 0/1] Use rightc parames (was Make xbzrle_cache_size a migration parameter)

Juan Quintela posted 1 patch 6 years, 4 months ago
Failed in applying to current master (apply log)
hmp.c                 | 22 +++++++++++-----------
migration/migration.c | 49 ++++++++++++++++++++-----------------------------
qapi/migration.json   | 22 +++++++++++-----------
3 files changed, 42 insertions(+), 51 deletions(-)
[Qemu-devel] [PATCH v4 0/1] Use rightc parames (was Make xbzrle_cache_size a migration parameter)
Posted by Juan Quintela 6 years, 4 months ago
Hi

On v4:
- Markus agreed that the change on sizes are right, so resend without RFC.

Rest of patches already in, please review.

Later, Juan.

On v3:
- rebase on top of last migration pull requset
- improve comments (dave suggestion)
- always return 0 in case of error
- checked with ovirt/openstack/libvirt people that making value a
  power of two is not a problem.
- should I drop the last patch, or sent it?


Please revieww.

[v2]

- rebase
- fix comments about power of 2 instead of multiple of two
- minor typo on error message
- use Error * when setting values

After asking people of libvirt/ovirt/openstack, it appears that there
is no problem about restricting cache_size to real values.  We give
back one error and they had to handle errors already.

Please review, Juan.

[v1]

I started looking at xbzrle_cache_size and saw that it was not a parameter.
How difficult could it be?  HaHa

- x-multifd-page-count and x-multifd-channels were not o
  migrate_test_apply

- page_cache.c has parameters that were not used (max_item_age)

- page cache types were random.  Move almost all to int/size_t as
  appropiate

- error handling was split in three functions:
  xbzrle_cache_resize
  cache_init
  qmp_set_cache_size
  Make some sense of it and use Error*

- We pass one value to qmp_migrate_cache_size it asigned pow2log() of
  that value, and cache_init() used a power of two.  Make sure that
  the value passed is right.

- Now I am able to make xbzrle_cache_size a parameter!!!!

- Now that I have arrived here, I tried to make the json types for
  migartion parameters the real ones instead of everything is an int64.
  I will be happy if libvirt people checked this.

Please review, Juan.

Juan Quintela (1):
  migration: Use proper types in json

 hmp.c                 | 22 +++++++++++-----------
 migration/migration.c | 49 ++++++++++++++++++++-----------------------------
 qapi/migration.json   | 22 +++++++++++-----------
 3 files changed, 42 insertions(+), 51 deletions(-)

-- 
2.13.6