[Qemu-devel] [PULL for-2.11 0/1] qemu-ga patch queue for 2.11

Michael Roth posted 1 patch 6 years, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171120215034.22212-1-mdroth@linux.vnet.ibm.com
Test checkpatch failed
Test docker passed
Test ppc passed
Test s390x passed
qga/commands-win32.c | 54 ++++++++++++++++++++++++++++++++++++----------------
1 file changed, 38 insertions(+), 16 deletions(-)
[Qemu-devel] [PULL for-2.11 0/1] qemu-ga patch queue for 2.11
Posted by Michael Roth 6 years, 4 months ago
The following changes since commit b2996bb405e2806725a341c72d80be9e77ed8b82:

  Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.11-20171120' into staging (2017-11-20 18:00:16 +0000)

are available in the git repository at:

  git://github.com/mdroth/qemu.git tags/qga-pull-2017-11-20-tag

for you to fetch changes up to df83eabd5245828cbca32060aa191d8b03bc5d50:

  qga: replace GetIfEntry with GetIfEntry2 for interface stats (2017-11-20 14:45:31 -0600)

----------------------------------------------------------------
qemu-ga patch queue for 2.11

* fix potential overflow in network interface stats reporting

----------------------------------------------------------------
ZhiPeng Lu (1):
      qga: replace GetIfEntry with GetIfEntry2 for interface stats

 qga/commands-win32.c | 54 ++++++++++++++++++++++++++++++++++++----------------
 1 file changed, 38 insertions(+), 16 deletions(-)


Re: [Qemu-devel] [PULL for-2.11 0/1] qemu-ga patch queue for 2.11
Posted by no-reply@patchew.org 6 years, 4 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL for-2.11 0/1] qemu-ga patch queue for 2.11
Type: series
Message-id: 20171120215034.22212-1-mdroth@linux.vnet.ibm.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20171120215034.22212-1-mdroth@linux.vnet.ibm.com -> patchew/20171120215034.22212-1-mdroth@linux.vnet.ibm.com
Switched to a new branch 'test'
4dc0db9e07 qga: replace GetIfEntry with GetIfEntry2 for interface stats

=== OUTPUT BEGIN ===
Checking PATCH 1/1: qga: replace GetIfEntry with GetIfEntry2 for interface stats...
ERROR: space prohibited between function name and open parenthesis '('
#26: FILE: qga/commands-win32.c:1173:
+typedef NETIOAPI_API (WINAPI *GetIfEntry2Func)(PMIB_IF_ROW2 Row);

ERROR: spaces required around that '*' (ctx:WxV)
#26: FILE: qga/commands-win32.c:1173:
+typedef NETIOAPI_API (WINAPI *GetIfEntry2Func)(PMIB_IF_ROW2 Row);
                              ^

total: 2 errors, 0 warnings, 62 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PULL for-2.11 0/1] qemu-ga patch queue for 2.11
Posted by Peter Maydell 6 years, 4 months ago
On 20 November 2017 at 21:50, Michael Roth <mdroth@linux.vnet.ibm.com> wrote:
> The following changes since commit b2996bb405e2806725a341c72d80be9e77ed8b82:
>
>   Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.11-20171120' into staging (2017-11-20 18:00:16 +0000)
>
> are available in the git repository at:
>
>   git://github.com/mdroth/qemu.git tags/qga-pull-2017-11-20-tag
>
> for you to fetch changes up to df83eabd5245828cbca32060aa191d8b03bc5d50:
>
>   qga: replace GetIfEntry with GetIfEntry2 for interface stats (2017-11-20 14:45:31 -0600)
>
> ----------------------------------------------------------------
> qemu-ga patch queue for 2.11
>
> * fix potential overflow in network interface stats reporting
>
> ----------------------------------------------------------------
> ZhiPeng Lu (1):
>       qga: replace GetIfEntry with GetIfEntry2 for interface stats
>
>  qga/commands-win32.c | 54 ++++++++++++++++++++++++++++++++++++----------------
>  1 file changed, 38 insertions(+), 16 deletions(-)
>

Applied, thanks.

-- PMM